Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-2802 Support for RW/RO snapshots in HDFS
  3. HDFS-4245

Include snapshot related operations in OfflineEditsViewerHelper#runOperations() to fix test failures in TestOfflineEditsViewer

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • Snapshot (HDFS-2802)
    • test
    • None
    • Reviewed

    Description

      We have the following test failure for snapshot:

      java.lang.AssertionError: Edits /home/jenkins/jenkins-slave/workspace/Hadoop-Hdfs-Snapshots-Branch-build/trunk/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/name/current/edits_0000000000000000001-0000000000000000059 should have all op codes
      	at org.junit.Assert.fail(Assert.java:91)
      	at org.junit.Assert.assertTrue(Assert.java:43)
      	at org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer.__CLR3_0_2lvw0fw1wtx(TestOfflineEditsViewer.java:103)
      	at org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer.testGenerated(TestOfflineEditsViewer.java:86)
              ...
      
      java.lang.AssertionError: Edits /home/jenkins/jenkins-slave/workspace/Hadoop-Hdfs-Snapshots-Branch-build/trunk/hadoop-hdfs-project/hadoop-hdfs/target/test-classes/editsStored should have all op codes
      	at org.junit.Assert.fail(Assert.java:91)
      	at org.junit.Assert.assertTrue(Assert.java:43)
      	at org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer.__CLR3_0_2yzsf441wup(TestOfflineEditsViewer.java:171)
      	at org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer.testStored(TestOfflineEditsViewer.java:153)
              ...
      

      We need to update OfflineEditsViewerHelper#runOperations() and editsStored to include snapshot related operations.

      Attachments

        1. editsStored
          3 kB
          Jing Zhao
        2. editsStored
          3 kB
          Jing Zhao
        3. HDFS-4245.001.patch
          28 kB
          Jing Zhao
        4. HDFS-4245.002.patch
          28 kB
          Jing Zhao

        Activity

          People

            jingzhao Jing Zhao
            jingzhao Jing Zhao
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: