Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-4242

Map.Entry is incorrectly used in LeaseManager

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.3-alpha, 0.23.6
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As Daryn pointed out, the behavior of Map.Entry is undefined after the iteration or modifications of the map.

      1. h4242_20121129.patch
        3 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          h4242_20121129.patch: return Map<String, Lease> instead of List<Map.Entry<String, Lease>>.

          Show
          Tsz Wo Nicholas Sze added a comment - h4242_20121129.patch: return Map<String, Lease> instead of List<Map.Entry<String, Lease>>.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12555407/h4242_20121129.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3577//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3577//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12555407/h4242_20121129.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3577//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3577//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          +1, the patch looks good to me.

          Show
          Aaron T. Myers added a comment - +1, the patch looks good to me.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Aaron, thanks for the review.

          I have committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - Aaron, thanks for the review. I have committed this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3073 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3073/)
          HDFS-4242. Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (Revision 1415480)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415480
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #3073 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3073/ ) HDFS-4242 . Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (Revision 1415480) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415480 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #52 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/52/)
          HDFS-4242. Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (Revision 1415480)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415480
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Yarn-trunk #52 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/52/ ) HDFS-4242 . Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (Revision 1415480) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415480 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1242 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1242/)
          HDFS-4242. Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (Revision 1415480)

          Result = FAILURE
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415480
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1242 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1242/ ) HDFS-4242 . Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (Revision 1415480) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415480 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1273 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1273/)
          HDFS-4242. Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (Revision 1415480)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415480
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1273 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1273/ ) HDFS-4242 . Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (Revision 1415480) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415480 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
          Hide
          Daryn Sharp added a comment -

          I pulled this back into 23. Someone should help investigate if the same fix is required in 1.x. Otherwise I'll try to look into it after getting all related patches integrated.

          Show
          Daryn Sharp added a comment - I pulled this back into 23. Someone should help investigate if the same fix is required in 1.x. Otherwise I'll try to look into it after getting all related patches integrated.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #452 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/452/)
          HDFS-4242. Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (szetszwo via daryn) (Revision 1415682)

          Result = SUCCESS
          daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415682
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #452 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/452/ ) HDFS-4242 . Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (szetszwo via daryn) (Revision 1415682) Result = SUCCESS daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415682 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development