Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Originally it was committed in HDFS-708 and MAPREDUCE-1804

        Activity

        Arpit Gupta created issue -
        Arpit Gupta made changes -
        Field Original Value New Value
        Assignee Arpit Gupta [ arpitgupta ]
        Arpit Gupta made changes -
        Description Originally it was committed in HDFS-708 and MAPREDUCE-1804
        Arpit Gupta made changes -
        Attachment HDFS-4219.branch-1.patch [ 12554447 ]
        Hide
        Arpit Gupta added a comment -

        It was a straight forward port by taking the code from trunk (hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/fs/slive) to branch-1. Had to change SliveMapper.java

        if(conf.get(MRJobConfig.TASK_ATTEMPT_ID) != null ) {
              this.taskId = TaskAttemptID.forName(conf.get(MRJobConfig.TASK_ATTEMPT_ID))
                .getTaskID().getId();
            } else {
              // So that branch-1/0.20 can run this same code as well
              this.taskId = TaskAttemptID.forName(conf.get("mapred.task.id"))
                  .getTaskID().getId();
            }
        
        

        and remove the if/else block and just make it

        this.taskId = TaskAttemptID.forName(conf.get("mapred.task.id"))
                  .getTaskID().getId();
        

        As the MRJobConfig is not available in branch-1

        Show
        Arpit Gupta added a comment - It was a straight forward port by taking the code from trunk (hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/fs/slive) to branch-1. Had to change SliveMapper.java if (conf.get(MRJobConfig.TASK_ATTEMPT_ID) != null ) { this .taskId = TaskAttemptID.forName(conf.get(MRJobConfig.TASK_ATTEMPT_ID)) .getTaskID().getId(); } else { // So that branch-1/0.20 can run this same code as well this .taskId = TaskAttemptID.forName(conf.get( "mapred.task.id" )) .getTaskID().getId(); } and remove the if/else block and just make it this .taskId = TaskAttemptID.forName(conf.get( "mapred.task.id" )) .getTaskID().getId(); As the MRJobConfig is not available in branch-1
        Hide
        Arpit Gupta added a comment -

        I will update the jira with the results of test patch when done.

        Show
        Arpit Gupta added a comment - I will update the jira with the results of test patch when done.
        Hide
        Arpit Gupta added a comment -

        Here is the output from test patch

        [exec] 
             [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     +1 tests included.  The patch appears to include 78 new or modified tests.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     -1 findbugs.  The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings.
             [exec] 
             [exec] 
             [exec] 
             [exec] 
             [exec] ======================================================================
             [exec] ======================================================================
             [exec]     Finished build.
             [exec] ======================================================================
             [exec] ======================================================================
             [exec] 
             [exec] 
        

        Findbug warnings are not related to this patch.

        Show
        Arpit Gupta added a comment - Here is the output from test patch [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 78 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== [exec] [exec] Findbug warnings are not related to this patch.
        Hide
        Suresh Srinivas added a comment -

        +1. Seems like a straightforward port.

        Show
        Suresh Srinivas added a comment - +1. Seems like a straightforward port.
        Hide
        Suresh Srinivas added a comment -

        I committed the patch to branch-1. Thank you Arpit.

        Show
        Suresh Srinivas added a comment - I committed the patch to branch-1. Thank you Arpit.
        Suresh Srinivas made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 1.2.0 [ 12321657 ]
        Resolution Fixed [ 1 ]
        Hide
        Matt Foley added a comment -

        Closed upon release of Hadoop 1.2.0.

        Show
        Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
        Matt Foley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arpit Gupta
            Reporter:
            Arpit Gupta
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development