Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2802 Support for RW/RO snapshots in HDFS
  3. HDFS-4146

Further work on changing INodeFile.blocks to private in Snapshot branch

    Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Snapshot (HDFS-2802)
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There was a conflict in INodeFile when merging HDFS-4143 so that I keep INodeFile.blocks as protected. Otherwise, some code cannot be compiled. It needs some more works.

      1. h4146_20121104.patch
        5 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        h4146_20121104.patch: use getter and setter in INodeFileWithLink to access blocks. Also initialize root directory as snapshottable since it cannot be replaced.

        Show
        Tsz Wo Nicholas Sze added a comment - h4146_20121104.patch: use getter and setter in INodeFileWithLink to access blocks. Also initialize root directory as snapshottable since it cannot be replaced.
        Hide
        Suresh Srinivas added a comment -

        +1 for the change.

        Show
        Suresh Srinivas added a comment - +1 for the change.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Suresh, thanks for the review.

        I have committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - Suresh, thanks for the review. I have committed this.

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development