Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      DFSFileInfo extends FileStatus.
      FileSystem uses FileStatus.
      DFSFileInfo does not add any functionality. Remove it.

      1. removeDFSInfo.patch
        24 kB
        Sanjay Radia
      2. removeDFSInfo2.patch
        24 kB
        Sanjay Radia
      3. removeDFSInfo3_updated.patch
        25 kB
        Tsz Wo Nicholas Sze
      4. removeDFSInfo3.patch
        24 kB
        Sanjay Radia

        Activity

        Hide
        Sanjay Radia added a comment -

        Turns we can remove DFSFileInfo completely.

        Show
        Sanjay Radia added a comment - Turns we can remove DFSFileInfo completely.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12389847/removeDFSInfo2.patch
        against trunk revision 693705.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3240/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3240/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3240/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3240/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12389847/removeDFSInfo2.patch against trunk revision 693705. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3240/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3240/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3240/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3240/console This message is automatically generated.
        Hide
        Hairong Kuang added a comment -

        +1 on the change. One minor comment: For the static method createFileStatus in FsDirectory, is it easier to maintain the code if we make it to be a member method of INode?

        Show
        Hairong Kuang added a comment - +1 on the change. One minor comment: For the static method createFileStatus in FsDirectory, is it easier to maintain the code if we make it to be a member method of INode?
        Hide
        Tsz Wo Nicholas Sze added a comment -

        createFileStatus(...) is used in FSDirectory. It might be better to make it private static in FSDirectory.

        Show
        Tsz Wo Nicholas Sze added a comment - createFileStatus(...) is used in FSDirectory. It might be better to make it private static in FSDirectory.
        Hide
        Sanjay Radia added a comment -

        Decided to go with Nicolas's suggestion of private static method as this method
        is only used in FSDirectory.

        Show
        Sanjay Radia added a comment - Decided to go with Nicolas's suggestion of private static method as this method is only used in FSDirectory.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12390087/removeDFSInfo3.patch
        against trunk revision 695844.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3271/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3271/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3271/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3271/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12390087/removeDFSInfo3.patch against trunk revision 695844. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3271/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3271/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3271/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3271/console This message is automatically generated.
        Hide
        dhruba borthakur added a comment -

        The test failure does not seem to be related to this patch.

        Show
        dhruba borthakur added a comment - The test failure does not seem to be related to this patch.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good but it conflicts with the current trunk.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good but it conflicts with the current trunk.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        removeDFSInfo3_updated.patch: updated with trunk

        Show
        Tsz Wo Nicholas Sze added a comment - removeDFSInfo3_updated.patch: updated with trunk
        Hide
        Hairong Kuang added a comment -

        I just committed this. Thank you Sanjay!

        Show
        Hairong Kuang added a comment - I just committed this. Thank you Sanjay!
        Hide
        dhruba borthakur added a comment -

        This patch leaves an empty DFSFileInfo.java file in the svn. Is this on purpose?

        Show
        dhruba borthakur added a comment - This patch leaves an empty DFSFileInfo.java file in the svn. Is this on purpose?
        Hide
        Hairong Kuang added a comment -

        The empty file is removed.

        Show
        Hairong Kuang added a comment - The empty file is removed.
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #611 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/611/ )

          People

          • Assignee:
            Sanjay Radia
            Reporter:
            Sanjay Radia
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development