> ... so the issue for
HDFS-4261 is not existing here. Thoughts?
I think you are right. How about also add the new test in
HDFS-4261 to branch-1?
Some more comments on the patch:
- TestBalancerWithNodeGroup should use junit 4 and not extend TestCase.
- Change the comment on top of isOnSameNodeGroupWithReplicas(..) to javadoc and copy the javadoc from trunk.
- In TestBalancerWithNodeGroup, the waitForHeartBeat(..) and runBalancer(..) are at the end but they are put near the beginning in trunk. Could you make order them the same way? In general, please make the code the same for both trunk and branch-1 so that it is easier to maintain.