Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3928

MiniDFSCluster should reset the first ExitException on shutdown

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.2-alpha
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MiniDFSCluster doesn't reset the first exception on shutdown so if one tests fails due to an ExitException subsequent tests will as well.

      1. hdfs-3928.txt
        0.7 kB
        Eli Collins

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          Patch attached. I verified (via inserting a call to ExitUtil#terminate) that if one of the tests in TestListCorruptFileBlocks fails due to an exit exception the others still pass.

          Show
          Eli Collins added a comment - Patch attached. I verified (via inserting a call to ExitUtil#terminate) that if one of the tests in TestListCorruptFileBlocks fails due to an exit exception the others still pass.
          Hide
          Aaron T. Myers added a comment -

          +1, the patch looks good to me.

          I think it would be best long-term to move the ExitUtil checks out of MiniDFSCluster and into pre/post test case methods, which can probably be done via a JUnit RunListener, similarly to the patch that's posted to HADOOP-8755. That can certainly be done in a separate JIRA, though, and should maybe be done after HADOOP-8755 goes in.

          Show
          Aaron T. Myers added a comment - +1, the patch looks good to me. I think it would be best long-term to move the ExitUtil checks out of MiniDFSCluster and into pre/post test case methods, which can probably be done via a JUnit RunListener, similarly to the patch that's posted to HADOOP-8755 . That can certainly be done in a separate JIRA, though, and should maybe be done after HADOOP-8755 goes in.
          Hide
          Eli Collins added a comment -

          Good idea, filed HDFS-3929.

          Show
          Eli Collins added a comment - Good idea, filed HDFS-3929 .
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12544848/hdfs-3928.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestDatanodeBlockScanner

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3181//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3181//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544848/hdfs-3928.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDatanodeBlockScanner +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3181//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3181//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          TestDatanodeBlockScanner is a known issue.

          Show
          Eli Collins added a comment - TestDatanodeBlockScanner is a known issue.
          Hide
          Eli Collins added a comment -

          I've committed this and merged to branch-2 and branch-2.0.2-alph. Thanks for the review ATM.

          Show
          Eli Collins added a comment - I've committed this and merged to branch-2 and branch-2.0.2-alph. Thanks for the review ATM.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2726 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2726/)
          HDFS-3928. MiniDFSCluster should reset the first ExitException on shutdown. Contributed by Eli Collins (Revision 1384092)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384092
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2726 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2726/ ) HDFS-3928 . MiniDFSCluster should reset the first ExitException on shutdown. Contributed by Eli Collins (Revision 1384092) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384092 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2789 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2789/)
          HDFS-3928. MiniDFSCluster should reset the first ExitException on shutdown. Contributed by Eli Collins (Revision 1384092)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384092
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2789 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2789/ ) HDFS-3928 . MiniDFSCluster should reset the first ExitException on shutdown. Contributed by Eli Collins (Revision 1384092) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384092 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2750 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2750/)
          HDFS-3928. MiniDFSCluster should reset the first ExitException on shutdown. Contributed by Eli Collins (Revision 1384092)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384092
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2750 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2750/ ) HDFS-3928 . MiniDFSCluster should reset the first ExitException on shutdown. Contributed by Eli Collins (Revision 1384092) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384092 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1164 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1164/)
          HDFS-3928. MiniDFSCluster should reset the first ExitException on shutdown. Contributed by Eli Collins (Revision 1384092)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384092
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1164 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1164/ ) HDFS-3928 . MiniDFSCluster should reset the first ExitException on shutdown. Contributed by Eli Collins (Revision 1384092) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384092 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1195 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1195/)
          HDFS-3928. MiniDFSCluster should reset the first ExitException on shutdown. Contributed by Eli Collins (Revision 1384092)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384092
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1195 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1195/ ) HDFS-3928 . MiniDFSCluster should reset the first ExitException on shutdown. Contributed by Eli Collins (Revision 1384092) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384092 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development