Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-3848

A Bug in recoverLeaseInternal method of FSNameSystem class

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1
    • Fix Version/s: 2.5.0
    • Component/s: namenode
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This is a bug in logic of the method recoverLeaseInternal. In line 1322 it checks if the owner of the file is trying to recreate the file. The condition of the if statement is

      (leaseFile != null && leaseFile.equals(lease)) || lease.getHolder().equals(holder)

      As it can be seen, there are two operands (conditions) connected with an "or" operator. The first operand is straight and will be true only if the holder of the file is the new holder. But the problem is the second operand which will be always true since the "lease" object is the one found by the "holder" by calling "Lease lease = leaseManager.getLease(holder);" in line 1315.

      To fix this I think the if statement only should contain the following the condition:
      (leaseFile != null && leaseFile.getHolder().equals(holder))

        Attachments

        1. HDFS-3848-v2.patch
          3 kB
          Chen He
        2. HDFS-3848-1.patch
          1.0 kB
          Hooman Peiro Sajjad

          Activity

            People

            • Assignee:
              airbots Chen He
              Reporter:
              shps Hooman Peiro Sajjad
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified