[HDFS-3837] Fix DataNode.recoverBlock findbugs warning

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-alpha
• Fix Version/s: 2.0.2-alpha
• Component/s: datanode
• Hadoop Flags: Reviewed
• Assignee: Eli Collins
• Reporter: Eli Collins
• Created: 22/Aug/12 16:10
• Updated: 09/Nov/15 17:57
• Resolved: 30/Aug/12 22:10

Description

HDFS-2686 introduced the following findbugs warning:

Call to equals() comparing different types in org.apache.hadoop.hdfs.server.datanode.DataNode.recoverBlock(BlockRecoveryCommand$RecoveringBlock)

Both are using DatanodeID#equals but it's a different method because DNR#equals overrides equals for some reason (doesn't change behavior).

Issue Links

• is related to: HDFS-9401 Fix findbugs warnings in BlockRecoveryWorker
• relates to: HDFS-3850 Fix two findbugs warnings due to HDFS-3837