Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: QuorumJournalManager (HDFS-3077)
    • Component/s: ha
    • Labels:
      None

      Description

      Currently, if the client calls finalizeLogSegment() on a segment which doesn't exist on the JournalNode side, it throws an NPE. Instead it should throw a more intelligible exception.

      1. hdfs-3798.txt
        4 kB
        Todd Lipcon
      2. hdfs-3798.txt
        4 kB
        Todd Lipcon

        Activity

        Todd Lipcon created issue -
        Todd Lipcon made changes -
        Field Original Value New Value
        Attachment hdfs-3798.txt [ 12540790 ]
        Hide
        Aaron T. Myers added a comment -

        The tests which catch expected exceptions should call fail() if the exception isn't thrown.

        Otherwise the patch looks good. +1 once this is addressed.

        Show
        Aaron T. Myers added a comment - The tests which catch expected exceptions should call fail() if the exception isn't thrown. Otherwise the patch looks good. +1 once this is addressed.
        Hide
        Todd Lipcon added a comment -

        addresses the test problem above. I'll commit this to the branch later today.

        Show
        Todd Lipcon added a comment - addresses the test problem above. I'll commit this to the branch later today.
        Todd Lipcon made changes -
        Attachment hdfs-3798.txt [ 12540939 ]
        Todd Lipcon made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s QuorumJournalManager (HDFS-3077) [ 12322478 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development