Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3077 Quorum-based protocol for reading and writing edit logs
  3. HDFS-3798

Avoid throwing NPE when finalizeSegment() is called on invalid segment

        Details

        • Type: Sub-task Sub-task
        • Status: Resolved
        • Priority: Trivial Trivial
        • Resolution: Fixed
        • Affects Version/s: QuorumJournalManager (HDFS-3077)
        • Fix Version/s: QuorumJournalManager (HDFS-3077)
        • Component/s: ha
        • Labels:
          None

          Description

          Currently, if the client calls finalizeLogSegment() on a segment which doesn't exist on the JournalNode side, it throws an NPE. Instead it should throw a more intelligible exception.

          1. Text File
            hdfs-3798.txt
            4 kB
            Todd Lipcon
          2. Text File
            hdfs-3798.txt
            4 kB
            Todd Lipcon

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Aaron T. Myers added a comment -

            The tests which catch expected exceptions should call fail() if the exception isn't thrown.

            Otherwise the patch looks good. +1 once this is addressed.

            Show
            Aaron T. Myers added a comment - The tests which catch expected exceptions should call fail() if the exception isn't thrown. Otherwise the patch looks good. +1 once this is addressed.
            Hide
            Permalink
            Todd Lipcon added a comment -

            addresses the test problem above. I'll commit this to the branch later today.

            Show
            Todd Lipcon added a comment - addresses the test problem above. I'll commit this to the branch later today.

              People

              • Assignee:
                Todd Lipcon
                Reporter:
                Todd Lipcon
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development