Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3768

Exception in TestJettyHelper is incorrect

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java:80

      throw new RuntimeException("Could not stop embedded servlet container, " + ex.getMessage(), ex);
      

      This is being thrown from createJettyServer and was copied and pasted from stop. Should say we can't start the servlet container.

      1. HDFS-3768.patch
        0.8 kB
        Eli Reisman

        Activity

        Jakob Homan created issue -
        Hide
        Alejandro Abdelnur added a comment -

        Yes, the exception message sould say 'start'. Other than the rest seems OK.

        Please provide some context on the failure you are seen.

        Show
        Alejandro Abdelnur added a comment - Yes, the exception message sould say 'start'. Other than the rest seems OK. Please provide some context on the failure you are seen.
        Hide
        Jakob Homan added a comment -

        The context is that, as described, the word is wrong.

        Show
        Jakob Homan added a comment - The context is that, as described, the word is wrong.
        Hide
        Alejandro Abdelnur added a comment -

        OK, then a patch doing 's/stop/start/' in the message solves your problem. Great, I've thought there was some failure issue.

        Show
        Alejandro Abdelnur added a comment - OK, then a patch doing 's/stop/start/' in the message solves your problem. Great, I've thought there was some failure issue.
        Hide
        Eli Reisman added a comment -

        here it is

        Show
        Eli Reisman added a comment - here it is
        Eli Reisman made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Labels newbie patch
        Eli Reisman made changes -
        Attachment HDFS-3768.patch [ 12539897 ]
        Jakob Homan made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Jakob Homan added a comment -

        re-submitting patch to trigger Jenkins

        Show
        Jakob Homan added a comment - re-submitting patch to trigger Jenkins
        Jakob Homan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12539897/HDFS-3768.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs-httpfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2974//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2974//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539897/HDFS-3768.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs-httpfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2974//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2974//console This message is automatically generated.
        Hide
        Jakob Homan added a comment -

        +1

        Show
        Jakob Homan added a comment - +1
        Hide
        Jakob Homan added a comment -

        Committed. Resolving. Thanks, Eli.

        Show
        Jakob Homan added a comment - Committed. Resolving. Thanks, Eli.
        Jakob Homan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 3.0.0 [ 12320356 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2630 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2630/)
        HDFS-3768. Exception in TestJettyHelper is incorrect. Contributed by Eli Reisman. (Revision 1370952)

        Result = SUCCESS
        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370952
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2630 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2630/ ) HDFS-3768 . Exception in TestJettyHelper is incorrect. Contributed by Eli Reisman. (Revision 1370952) Result = SUCCESS jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370952 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2565 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2565/)
        HDFS-3768. Exception in TestJettyHelper is incorrect. Contributed by Eli Reisman. (Revision 1370952)

        Result = SUCCESS
        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370952
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2565 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2565/ ) HDFS-3768 . Exception in TestJettyHelper is incorrect. Contributed by Eli Reisman. (Revision 1370952) Result = SUCCESS jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370952 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2585 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2585/)
        HDFS-3768. Exception in TestJettyHelper is incorrect. Contributed by Eli Reisman. (Revision 1370952)

        Result = FAILURE
        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370952
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2585 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2585/ ) HDFS-3768 . Exception in TestJettyHelper is incorrect. Contributed by Eli Reisman. (Revision 1370952) Result = FAILURE jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370952 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1130 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1130/)
        HDFS-3768. Exception in TestJettyHelper is incorrect. Contributed by Eli Reisman. (Revision 1370952)

        Result = SUCCESS
        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370952
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1130 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1130/ ) HDFS-3768 . Exception in TestJettyHelper is incorrect. Contributed by Eli Reisman. (Revision 1370952) Result = SUCCESS jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370952 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1162 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1162/)
        HDFS-3768. Exception in TestJettyHelper is incorrect. Contributed by Eli Reisman. (Revision 1370952)

        Result = FAILURE
        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370952
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1162 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1162/ ) HDFS-3768 . Exception in TestJettyHelper is incorrect. Contributed by Eli Reisman. (Revision 1370952) Result = FAILURE jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1370952 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/test/TestJettyHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            Eli Reisman
            Reporter:
            Jakob Homan
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development