[HDFS-3710] libhdfs misuses O_RDONLY/WRONLY/RDWR

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0-alpha
• Fix Version/s: 2.0.2-alpha
• Component/s: libhdfs
• Hadoop Flags: Reviewed
• Assignee: Andy Isaacson
• Reporter: Andy Isaacson
• Created: 23/Jul/12 23:39
• Updated: 11/Oct/12 17:46
• Resolved: 08/Aug/12 19:34

Description

The O_RDONLY / O_WRONLY / O_RDWR macros in fcntl.h are not a bitmask; they are an enum stored in the low bits of the flag word. The proper way to use them is

if ((flags & O_ACCMODE) == O_RDONLY)

rather than

if ((flags & O_RDONLY) == 0)

There are many examples of this misuse in hdfs.c.

As a result of this incorrect testing, erroneous code may be accepted without error and correct code might not work correctly.

Issue Links

• relates to: HDFS-3579 libhdfs: fix exception handling