Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3679

fuse_dfs notrash option sets usetrash

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0, 1.0.1, 1.0.2, 1.0.3, 2.0.0-alpha
    • Fix Version/s: 1.2.0, 2.0.2-alpha
    • Component/s: fuse-dfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      fuse_dfs sets usetrash option when the "notrash" flag is given. This is the exact opposite of the desired behavior. The "usetrash" flag sets usetrash as well, but this is correct. Here are the relevant lines from fuse_options.c, in latest HDFS HEAD[0]:

      123 case KEY_USETRASH:
      124 options.usetrash = 1;
      125 break;
      126 case KEY_NOTRASH:
      127 options.usetrash = 1;
      128 break;

      This is a pretty trivial bug to fix. I'm not familiar with the process here, but I can attach a patch if needed.

      [0]: https://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c?view=markup

      1. hdfs-3679.diff
        0.3 kB
        Conrad Meyer

        Activity

        Hide
        Conrad Meyer added a comment -

        Trivial patch to fix issue.

        Show
        Conrad Meyer added a comment - Trivial patch to fix issue.
        Hide
        Suresh Srinivas added a comment -

        I added you as a contributor and assigned the patch to you. +1 for the patch. I will commit it soon.

        Show
        Suresh Srinivas added a comment - I added you as a contributor and assigned the patch to you. +1 for the patch. I will commit it soon.
        Hide
        Conrad Meyer added a comment -

        Great, thanks.

        Show
        Conrad Meyer added a comment - Great, thanks.
        Hide
        Suresh Srinivas added a comment -

        I committed the patch to trunk, branch-2 and branch-1. Thank you Conrad.

        Show
        Suresh Srinivas added a comment - I committed the patch to trunk, branch-2 and branch-1. Thank you Conrad.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2530 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2530/)
        HDFS-3679. fuse_dfs notrash option sets usetrash. Contributed by Conrad Meyer. (Revision 1366545)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366545
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2530 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2530/ ) HDFS-3679 . fuse_dfs notrash option sets usetrash. Contributed by Conrad Meyer. (Revision 1366545) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366545 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2594 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2594/)
        HDFS-3679. fuse_dfs notrash option sets usetrash. Contributed by Conrad Meyer. (Revision 1366545)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366545
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2594 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2594/ ) HDFS-3679 . fuse_dfs notrash option sets usetrash. Contributed by Conrad Meyer. (Revision 1366545) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366545 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2550 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2550/)
        HDFS-3679. fuse_dfs notrash option sets usetrash. Contributed by Conrad Meyer. (Revision 1366545)

        Result = FAILURE
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366545
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2550 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2550/ ) HDFS-3679 . fuse_dfs notrash option sets usetrash. Contributed by Conrad Meyer. (Revision 1366545) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366545 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1118 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1118/)
        HDFS-3679. fuse_dfs notrash option sets usetrash. Contributed by Conrad Meyer. (Revision 1366545)

        Result = FAILURE
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366545
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1118 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1118/ ) HDFS-3679 . fuse_dfs notrash option sets usetrash. Contributed by Conrad Meyer. (Revision 1366545) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366545 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1150 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1150/)
        HDFS-3679. fuse_dfs notrash option sets usetrash. Contributed by Conrad Meyer. (Revision 1366545)

        Result = FAILURE
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366545
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1150 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1150/ ) HDFS-3679 . fuse_dfs notrash option sets usetrash. Contributed by Conrad Meyer. (Revision 1366545) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366545 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c

          People

          • Assignee:
            Conrad Meyer
            Reporter:
            Conrad Meyer
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1m
              1m
              Remaining:
              Remaining Estimate - 1m
              1m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development