Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-3677

dfs.namenode.edits.dir.required missing from hdfs-default.xml

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This config should be documented. It's useful for cases where the user would like to ensure that (eg) an NFS filer always has the most up-to-date edits.

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9474 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9474/)
        HDFS-3677. dfs.namenode.edits.dir.required is missing from (aajisaka: rev 9b623fbaf79c0f854abc6b4a0539d4ea8c93dc1a)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9474 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9474/ ) HDFS-3677 . dfs.namenode.edits.dir.required is missing from (aajisaka: rev 9b623fbaf79c0f854abc6b4a0539d4ea8c93dc1a) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.8. Thanks Mark Yang for the contribution!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Mark Yang for the contribution!
        Hide
        ajisakaa Akira Ajisaka added a comment -

        The test failures look unrelated to the patch. Committing this.

        Show
        ajisakaa Akira Ajisaka added a comment - The test failures look unrelated to the patch. Committing this.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 36s trunk passed
        +1 compile 0m 41s trunk passed with JDK v1.8.0_74
        +1 compile 0m 41s trunk passed with JDK v1.7.0_95
        +1 mvnsite 0m 50s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 javadoc 1m 6s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 45s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.8.0_74
        +1 javac 0m 38s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.7.0_95
        +1 javac 0m 39s the patch passed
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 1m 3s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95
        -1 unit 56m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
        -1 unit 54m 9s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        130m 51s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics
          hadoop.hdfs.TestHFlush
        JDK v1.7.0_95 Failed junit tests hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs
          hadoop.hdfs.server.balancer.TestBalancer
          hadoop.hdfs.server.namenode.TestEditLog
          hadoop.hdfs.TestHFlush



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12562546/HDFS-3677.patch
        JIRA Issue HDFS-3677
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux dc2a9a6a26c7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / dc951e6
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14863/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14863/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14863/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14863/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14863/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14863/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 36s trunk passed +1 compile 0m 41s trunk passed with JDK v1.8.0_74 +1 compile 0m 41s trunk passed with JDK v1.7.0_95 +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 13s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 45s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_74 +1 javac 0m 38s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_95 +1 javac 0m 39s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 1m 3s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95 -1 unit 56m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 54m 9s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 130m 51s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.TestHFlush JDK v1.7.0_95 Failed junit tests hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12562546/HDFS-3677.patch JIRA Issue HDFS-3677 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux dc2a9a6a26c7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dc951e6 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14863/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14863/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14863/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14863/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14863/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14863/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1.
        Hide
        mark_yang Mark Yang added a comment -

        Hi Todd, I added the patch, please review.
        And I've filed a bug to address the bad experience problem.
        https://issues.apache.org/jira/browse/HDFS-4342

        Show
        mark_yang Mark Yang added a comment - Hi Todd, I added the patch, please review. And I've filed a bug to address the bad experience problem. https://issues.apache.org/jira/browse/HDFS-4342
        Hide
        tlipcon Todd Lipcon added a comment -

        Yea, it seems that's the case, and agreed it's a bad experience.

        I think we should either modify the behavior so that you only need to add it to the required list, or modify it so that if you list something in required that isn't in the actual dir list, it would fail to start with an invalid configuration error. Silent ignorance is no good.

        Show
        tlipcon Todd Lipcon added a comment - Yea, it seems that's the case, and agreed it's a bad experience. I think we should either modify the behavior so that you only need to add it to the required list, or modify it so that if you list something in required that isn't in the actual dir list, it would fail to start with an invalid configuration error. Silent ignorance is no good.
        Hide
        adi2 Andy Isaacson added a comment -

        Am I reading the code right that a given edits dir must be listed in both dfs.namenode.edits.dir and dfs.namenode.edits.dir.required for the latter to take effect, and if a directory is listed only in .required it will be silently ignored?

        If so, that's a pretty bad admin experience.

        Show
        adi2 Andy Isaacson added a comment - Am I reading the code right that a given edits dir must be listed in both dfs.namenode.edits.dir and dfs.namenode.edits.dir.required for the latter to take effect, and if a directory is listed only in .required it will be silently ignored? If so, that's a pretty bad admin experience.

          People

          • Assignee:
            mark_yang Mark Yang
            Reporter:
            tlipcon Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development