Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-362

FSEditLog should not writes long and short as UTF8 and should not use ArrayWritable for writing non-array items

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 0.24.0
    • Fix Version/s: 0.23.1
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In FSEditLog,

      • long and short are first converted to String and are further converted to UTF8
      • For some non-array items, it first create an ArrayWritable object to hold all the items and then writes the ArrayWritable object.

      These result creating many intermediate objects which affects Namenode CPU performance and Namenode restart.

      1. HDFS-362.patch
        18 kB
        Uma Maheswara Rao G
      2. HDFS-362.2e.patch
        38 kB
        Uma Maheswara Rao G
      3. HDFS-362.2d.patch
        33 kB
        Uma Maheswara Rao G
      4. HDFS-362.2d.patch
        33 kB
        Uma Maheswara Rao G
      5. HDFS-362.2c.patch
        32 kB
        Uma Maheswara Rao G
      6. HDFS-362.2b.patch
        30 kB
        Uma Maheswara Rao G
      7. HDFS-362.2.patch
        25 kB
        Uma Maheswara Rao G
      8. HDFS-362.1.patch
        20 kB
        Uma Maheswara Rao G

        Issue Links

          Activity

          Tsz Wo Nicholas Sze created issue -
          Hide
          Tsz Wo Nicholas Sze added a comment -
            static UTF8 toLogLong(long timestamp) {
              return new UTF8(Long.toString(timestamp));
            }
          
          void logRename(String src, String dst, long timestamp) {
              UTF8 info[] = new UTF8[] { 
                new UTF8(src),
                new UTF8(dst),
                FSEditLog.toLogLong(timestamp)};
              logEdit(OP_RENAME, new ArrayWritable(UTF8.class, info));
            }
          

          For example, logRename converts timestamp from long to UTF8. Then, it creates an ArrayWritable to hold everything. A better way would be using LongWritable and writing everything directly without creating an ArrayWritable.

          Show
          Tsz Wo Nicholas Sze added a comment - static UTF8 toLogLong( long timestamp) { return new UTF8( Long .toString(timestamp)); } void logRename( String src, String dst, long timestamp) { UTF8 info[] = new UTF8[] { new UTF8(src), new UTF8(dst), FSEditLog.toLogLong(timestamp)}; logEdit(OP_RENAME, new ArrayWritable(UTF8.class, info)); } For example, logRename converts timestamp from long to UTF8. Then, it creates an ArrayWritable to hold everything. A better way would be using LongWritable and writing everything directly without creating an ArrayWritable.
          Tsz Wo Nicholas Sze made changes -
          Field Original Value New Value
          Description In FSEditLog,

          - long and short are first converted to String and are further converted to UTF8

          - For some non-array items, it first create an ArrayWritable object to hold all the items and then writes the ArrayWritable object.

          These result creating many intermediate objects which affects Namenode CPU performance and Namenode restart.
          Tsz Wo Nicholas Sze made changes -
          Link This issue relates to HADOOP-3248 [ HADOOP-3248 ]
          Tsz Wo Nicholas Sze made changes -
          Link This issue is related to HADOOP-4539 [ HADOOP-4539 ]
          Owen O'Malley made changes -
          Project Hadoop Common [ 12310240 ] HDFS [ 12310942 ]
          Key HADOOP-3347 HDFS-362
          Component/s dfs [ 12310710 ]
          Uma Maheswara Rao G made changes -
          Assignee Uma Maheswara Rao G [ umamaheswararao ]
          Uma Maheswara Rao G made changes -
          Attachment HDFS-362.patch [ 12488890 ]
          Uma Maheswara Rao G made changes -
          Link This issue is blocked by HADOOP-7493 [ HADOOP-7493 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Introduced ShortWritable class (HADOOP-7493).
          So, first HADOOP-7493 should be committed, to apply this patch.

          Show
          Uma Maheswara Rao G added a comment - Introduced ShortWritable class ( HADOOP-7493 ). So, first HADOOP-7493 should be committed, to apply this patch.
          Hide
          Uma Maheswara Rao G added a comment -

          HDFS-362.patch: 1st patch for review!

          Show
          Uma Maheswara Rao G added a comment - HDFS-362 .patch: 1st patch for review!
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Uma Maheswara Rao G made changes -
          Component/s name-node [ 12312926 ]
          Uma Maheswara Rao G made changes -
          Attachment HDFS-362.1.patch [ 12489975 ]
          Uma Maheswara Rao G made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Updated patch against trunk!

          Show
          Uma Maheswara Rao G added a comment - Updated patch against trunk!
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12489975/HDFS-362.1.patch
          against trunk revision 1155998.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:

          -1 contrib tests. The patch failed contrib unit tests.

          -1 system test framework. The patch failed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1069//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1069//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12489975/HDFS-362.1.patch against trunk revision 1155998. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1069//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1069//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12489975/HDFS-362.1.patch
          against trunk revision 1155998.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:

          -1 contrib tests. The patch failed contrib unit tests.

          -1 system test framework. The patch failed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1074//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1074//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12489975/HDFS-362.1.patch against trunk revision 1155998. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1074//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1074//console This message is automatically generated.
          Uma Maheswara Rao G made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Uma Maheswara Rao G made changes -
          Attachment HDFS-362.1.patch [ 12489975 ]
          Uma Maheswara Rao G made changes -
          Attachment HDFS-362.1.patch [ 12490137 ]
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Cleaned some of the existing unused imports and variables.
          Updated the patch for review!

          Show
          Uma Maheswara Rao G added a comment - Cleaned some of the existing unused imports and variables. Updated the patch for review!
          Hide
          Eli Collins added a comment -

          This change removes fields, removes version checks (eg MkdirOp#readFields), etc. It's an incompatible change that would cause an upgrade to fail.

          Show
          Eli Collins added a comment - This change removes fields, removes version checks (eg MkdirOp#readFields), etc. It's an incompatible change that would cause an upgrade to fail.
          Eli Collins made changes -
          Link This issue is related to HADOOP-4539 [ HADOOP-4539 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Hi Eli,
          Thanks alot for taking a look!.

          The main problem here is, ArrayLengths has been checked here. If i change that to direct LongWritable.write(..) or ShortWritable.write(..), that array length will be changed, this will lead to ncompatible change.

          Do you have any alternative suggestion for this?

          --Thanks

          Show
          Uma Maheswara Rao G added a comment - Hi Eli, Thanks alot for taking a look!. The main problem here is, ArrayLengths has been checked here. If i change that to direct LongWritable.write(..) or ShortWritable.write(..), that array length will be changed, this will lead to ncompatible change. Do you have any alternative suggestion for this? --Thanks
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Uma, we have to update LAYOUT_VERSION and support reading on files with older versions. See HDFS-1630 as an example.

          Show
          Tsz Wo Nicholas Sze added a comment - Hi Uma, we have to update LAYOUT_VERSION and support reading on files with older versions. See HDFS-1630 as an example.
          Hide
          Eli Collins added a comment -

          Hi Uma,

          I would keep the read* wrappers and have them do the right thing depending on the version. See the existing code (eg what Nicholas referred to) for examples of this.

          Thanks,
          Eli

          Show
          Eli Collins added a comment - Hi Uma, I would keep the read* wrappers and have them do the right thing depending on the version. See the existing code (eg what Nicholas referred to) for examples of this. Thanks, Eli
          Hide
          Uma Maheswara Rao G added a comment -

          Thanks to Eli and Nicholas for the suggestions,
          my bad.....Yes, i missed the version thing.
          I will update the patch accordingly.

          Show
          Uma Maheswara Rao G added a comment - Thanks to Eli and Nicholas for the suggestions, my bad.....Yes, i missed the version thing. I will update the patch accordingly.
          Uma Maheswara Rao G made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Uma Maheswara Rao G made changes -
          Attachment HDFS-362.2.patch [ 12490959 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Hi Eli,
          I have updated the patch, can you please take a look.

          Also, i have changed the layoutversion to -39.
          With this change i have verified the following scenarios manually.

          Scenario 1:
          After the version change, verified the fsimgae loading.
          Successfully able to writing the fields and loading back. This i checked with eclipse debug points.

          Scenario 2:
          a)Created the namespace with -38 version with mutiple FS operations.
          b)Applied the patch which contains the version updation to -39.
          c)started the NN with upgrade option.
          Observation: Successfully able to load and start.

          And also finalized and rollbacked.

          Since old version of fsImage is required for upgrade verification, i have done the tests manually. And existing tests used for regression.

          --thanks

          Show
          Uma Maheswara Rao G added a comment - Hi Eli, I have updated the patch, can you please take a look. Also, i have changed the layoutversion to -39. With this change i have verified the following scenarios manually. Scenario 1: After the version change, verified the fsimgae loading. Successfully able to writing the fields and loading back. This i checked with eclipse debug points. Scenario 2: a)Created the namespace with -38 version with mutiple FS operations. b)Applied the patch which contains the version updation to -39. c)started the NN with upgrade option. Observation: Successfully able to load and start. And also finalized and rollbacked. Since old version of fsImage is required for upgrade verification, i have done the tests manually. And existing tests used for regression. --thanks
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12490959/HDFS-362.2.patch
          against trunk revision 1159004.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
          org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
          org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat
          org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
          org.apache.hadoop.hdfs.TestHDFSServerPorts
          org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

          -1 contrib tests. The patch failed contrib unit tests.

          -1 system test framework. The patch failed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1126//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1126//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1126//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12490959/HDFS-362.2.patch against trunk revision 1159004. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy org.apache.hadoop.hdfs.server.namenode.TestCheckpoint org.apache.hadoop.hdfs.server.namenode.TestHDFSConcat org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings org.apache.hadoop.hdfs.TestHDFSServerPorts org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1126//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1126//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1126//console This message is automatically generated.
          Uma Maheswara Rao G made changes -
          Attachment HDFS-362.2b.patch [ 12491088 ]
          Uma Maheswara Rao G made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Todd Lipcon added a comment -

          Rather than comparing the logVersion variable against the numeric -39 version, check out LayoutVersion.supports(...) – makes the code easier to read, etc. Aside from that, I think it looks good, but will give one more pass before commit.

          Show
          Todd Lipcon added a comment - Rather than comparing the logVersion variable against the numeric -39 version, check out LayoutVersion.supports(...) – makes the code easier to read, etc. Aside from that, I think it looks good, but will give one more pass before commit.
          Uma Maheswara Rao G made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Uma Maheswara Rao G made changes -
          Attachment HDFS-362.2c.patch [ 12491520 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Hi Todd,

          Thanks a lot for taking a look on this patch!

          Rather than comparing the logVersion variable against the numeric -39 version, check out LayoutVersion.supports(...) – makes the code easier to read

          Nice suggestion. Addressed in this patch.

          Thanks
          Uma

          Show
          Uma Maheswara Rao G added a comment - Hi Todd, Thanks a lot for taking a look on this patch! Rather than comparing the logVersion variable against the numeric -39 version, check out LayoutVersion.supports(...) – makes the code easier to read Nice suggestion. Addressed in this patch. Thanks Uma
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Uma Maheswara Rao G made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Looks folder structure has been changed.
          Re-based the patch based on trunk!

          Hi Eli/Todd ,
          Can you just take look on this?

          Thanks
          Uma

          Show
          Uma Maheswara Rao G added a comment - Looks folder structure has been changed. Re-based the patch based on trunk! Hi Eli/Todd , Can you just take look on this? Thanks Uma
          Uma Maheswara Rao G made changes -
          Attachment HDFS-362.2d.patch [ 12491641 ]
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Uma Maheswara Rao G made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Uma Maheswara Rao G made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Updated the same patch again to trigger Hudson. HDFS-362.2d.patch

          Show
          Uma Maheswara Rao G added a comment - Updated the same patch again to trigger Hudson. HDFS-362 .2d.patch
          Uma Maheswara Rao G made changes -
          Attachment HDFS-362.2d.patch [ 12491819 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12491819/HDFS-362.2d.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          org.apache.hadoop.hdfs.server.datanode.TestReplicasMap
          org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
          org.apache.hadoop.hdfs.TestDfsOverAvroRpc
          org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1163//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1163//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1163//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12491819/HDFS-362.2d.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.server.datanode.TestReplicasMap org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1163//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1163//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1163//console This message is automatically generated.
          Hide
          Uma Maheswara Rao G added a comment -

          Test failures are not relevant, with out patch also they are failing.

          Show
          Uma Maheswara Rao G added a comment - Test failures are not relevant, with out patch also they are failing.
          Uma Maheswara Rao G made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Uma Maheswara Rao G made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Hi Todd,
          I have updated the patch with your comments.Do you have any comments with this new patch?

          Thanks,
          Uma

          Show
          Uma Maheswara Rao G added a comment - Hi Todd, I have updated the patch with your comments.Do you have any comments with this new patch? Thanks, Uma
          Uma Maheswara Rao G made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Hi Todd/Eli,
          Do you have any comments on this patch?

          Show
          Uma Maheswara Rao G added a comment - Hi Todd/Eli, Do you have any comments on this patch?
          Uma Maheswara Rao G made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Todd, any issue with this patch to go?

          Thanks
          Uma

          Show
          Uma Maheswara Rao G added a comment - Todd, any issue with this patch to go? Thanks Uma
          Uma Maheswara Rao G made changes -
          Affects Version/s 0.23.0 [ 12315571 ]
          Uma Maheswara Rao G made changes -
          Attachment HDFS-362.2e.patch [ 12493962 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12493962/HDFS-362.2e.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hdfs.TestDfsOverAvroRpc
          org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
          org.apache.hadoop.hdfs.server.datanode.TestReplicasMap

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1228//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1228//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1228//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493962/HDFS-362.2e.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap org.apache.hadoop.hdfs.server.datanode.TestReplicasMap +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1228//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1228//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1228//console This message is automatically generated.
          Hide
          Uma Maheswara Rao G added a comment -

          Test failures are not relavent to this patch change.

          Show
          Uma Maheswara Rao G added a comment - Test failures are not relavent to this patch change.
          Uma Maheswara Rao G made changes -
          Affects Version/s 0.24.0 [ 12317653 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          I will wait for a day before committing this, to see if there is any comment from the others.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good. I will wait for a day before committing this, to see if there is any comment from the others.
          Tsz Wo Nicholas Sze made changes -
          Hadoop Flags [Reviewed]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Uma!

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Uma!
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.24.0 [ 12317653 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #983 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/983/)
          HDFS-362. FSEditLog should not writes long and short as UTF8, and should not use ArrayWritable for writing non-array items. Contributed by Uma Maheswara Rao G

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171945
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #983 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/983/ ) HDFS-362 . FSEditLog should not writes long and short as UTF8, and should not use ArrayWritable for writing non-array items. Contributed by Uma Maheswara Rao G szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171945 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #906 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/906/)
          HDFS-362. FSEditLog should not writes long and short as UTF8, and should not use ArrayWritable for writing non-array items. Contributed by Uma Maheswara Rao G

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171945
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #906 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/906/ ) HDFS-362 . FSEditLog should not writes long and short as UTF8, and should not use ArrayWritable for writing non-array items. Contributed by Uma Maheswara Rao G szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171945 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #921 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/921/)
          HDFS-362. FSEditLog should not writes long and short as UTF8, and should not use ArrayWritable for writing non-array items. Contributed by Uma Maheswara Rao G

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171945
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #921 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/921/ ) HDFS-362 . FSEditLog should not writes long and short as UTF8, and should not use ArrayWritable for writing non-array items. Contributed by Uma Maheswara Rao G szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171945 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #803 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/803/)
          HDFS-362. FSEditLog should not writes long and short as UTF8, and should not use ArrayWritable for writing non-array items. Contributed by Uma Maheswara Rao G

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171945
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #803 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/803/ ) HDFS-362 . FSEditLog should not writes long and short as UTF8, and should not use ArrayWritable for writing non-array items. Contributed by Uma Maheswara Rao G szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171945 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #833 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/833/)
          HDFS-362. FSEditLog should not writes long and short as UTF8, and should not use ArrayWritable for writing non-array items. Contributed by Uma Maheswara Rao G

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171945
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #833 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/833/ ) HDFS-362 . FSEditLog should not writes long and short as UTF8, and should not use ArrayWritable for writing non-array items. Contributed by Uma Maheswara Rao G szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171945 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Hide
          Eli Collins added a comment -

          Spoke w Arun about targeting this for 23.1, good to have, and if so in an earlier 23.x release. Before merging I'm going to test:
          #1 Upgrade from 1.1 (branch-1) to a branch-23 build
          #2 Upgrade from 23.0 to a branch-23 build

          Show
          Eli Collins added a comment - Spoke w Arun about targeting this for 23.1, good to have, and if so in an earlier 23.x release. Before merging I'm going to test: #1 Upgrade from 1.1 (branch-1) to a branch-23 build #2 Upgrade from 23.0 to a branch-23 build
          Eli Collins made changes -
          Target Version/s 0.23.1 [ 12318885 ]
          Hide
          Eli Collins added a comment -

          Did the above testing (when populating the initial file system I saved the namespace, and populated it again so there's both a non-empty base image and non-empty edit log), merged to branch-23, and fixed up the changelog.

          Show
          Eli Collins added a comment - Did the above testing (when populating the initial file system I saved the namespace, and populated it again so there's both a non-empty base image and non-empty edit log), merged to branch-23, and fixed up the changelog.
          Eli Collins made changes -
          Fix Version/s 0.23.1 [ 12318885 ]
          Fix Version/s 0.24.0 [ 12317653 ]
          Target Version/s 0.23.1 [ 12318885 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #374 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/374/)
          HDFS-362. svn merge -c 1171945 from trunk

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232203
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #374 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/374/ ) HDFS-362 . svn merge -c 1171945 from trunk eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232203 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1623 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1623/)
          Update changelog for HDFS-362 to reflect the merge.

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232205
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1623 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1623/ ) Update changelog for HDFS-362 to reflect the merge. eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232205 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1550 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1550/)
          Update changelog for HDFS-362 to reflect the merge.

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232205
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1550 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1550/ ) Update changelog for HDFS-362 to reflect the merge. eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232205 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #384 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/384/)
          HDFS-362. svn merge -c 1171945 from trunk

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232203
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #384 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/384/ ) HDFS-362 . svn merge -c 1171945 from trunk eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232203 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #397 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/397/)
          HDFS-362. svn merge -c 1171945 from trunk

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232203
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #397 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/397/ ) HDFS-362 . svn merge -c 1171945 from trunk eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232203 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1568 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1568/)
          Update changelog for HDFS-362 to reflect the merge.

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232205
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1568 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1568/ ) Update changelog for HDFS-362 to reflect the merge. eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232205 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #928 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/928/)
          Update changelog for HDFS-362 to reflect the merge.

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232205
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #928 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/928/ ) Update changelog for HDFS-362 to reflect the merge. eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232205 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #141 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/141/)
          HDFS-362. svn merge -c 1171945 from trunk

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232203
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #141 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/141/ ) HDFS-362 . svn merge -c 1171945 from trunk eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232203 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Build #163 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/163/)
          HDFS-362. svn merge -c 1171945 from trunk

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232203
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #163 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/163/ ) HDFS-362 . svn merge -c 1171945 from trunk eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232203 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LayoutVersion.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageSerialization.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/EditsLoaderCurrent.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSEditLogLoader.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #961 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/961/)
          Update changelog for HDFS-362 to reflect the merge.

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232205
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #961 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/961/ ) Update changelog for HDFS-362 to reflect the merge. eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1232205 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Uma Maheswara Rao G
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development