Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3617

Port HDFS-96 to branch-1 (support blocks greater than 2GB)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.3
    • Fix Version/s: 1.1.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Please see HDFS-96.

      1. hadoop-findbugs-report.html
        350 kB
        Harsh J
      2. HDFS-3617.patch
        8 kB
        Harsh J

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          canceling patch since this is against branch-1.

          Show
          Eli Collins added a comment - canceling patch since this is against branch-1.
          Hide
          Eli Collins added a comment -

          lgtm, +1 pending test-patch results (please post in a comment)

          Show
          Eli Collins added a comment - lgtm, +1 pending test-patch results (please post in a comment)
          Hide
          Harsh J added a comment -
          
               [exec] -1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 2 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     -1 findbugs.  The patch appears to introduce 218 new Findbugs (version 2.0.1-rc3) warnings.
          

          Findbugs seem unrelated to me. Quick scan through report shows nothing from my lines at least.

          Show
          Harsh J added a comment - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 2 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 218 new Findbugs (version 2.0.1-rc3) warnings. Findbugs seem unrelated to me. Quick scan through report shows nothing from my lines at least.
          Hide
          Eli Collins added a comment -

          Thanks Harsh, mind updating HADOOP-7847 with your report? 218 is kind of alarming.

          Show
          Eli Collins added a comment - Thanks Harsh, mind updating HADOOP-7847 with your report? 218 is kind of alarming.
          Hide
          Eli Collins added a comment -

          Harsh,

          What version of findbugs are you using, and what are most of the 218 findbugs due to? I ran test-patch for HDFS-2827 and only got 7.

          Thanks,
          Eli

          Show
          Eli Collins added a comment - Harsh, What version of findbugs are you using, and what are most of the 218 findbugs due to? I ran test-patch for HDFS-2827 and only got 7. Thanks, Eli
          Hide
          Eli Collins added a comment -

          Forgot to mention, I'm using findbugs 1.3.9

          Show
          Eli Collins added a comment - Forgot to mention, I'm using findbugs 1.3.9
          Hide
          Harsh J added a comment -

          Findbugs (version 2.0.1-rc3) is what I used, so it may be that (I thought 1.3 was extinct long ago? I've always had 2.0.0 on my Mac at least, and for this build I ran on a remote Linux machine I had to download whatever was latest). I've attached the report.

          Show
          Harsh J added a comment - Findbugs (version 2.0.1-rc3) is what I used, so it may be that (I thought 1.3 was extinct long ago? I've always had 2.0.0 on my Mac at least, and for this build I ran on a remote Linux machine I had to download whatever was latest). I've attached the report.
          Hide
          Harsh J added a comment -

          Noting that I got the same value in my MAPREDUCE-4415 test-patch run too. Some extra warnings are due to new features of Findbugs we may not be interested in at this point (Internationalization, etc.? Sounds useful to have though, should we fix these via another JIRA?)

          Show
          Harsh J added a comment - Noting that I got the same value in my MAPREDUCE-4415 test-patch run too. Some extra warnings are due to new features of Findbugs we may not be interested in at this point (Internationalization, etc.? Sounds useful to have though, should we fix these via another JIRA?)
          Hide
          Eli Collins added a comment -

          I ran test-patch on your patch, got the same 7 findbugs as expected by HADOOP-7847. Looks like this is due to version 2.0.1). Jenkins uses 1.3.9 (see "new Findbugs (version 1.3.9) warnings." in the output) which is why I use the same for test-patch.

               [exec] 
               [exec] -1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 2 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     -1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
               [exec] 
          
          Show
          Eli Collins added a comment - I ran test-patch on your patch, got the same 7 findbugs as expected by HADOOP-7847 . Looks like this is due to version 2.0.1). Jenkins uses 1.3.9 (see "new Findbugs (version 1.3.9) warnings." in the output) which is why I use the same for test-patch. [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 2 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. [exec]
          Hide
          Eli Collins added a comment -

          I've committed this, thanks Harsh.

          Show
          Eli Collins added a comment - I've committed this, thanks Harsh.
          Hide
          Matt Foley added a comment -

          Merged to branch-1.1 per request from community.

          Show
          Matt Foley added a comment - Merged to branch-1.1 per request from community.
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop-1.1.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.

            People

            • Assignee:
              Harsh J
              Reporter:
              Matt Foley
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development