[HDFS-3579] libhdfs: fix exception handling

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.1-alpha
• Fix Version/s: 2.0.2-alpha
• Component/s: libhdfs
• Target Version/s: 2.0.2-alpha
• Hadoop Flags: Reviewed
• Assignee: Colin McCabe
• Reporter: Colin McCabe
• Created: 28/Jun/12 22:09
• Updated: 12/Jul/13 22:54
• Resolved: 06/Aug/12 21:07

Description

libhdfs does not consistently handle exceptions. Sometimes we don't free the memory associated with them (memory leak). Sometimes we invoke JNI functions that are not supposed to be invoked when an exception is active.

Running a libhdfs test program with -Xcheck:jni shows the latter problem clearly:

WARNING in native method: JNI call made with exception pending
WARNING in native method: JNI call made with exception pending
WARNING in native method: JNI call made with exception pending
WARNING in native method: JNI call made with exception pending
WARNING in native method: JNI call made with exception pending
Exception in thread "main" java.io.IOException: ...

Issue Links

• is duplicated by: HDFS-1154 libhdfs::hdfsExists should return different value in case of 1. error and 2. file does not exist
• is related to: HDFS-465 in branch-1, libhdfs makes jni lib calls after setting errno in some places
• is related to: HDFS-3710 libhdfs misuses O_RDONLY/WRONLY/RDWR
• is related to: HDFS-3742 libhdfs symbol visibility issues
• relates to: HDFS-4467 Segmentation fault in libhdfs while connecting to HDFS, in an application populating Hive Tables