Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3437

Remove name.node.address servlet attribute

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: None
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:

      Description

      Per HDFS-3434 we should be able to get rid of NAMENODE_ADDRESS_ATTRIBUTE_KEY since we always call DfsServlet#createNameNodeProxy within the NN.

      1. hdfs-3437.txt
        13 kB
        Eli Collins

        Activity

        Hide
        Eli Collins added a comment -

        Per HDFS-3639 this is necessary when used from the DN context (where "name.node" is not set).

        Show
        Eli Collins added a comment - Per HDFS-3639 this is necessary when used from the DN context (where "name.node" is not set).
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12527871/hdfs-3437.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2461//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2461//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527871/hdfs-3437.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2461//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2461//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Patch attached.

        Not sure about the last case in testGetUgi, eg if NAMENODE_ADDRESS should take precedence over DELEGATION_PARAMETER, as eg printGotoForm sets both, and previously might have ignored NAMENODE_ADDRESS in favor of NAMENODE_ADDRESS_ATTRIBUTE_KEY. Don't think this changes behavior, and the new test passes with the current code but worth double checking.

        Show
        Eli Collins added a comment - Patch attached. Not sure about the last case in testGetUgi, eg if NAMENODE_ADDRESS should take precedence over DELEGATION_PARAMETER, as eg printGotoForm sets both, and previously might have ignored NAMENODE_ADDRESS in favor of NAMENODE_ADDRESS_ATTRIBUTE_KEY. Don't think this changes behavior, and the new test passes with the current code but worth double checking.

          People

          • Assignee:
            Eli Collins
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development