Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha, 3.0.0
    • Fix Version/s: 2.0.2-alpha
    • Component/s: ha, test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-3026 made it so that an HA NN that does not fully complete an HA state transition will exit immediately. TestFailureToReadEdits has a test case which causes an incomplete state transition, thus causing a JVM exit in the test.

      1. HDFS-3413.patch
        2 kB
        Aaron T. Myers

        Activity

        Todd Lipcon created issue -
        Hide
        Todd Lipcon added a comment -

        On second thought this might be HDFS-3026.

        Show
        Todd Lipcon added a comment - On second thought this might be HDFS-3026 .
        Hide
        Aaron T. Myers added a comment -

        I agree this looks like HDFS-3026. I'll look into this.

        Show
        Aaron T. Myers added a comment - I agree this looks like HDFS-3026 . I'll look into this.
        Aaron T. Myers made changes -
        Field Original Value New Value
        Assignee Colin Patrick McCabe [ cmccabe ] Aaron T. Myers [ atm ]
        Hide
        Aaron T. Myers added a comment -

        Here's a patch which fixes the issue. The trouble was that the test JVM was exiting in this case post HDFS-3026. The fix is to stub out the Runtime.

        There's also another fix in this patch related to the fact that HDFS-3031 changed the expected exception stack in the case of an error from transitionToActive.

        Show
        Aaron T. Myers added a comment - Here's a patch which fixes the issue. The trouble was that the test JVM was exiting in this case post HDFS-3026 . The fix is to stub out the Runtime. There's also another fix in this patch related to the fact that HDFS-3031 changed the expected exception stack in the case of an error from transitionToActive.
        Aaron T. Myers made changes -
        Attachment HDFS-3413.patch [ 12527505 ]
        Aaron T. Myers made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12527505/HDFS-3413.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2444//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2444//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527505/HDFS-3413.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2444//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2444//console This message is automatically generated.
        Aaron T. Myers made changes -
        Description This test started timing out in build #1040: https://builds.apache.org/job/Hadoop-Hdfs-trunk/1040/
        My guess is is of the following patches is at fault:

        HADOOP-8361. Avoid out-of-memory problems when deserializing strings. Contributed by Colin Patrick McCabe (detail/ViewSVN)
        HDFS-3134. harden edit log loader against malformed or malicious input. Contributed by Colin Patrick McCabe (detail/ViewSVN)
        HDFS-3026 made it so that an HA NN that does not fully complete an HA state transition will exit immediately. TestFailureToReadEdits has a test case which causes an incomplete state transition, thus causing a JVM exit in the test.
        Hide
        Todd Lipcon added a comment -

        +1, sorry for breaking this test!

        Show
        Todd Lipcon added a comment - +1, sorry for breaking this test!
        Aaron T. Myers made changes -
        Target Version/s 2.0.0 [ 12320353 ] 2.0.1 [ 12321440 ]
        Hide
        Aaron T. Myers added a comment -

        Thanks a lot for the review, Todd. I've just committed this to trunk and branch-2.

        Show
        Aaron T. Myers added a comment - Thanks a lot for the review, Todd. I've just committed this to trunk and branch-2.
        Aaron T. Myers made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.0.1 [ 12321440 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2327 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2327/)
        HDFS-3413. TestFailureToReadEdits timing out. Contributed by Aaron T. Myers. (Revision 1339250)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339250
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2327 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2327/ ) HDFS-3413 . TestFailureToReadEdits timing out. Contributed by Aaron T. Myers. (Revision 1339250) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339250 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2253 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2253/)
        HDFS-3413. TestFailureToReadEdits timing out. Contributed by Aaron T. Myers. (Revision 1339250)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339250
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2253 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2253/ ) HDFS-3413 . TestFailureToReadEdits timing out. Contributed by Aaron T. Myers. (Revision 1339250) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339250 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2270 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2270/)
        HDFS-3413. TestFailureToReadEdits timing out. Contributed by Aaron T. Myers. (Revision 1339250)

        Result = ABORTED
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339250
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2270 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2270/ ) HDFS-3413 . TestFailureToReadEdits timing out. Contributed by Aaron T. Myers. (Revision 1339250) Result = ABORTED atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339250 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1046 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1046/)
        HDFS-3413. TestFailureToReadEdits timing out. Contributed by Aaron T. Myers. (Revision 1339250)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339250
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1046 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1046/ ) HDFS-3413 . TestFailureToReadEdits timing out. Contributed by Aaron T. Myers. (Revision 1339250) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339250 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1082 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1082/)
        HDFS-3413. TestFailureToReadEdits timing out. Contributed by Aaron T. Myers. (Revision 1339250)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339250
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1082 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1082/ ) HDFS-3413 . TestFailureToReadEdits timing out. Contributed by Aaron T. Myers. (Revision 1339250) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1339250 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureToReadEdits.java
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Arun C Murthy made changes -
        Fix Version/s 2.0.2-alpha [ 12322472 ]
        Fix Version/s 2.1.0-alpha [ 12321440 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        2d 18h 50m 1 Aaron T. Myers 15/May/12 21:07
        Patch Available Patch Available Resolved Resolved
        20h 20m 1 Aaron T. Myers 16/May/12 17:28
        Resolved Resolved Closed Closed
        7d 3h 53m 1 Arun C Murthy 23/May/12 21:21

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development