Details

      Description

      A few minor findbugs warnings snuck in. Nothing looks like a real bug, but we should fix before merging.

      1. hdfs-3412.txt
        14 kB
        Todd Lipcon

        Activity

        Hide
        Todd Lipcon added a comment -

        Committed to branch, thanks Aaron.

        Show
        Todd Lipcon added a comment - Committed to branch, thanks Aaron.
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me.
        Hide
        Todd Lipcon added a comment -
        • adds the generated protobufs to findbugs exclude
        • adds some more synchronization in ZKFC to avoid "inconsistent synchronization" findbugs
        • changes ZKFC to take its configuration and target in the constructor, rather than relying on post-constructor "setConf()". This way these fields can be final, and we don't have to synchronize to access them.

        I ran the ZKFC tests under jcarder to verify this didn't introduce new potential deadlocks.

        Show
        Todd Lipcon added a comment - adds the generated protobufs to findbugs exclude adds some more synchronization in ZKFC to avoid "inconsistent synchronization" findbugs changes ZKFC to take its configuration and target in the constructor, rather than relying on post-constructor "setConf()". This way these fields can be final, and we don't have to synchronize to access them. I ran the ZKFC tests under jcarder to verify this didn't introduce new potential deadlocks.

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development