Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3402

Fix hdfs scripts for secure datanodes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0, 1.1.0
    • Fix Version/s: 1.2.0, 0.22.1
    • Component/s: scripts, security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Starting secure datanode gives out the following error :

      Error thrown :
      09/04/2012 12:09:30 2524 jsvc error: Invalid option -server
      09/04/2012 12:09:30 2524 jsvc error: Cannot parse command line arguments

      1. hdfs-jsvc.patch
        0.6 kB
        Benoy Antony
      2. HDFS_3402_1-1.patch
        0.6 kB
        Benoy Antony
      3. HDFS_3402_1-1.patch
        0.6 kB
        Benoy Antony
      4. HDFS_3402_1-1.patch
        0.6 kB
        Benoy Antony

        Issue Links

          Activity

          Hide
          Benoy Antony added a comment -

          The problem occurs because -server option was in the wrong place.
          The patch fixes the problem by removing -server option if present and then adding it in the correct place.

          Show
          Benoy Antony added a comment - The problem occurs because -server option was in the wrong place. The patch fixes the problem by removing -server option if present and then adding it in the correct place.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12526234/hdfs-jsvc.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/976//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526234/hdfs-jsvc.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/976//console This message is automatically generated.
          Hide
          Konstantin Shvachko added a comment -

          +1
          I just committed this to branch 0.22.1. Thank you Benoy.

          Show
          Konstantin Shvachko added a comment - +1 I just committed this to branch 0.22.1. Thank you Benoy.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-22-branch #131 (See https://builds.apache.org/job/Hadoop-Hdfs-22-branch/131/)
          HDFS-3402. Fix hdfs script for secure datanodes. Contributed by Benoy Antony. (Revision 1346210)

          Result = FAILURE
          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346210
          Files :

          • /hadoop/common/branches/branch-0.22/hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.22/hdfs/bin/hdfs
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #131 (See https://builds.apache.org/job/Hadoop-Hdfs-22-branch/131/ ) HDFS-3402 . Fix hdfs script for secure datanodes. Contributed by Benoy Antony. (Revision 1346210) Result = FAILURE shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346210 Files : /hadoop/common/branches/branch-0.22/hdfs/CHANGES.txt /hadoop/common/branches/branch-0.22/hdfs/bin/hdfs
          Hide
          Benoy Antony added a comment -

          The error occurs on 1.1 also

          Show
          Benoy Antony added a comment - The error occurs on 1.1 also
          Hide
          Benoy Antony added a comment -

          attaching the patch for 1.1

          Show
          Benoy Antony added a comment - attaching the patch for 1.1
          Hide
          Suresh Srinivas added a comment -

          Benoy, quick question - what does the following change do:
          > HADOOP_OPTS=$

          {HADOOP_OPTS#-server}
          Show
          Suresh Srinivas added a comment - Benoy, quick question - what does the following change do: > HADOOP_OPTS=$ {HADOOP_OPTS#-server}
          Hide
          Suresh Srinivas added a comment - - edited

          Ok found the answer in bash parameter expansion. Question is, it only removes "-server" if HADOOP_OPTS starts with that. Else it leaves it alone. Is that intended?

          Show
          Suresh Srinivas added a comment - - edited Ok found the answer in bash parameter expansion. Question is, it only removes "-server" if HADOOP_OPTS starts with that. Else it leaves it alone. Is that intended?
          Hide
          Benoy Antony added a comment -

          I think, you are right. That was not intended. I'll fix the patch to remove "-server" properly and not just from start.

          Show
          Benoy Antony added a comment - I think, you are right. That was not intended. I'll fix the patch to remove "-server" properly and not just from start.
          Hide
          Suresh Srinivas added a comment -

          Benoy, you just need this right:
          > HADOOP_OPTS=$

          {HADOOP_OPTS/-server/}
          Show
          Suresh Srinivas added a comment - Benoy, you just need this right: > HADOOP_OPTS=$ {HADOOP_OPTS/-server/}
          Hide
          Benoy Antony added a comment -

          yes, the proposed change works. I have tested it.

          Attaching the new patch with the proposed change.

          Show
          Benoy Antony added a comment - yes, the proposed change works. I have tested it. Attaching the new patch with the proposed change.
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch. Committed it to branch-1. Thank you Benoy.

          Show
          Suresh Srinivas added a comment - +1 for the patch. Committed it to branch-1. Thank you Benoy.
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop 1.2.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.

            People

            • Assignee:
              Benoy Antony
              Reporter:
              Benoy Antony
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development