Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha, 3.0.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: namenode
    • Labels:
      None

      Description

      Only a few place in blockmanagement is using INode and all of them can be replaced by INodeFile.

      1. HDFS-3339.patch
        3 kB
        John George
      2. HDFS-3339.patch
        3 kB
        John George

        Activity

        John George created issue -
        John George made changes -
        Field Original Value New Value
        Component/s name-node [ 12312926 ]
        John George made changes -
        Attachment HDFS-3339.patch [ 12525205 ]
        John George made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 3.0.0, 2.0.0 [ 12320356, 12320353 ] 2.0.0, 3.0.0 [ 12320353, 12320356 ]
        John George made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Target Version/s 3.0.0, 2.0.0 [ 12320356, 12320353 ] 2.0.0, 3.0.0 [ 12320353, 12320356 ]
        John George made changes -
        Attachment HDFS-3339.patch [ 12525213 ]
        John George made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 3.0.0, 2.0.0 [ 12320356, 12320353 ] 2.0.0, 3.0.0 [ 12320353, 12320356 ]
        Hide
        John George added a comment -

        forgot to remove 'public' keyword

        Show
        John George added a comment - forgot to remove 'public' keyword
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch look good. Thanks for cleaning it up.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch look good. Thanks for cleaning it up.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525213/HDFS-3339.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 16 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.TestProcessCorruptBlocks

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2356//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2356//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2356//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525213/HDFS-3339.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 16 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestProcessCorruptBlocks +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2356//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2356//artifact/trunk/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2356//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        The failed test is not related.

        I have committed this. Thanks, John!

        Show
        Tsz Wo Nicholas Sze added a comment - The failed test is not related. I have committed this. Thanks, John!
        Tsz Wo Nicholas Sze made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Target Version/s 3.0.0, 2.0.0 [ 12320356, 12320353 ] 2.0.0, 3.0.0 [ 12320353, 12320356 ]
        Fix Version/s 2.0.0 [ 12320353 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2245 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2245/)
        HDFS-3339. Change INode to package private. Contributed by John George (Revision 1332876)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332876
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2245 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2245/ ) HDFS-3339 . Change INode to package private. Contributed by John George (Revision 1332876) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332876 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2171 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2171/)
        HDFS-3339. Change INode to package private. Contributed by John George (Revision 1332876)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332876
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2171 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2171/ ) HDFS-3339 . Change INode to package private. Contributed by John George (Revision 1332876) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332876 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2187 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2187/)
        HDFS-3339. Change INode to package private. Contributed by John George (Revision 1332876)

        Result = ABORTED
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332876
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2187 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2187/ ) HDFS-3339 . Change INode to package private. Contributed by John George (Revision 1332876) Result = ABORTED szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332876 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1032 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1032/)
        HDFS-3339. Change INode to package private. Contributed by John George (Revision 1332876)

        Result = FAILURE
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332876
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1032 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1032/ ) HDFS-3339 . Change INode to package private. Contributed by John George (Revision 1332876) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332876 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1067 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1067/)
        HDFS-3339. Change INode to package private. Contributed by John George (Revision 1332876)

        Result = FAILURE
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332876
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1067 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1067/ ) HDFS-3339 . Change INode to package private. Contributed by John George (Revision 1332876) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332876 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
        Vinod Kumar Vavilapalli made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        35m 4s 1 John George 01/May/12 20:35
        Open Open Patch Available Patch Available
        3m 2 John George 01/May/12 20:36
        Patch Available Patch Available Resolved Resolved
        2h 28m 1 Tsz Wo Nicholas Sze 01/May/12 23:05
        Resolved Resolved Closed Closed
        1244d 21h 53m 1 Vinod Kumar Vavilapalli 28/Sep/15 20:58

          People

          • Assignee:
            John George
            Reporter:
            John George
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development