Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3336

hdfs launcher script will be better off not special casing namenode command with regards to hadoop.security.logger

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.1
    • Fix Version/s: 2.0.0-alpha
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      All of the launcher scripts (except hdfs when called with a namenode argument) are defaulting to INFO,NullAppender setting for hadoop.security.logger. The only codepath where the default is INFO,RFAS is via hadoop-daemon.sh. This is exactly the right thing to do since only daemons are guaranteed to be executed under the proper user account (the one that has write/create access to the locations specified in $

      {hadoop.log.dir}

      /*).

      It would be nice for 'hdfs namenode' to follow the suit and not produce spurious warnings about not being able to write to log locations when executed from under regular accounts.

      1. HDFS-3336.patch.txt
        0.8 kB
        Roman Shaposhnik

        Activity

        Hide
        Roman Shaposhnik added a comment -

        Once again, please note that a code-patch through the hadoop-daemon.sh is guaranteed to preserve the existing behavior:
        https://github.com/apache/hadoop-common/blob/branch-2/hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh#L111

        Show
        Roman Shaposhnik added a comment - Once again, please note that a code-patch through the hadoop-daemon.sh is guaranteed to preserve the existing behavior: https://github.com/apache/hadoop-common/blob/branch-2/hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh#L111
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525182/HDFS-3336.patch.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 16 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2353//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2353//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525182/HDFS-3336.patch.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 16 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2353//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2353//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        +1 lgtm

        Show
        Alejandro Abdelnur added a comment - +1 lgtm
        Hide
        Alejandro Abdelnur added a comment -

        Thanks Roman. Committed to trunk a branch-2.

        Show
        Alejandro Abdelnur added a comment - Thanks Roman. Committed to trunk a branch-2.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2249 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2249/)
        HDFS-3336. hdfs launcher script will be better off not special casing namenode command with regards to hadoop.security.logger (rvs via tucu) (Revision 1333236)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333236
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2249 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2249/ ) HDFS-3336 . hdfs launcher script will be better off not special casing namenode command with regards to hadoop.security.logger (rvs via tucu) (Revision 1333236) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333236 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2175 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2175/)
        HDFS-3336. hdfs launcher script will be better off not special casing namenode command with regards to hadoop.security.logger (rvs via tucu) (Revision 1333236)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333236
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2175 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2175/ ) HDFS-3336 . hdfs launcher script will be better off not special casing namenode command with regards to hadoop.security.logger (rvs via tucu) (Revision 1333236) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333236 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2192 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2192/)
        HDFS-3336. hdfs launcher script will be better off not special casing namenode command with regards to hadoop.security.logger (rvs via tucu) (Revision 1333236)

        Result = ABORTED
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333236
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2192 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2192/ ) HDFS-3336 . hdfs launcher script will be better off not special casing namenode command with regards to hadoop.security.logger (rvs via tucu) (Revision 1333236) Result = ABORTED tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333236 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1033 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1033/)
        HDFS-3336. hdfs launcher script will be better off not special casing namenode command with regards to hadoop.security.logger (rvs via tucu) (Revision 1333236)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333236
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1033 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1033/ ) HDFS-3336 . hdfs launcher script will be better off not special casing namenode command with regards to hadoop.security.logger (rvs via tucu) (Revision 1333236) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333236 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1068 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1068/)
        HDFS-3336. hdfs launcher script will be better off not special casing namenode command with regards to hadoop.security.logger (rvs via tucu) (Revision 1333236)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333236
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1068 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1068/ ) HDFS-3336 . hdfs launcher script will be better off not special casing namenode command with regards to hadoop.security.logger (rvs via tucu) (Revision 1333236) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1333236 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs

          People

          • Assignee:
            Roman Shaposhnik
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development