Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3326

Append enabled log message uses the wrong variable

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.0-alpha
    • Component/s: namenode
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      "dfs.support.append" is set to true
      started NN in non-HA mode

      At the NN side log the append enable is set to false.

      This is because in code append enabled is set to HA enabled value.Since Started NN in non-HA mode the value for append is false
      Code:
      =====

      this.supportAppends = conf.getBoolean(DFS_SUPPORT_APPEND_KEY, DFS_SUPPORT_APPEND_DEFAULT);
            LOG.info("Append Enabled: " + haEnabled);

      NN logs
      ========

      2012-04-25 21:11:09,693 INFO org.apache.hadoop.hdfs.server.namenode.FSNamesystem: HA Enabled: false
      2012-04-25 21:11:09,702 INFO org.apache.hadoop.hdfs.server.namenode.FSNamesystem: Append Enabled: false
      1. hdfs-3326.txt
        1 kB
        Matthew Jacobs

        Activity

        Hide
        Matthew Jacobs added a comment -

        Patch attached

        Show
        Matthew Jacobs added a comment - Patch attached
        Hide
        Eli Collins added a comment -

        +1 looks good. I'll commit this w/o jenkins since it's a trivial change.

        Show
        Eli Collins added a comment - +1 looks good. I'll commit this w/o jenkins since it's a trivial change.
        Hide
        Eli Collins added a comment -

        I've committed this and merged to branch-2, thanks Matt!

        Show
        Eli Collins added a comment - I've committed this and merged to branch-2, thanks Matt!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2148 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2148/)
        HDFS-3326. Append enabled log message uses the wrong variable. Contributed by Matthew Jacobs (Revision 1331626)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331626
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2148 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2148/ ) HDFS-3326 . Append enabled log message uses the wrong variable. Contributed by Matthew Jacobs (Revision 1331626) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331626 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2222 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2222/)
        HDFS-3326. Append enabled log message uses the wrong variable. Contributed by Matthew Jacobs (Revision 1331626)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331626
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2222 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2222/ ) HDFS-3326 . Append enabled log message uses the wrong variable. Contributed by Matthew Jacobs (Revision 1331626) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331626 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2165 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2165/)
        HDFS-3326. Append enabled log message uses the wrong variable. Contributed by Matthew Jacobs (Revision 1331626)

        Result = ABORTED
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331626
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2165 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2165/ ) HDFS-3326 . Append enabled log message uses the wrong variable. Contributed by Matthew Jacobs (Revision 1331626) Result = ABORTED eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331626 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1028 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1028/)
        HDFS-3326. Append enabled log message uses the wrong variable. Contributed by Matthew Jacobs (Revision 1331626)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331626
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1028 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1028/ ) HDFS-3326 . Append enabled log message uses the wrong variable. Contributed by Matthew Jacobs (Revision 1331626) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331626 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1063 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1063/)
        HDFS-3326. Append enabled log message uses the wrong variable. Contributed by Matthew Jacobs (Revision 1331626)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331626
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1063 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1063/ ) HDFS-3326 . Append enabled log message uses the wrong variable. Contributed by Matthew Jacobs (Revision 1331626) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331626 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

          People

          • Assignee:
            Matthew Jacobs
            Reporter:
            J.Andreina
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development