Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3306

fuse_dfs: don't lock release operations

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.2-alpha
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There's no need to lock release operations in FUSE, because release can only be called once on a fuse_file_info structure.

      1. HDFS-3306.001.patch
        3 kB
        Colin Patrick McCabe

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1135/)
        HDFS-3306. fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1135/ ) HDFS-3306 . fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1102 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1102/)
        HDFS-3306. fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1102 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1102/ ) HDFS-3306 . fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2479 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2479/)
        HDFS-3306. fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021)

        Result = FAILURE
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2479 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2479/ ) HDFS-3306 . fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2526 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2526/)
        HDFS-3306. fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2526 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2526/ ) HDFS-3306 . fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2460 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2460/)
        HDFS-3306. fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021)

        Result = SUCCESS
        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2460 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2460/ ) HDFS-3306 . fuse_dfs: don't lock release operations. Contributed by Colin Patrick McCabe (Revision 1361021) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1361021 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_release.c
        Hide
        Eli Collins added a comment -

        Per offline conversation Colin tested this multithreaded.

        +1 I've committed this and merged to branch-2.

        Show
        Eli Collins added a comment - Per offline conversation Colin tested this multithreaded. +1 I've committed this and merged to branch-2.
        Hide
        Eli Collins added a comment -

        Check the parallel case, eg multiple threads cat'ing the same set of files in parallel (will result in open/release on the same files)?

        Show
        Eli Collins added a comment - Check the parallel case, eg multiple threads cat'ing the same set of files in parallel (will result in open/release on the same files)?
        Hide
        Colin Patrick McCabe added a comment -

        To test this, I mounted a fuse_dfs filesystem, created a bunch of files, and then deleted them.

        Show
        Colin Patrick McCabe added a comment - To test this, I mounted a fuse_dfs filesystem, created a bunch of files, and then deleted them.
        Hide
        Eli Collins added a comment -

        Agree with your logic, and the change looks good. Testing?

        Show
        Eli Collins added a comment - Agree with your logic, and the change looks good. Testing?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12523439/HDFS-3306.001.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2307//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2307//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523439/HDFS-3306.001.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2307//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2307//console This message is automatically generated.

          People

          • Assignee:
            Colin Patrick McCabe
            Reporter:
            Colin Patrick McCabe
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development