Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3303

RemoteEditLogManifest doesn't need to implements Writable

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Since we are using protocol buffers, RemoteEditLogManifest doesn't need to implements Writable.

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525655/HDFS-3303.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2376//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2376//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525655/HDFS-3303.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2376//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2376//console This message is automatically generated.
        Hide
        Brandon Li added a comment -

        The javadoc warnings are not related with this patch.
        The test is covered by existing tests in TestCheckpoint.java.

        Show
        Brandon Li added a comment - The javadoc warnings are not related with this patch. The test is covered by existing tests in TestCheckpoint.java.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Brandon!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Brandon!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2264 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2264/)
        HDFS-3303. Remove Writable implementation from RemoteEditLogManifest. Contributed by Brandon Li (Revision 1334156)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334156
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2264 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2264/ ) HDFS-3303 . Remove Writable implementation from RemoteEditLogManifest. Contributed by Brandon Li (Revision 1334156) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334156 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2190 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2190/)
        HDFS-3303. Remove Writable implementation from RemoteEditLogManifest. Contributed by Brandon Li (Revision 1334156)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334156
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2190 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2190/ ) HDFS-3303 . Remove Writable implementation from RemoteEditLogManifest. Contributed by Brandon Li (Revision 1334156) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334156 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2208 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2208/)
        HDFS-3303. Remove Writable implementation from RemoteEditLogManifest. Contributed by Brandon Li (Revision 1334156)

        Result = ABORTED
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334156
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2208 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2208/ ) HDFS-3303 . Remove Writable implementation from RemoteEditLogManifest. Contributed by Brandon Li (Revision 1334156) Result = ABORTED szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334156 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1035 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1035/)
        HDFS-3303. Remove Writable implementation from RemoteEditLogManifest. Contributed by Brandon Li (Revision 1334156)

        Result = FAILURE
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334156
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1035 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1035/ ) HDFS-3303 . Remove Writable implementation from RemoteEditLogManifest. Contributed by Brandon Li (Revision 1334156) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334156 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1070 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1070/)
        HDFS-3303. Remove Writable implementation from RemoteEditLogManifest. Contributed by Brandon Li (Revision 1334156)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334156
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1070 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1070/ ) HDFS-3303 . Remove Writable implementation from RemoteEditLogManifest. Contributed by Brandon Li (Revision 1334156) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1334156 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/RemoteEditLogManifest.java

          People

          • Assignee:
            Brandon Li
            Reporter:
            Brandon Li
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development