Details

    • Hadoop Flags:
      Reviewed
    1. hdfs-3274-1.patch
      14 kB
      Hari Mankude
    2. hdfs-3274.patch
      14 kB
      Hari Mankude

      Activity

      Transition Time In Source Status Execution Times Last Executer Last Execution Date
      Open Open Resolved Resolved
      3h 1 Tsz Wo Nicholas Sze 14/Apr/12 00:29
      Tsz Wo Nicholas Sze made changes -
      Status Open [ 1 ] Resolved [ 5 ]
      Hadoop Flags Reviewed [ 10343 ]
      Fix Version/s Shared journals (HDFS-3092) [ 12320553 ]
      Resolution Fixed [ 1 ]
      Hide
      Tsz Wo Nicholas Sze added a comment -

      I have committed this. Thanks, Hari!

      Show
      Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Hari!
      Hari Mankude made changes -
      Attachment hdfs-3274-1.patch [ 12522635 ]
      Hide
      Hari Mankude added a comment -

      @Brandon
      done, removed the invalid comment
      @Nicholas
      done. created javadoc.

      Will update the patch shortly.

      Show
      Hari Mankude added a comment - @Brandon done, removed the invalid comment @Nicholas done. created javadoc. Will update the patch shortly.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      +1 patch looks good.

      Please change initializeJournalStorage(..) private and the comment above to javadoc.

      Show
      Tsz Wo Nicholas Sze added a comment - +1 patch looks good. Please change initializeJournalStorage(..) private and the comment above to javadoc.
      Hide
      Brandon Li added a comment -

      The patch looks good to me. Please remove the following comments in method formatStorage() sine they are irrelevant now: "For now, use the namespacedirs and edits dir to save the journal info..."

      Show
      Brandon Li added a comment - The patch looks good to me. Please remove the following comments in method formatStorage() sine they are irrelevant now: "For now, use the namespacedirs and edits dir to save the journal info..."
      Hari Mankude made changes -
      Attachment hdfs-3274.patch [ 12522617 ]
      Hari Mankude made changes -
      Attachment hdfs-3274.patch [ 12522616 ]
      Hari Mankude made changes -
      Attachment hdfs-3274.patch [ 12522616 ]
      Hari Mankude made changes -
      Field Original Value New Value
      Component/s ha [ 12316609 ]
      Component/s name-node [ 12312926 ]
      Hari Mankude created issue -

        People

        • Assignee:
          Hari Mankude
          Reporter:
          Hari Mankude
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development