Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3247

Improve bootstrapStandby behavior when original NN is not active

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ha
    • Labels:
      None

      Description

      Currently, if you run bootstrapStandby while the first NN is in standby mode, it will spit out an ugly StandbyException with a trace. Instead, it should print an explanation that you should transition the first NN to active before bootstrapping.

      1. hdfs-3247.txt
        10 kB
        Todd Lipcon

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1046 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1046/)
        HDFS-3247. Improve bootstrapStandby behavior when original NN is not active. Contributed by Todd Lipcon. (Revision 1324558)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324558
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1046 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1046/ ) HDFS-3247 . Improve bootstrapStandby behavior when original NN is not active. Contributed by Todd Lipcon. (Revision 1324558) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324558 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1011 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1011/)
        HDFS-3247. Improve bootstrapStandby behavior when original NN is not active. Contributed by Todd Lipcon. (Revision 1324558)

        Result = FAILURE
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324558
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1011 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1011/ ) HDFS-3247 . Improve bootstrapStandby behavior when original NN is not active. Contributed by Todd Lipcon. (Revision 1324558) Result = FAILURE todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324558 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2063 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2063/)
        HDFS-3247. Improve bootstrapStandby behavior when original NN is not active. Contributed by Todd Lipcon. (Revision 1324558)

        Result = ABORTED
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324558
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2063 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2063/ ) HDFS-3247 . Improve bootstrapStandby behavior when original NN is not active. Contributed by Todd Lipcon. (Revision 1324558) Result = ABORTED todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324558 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2050 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2050/)
        HDFS-3247. Improve bootstrapStandby behavior when original NN is not active. Contributed by Todd Lipcon. (Revision 1324558)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324558
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2050 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2050/ ) HDFS-3247 . Improve bootstrapStandby behavior when original NN is not active. Contributed by Todd Lipcon. (Revision 1324558) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324558 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        Hide
        Todd Lipcon added a comment -

        Committed to branch-2 and trunk, thanks for review.

        Show
        Todd Lipcon added a comment - Committed to branch-2 and trunk, thanks for review.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2124 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2124/)
        HDFS-3247. Improve bootstrapStandby behavior when original NN is not active. Contributed by Todd Lipcon. (Revision 1324558)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324558
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2124 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2124/ ) HDFS-3247 . Improve bootstrapStandby behavior when original NN is not active. Contributed by Todd Lipcon. (Revision 1324558) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1324558 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestBootstrapStandby.java
        Hide
        Aaron T. Myers added a comment -

        Patch looks good to me. +1

        Show
        Aaron T. Myers added a comment - Patch looks good to me. +1
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522187/hdfs-3247.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2247//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2247//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522187/hdfs-3247.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2247//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2247//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Attached patch implements Aaron's idea above.

        Show
        Todd Lipcon added a comment - Attached patch implements Aaron's idea above.
        Hide
        Aaron T. Myers added a comment -

        How about do #1, prompt the user if they'd like to do #2, and then do it if they say 'Y' ?

        Show
        Aaron T. Myers added a comment - How about do #1, prompt the user if they'd like to do #2, and then do it if they say 'Y' ?
        Hide
        Todd Lipcon added a comment -

        I think we could do one of the following:
        1) Improve the error message to note that the admin should make sure the other NN is active before proceeding
        2) Have it automatically transition it to active if this is the case.

        What do you think? I think 1 makes more sense, since the admin has to make an explicit decision.

        Show
        Todd Lipcon added a comment - I think we could do one of the following: 1) Improve the error message to note that the admin should make sure the other NN is active before proceeding 2) Have it automatically transition it to active if this is the case. What do you think? I think 1 makes more sense, since the admin has to make an explicit decision.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Do you mean improving the error message instead of the behavior?

        Show
        Tsz Wo Nicholas Sze added a comment - Do you mean improving the error message instead of the behavior?

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development