Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3235

MiniDFSClusterManager doesn't correctly support -format option

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 2.0.2-alpha
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      MiniDFSClusterManager.java correctly honours -format for setting StartupOption.FORMAT, but does not set .format(true) on the MiniDFSClusterBuilder. This means the datanodes' data dirs will be formatted every time.

      1. HDFS-3235.0.patch
        2 kB
        Henry Robinson

        Activity

        Hide
        Todd Lipcon added a comment -

        Committed to branch-2 as well.

        Show
        Todd Lipcon added a comment - Committed to branch-2 as well.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1045 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1045/)
        HDFS-3235. MiniDFSClusterManager doesn't correctly support -format option. Contributed by Henry Robinson. (Revision 1311556)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311556
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/test/MiniDFSClusterManager.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1045 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1045/ ) HDFS-3235 . MiniDFSClusterManager doesn't correctly support -format option. Contributed by Henry Robinson. (Revision 1311556) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311556 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/test/MiniDFSClusterManager.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1010 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1010/)
        HDFS-3235. MiniDFSClusterManager doesn't correctly support -format option. Contributed by Henry Robinson. (Revision 1311556)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311556
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/test/MiniDFSClusterManager.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1010 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1010/ ) HDFS-3235 . MiniDFSClusterManager doesn't correctly support -format option. Contributed by Henry Robinson. (Revision 1311556) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311556 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/test/MiniDFSClusterManager.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2048 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2048/)
        HDFS-3235. MiniDFSClusterManager doesn't correctly support -format option. Contributed by Henry Robinson. (Revision 1311556)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311556
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/test/MiniDFSClusterManager.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2048 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2048/ ) HDFS-3235 . MiniDFSClusterManager doesn't correctly support -format option. Contributed by Henry Robinson. (Revision 1311556) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311556 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/test/MiniDFSClusterManager.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2035 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2035/)
        HDFS-3235. MiniDFSClusterManager doesn't correctly support -format option. Contributed by Henry Robinson. (Revision 1311556)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311556
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/test/MiniDFSClusterManager.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2035 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2035/ ) HDFS-3235 . MiniDFSClusterManager doesn't correctly support -format option. Contributed by Henry Robinson. (Revision 1311556) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311556 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/test/MiniDFSClusterManager.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2109 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2109/)
        HDFS-3235. MiniDFSClusterManager doesn't correctly support -format option. Contributed by Henry Robinson. (Revision 1311556)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311556
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/test/MiniDFSClusterManager.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2109 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2109/ ) HDFS-3235 . MiniDFSClusterManager doesn't correctly support -format option. Contributed by Henry Robinson. (Revision 1311556) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1311556 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/test/MiniDFSClusterManager.java
        Hide
        Aaron T. Myers added a comment -

        I've just committed this fix to trunk. Thanks a lot for the contribution, Hank.

        Show
        Aaron T. Myers added a comment - I've just committed this fix to trunk. Thanks a lot for the contribution, Hank.
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me. I'm going to commit this momentarily.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me. I'm going to commit this momentarily.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522039/HDFS-3235.0.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2238//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2238//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522039/HDFS-3235.0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2238//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2238//console This message is automatically generated.
        Hide
        Henry Robinson added a comment -

        sure thing. I'll probably only need another thirty or so of these to get it right.

        Show
        Henry Robinson added a comment - sure thing. I'll probably only need another thirty or so of these to get it right.
        Hide
        Aaron T. Myers added a comment -

        Hey Henry, in the future, please set the "affects version" and "target versions" fields when filing a JIRA, and only set the "fix version" field when the JIRA is resolved.

        Show
        Aaron T. Myers added a comment - Hey Henry, in the future, please set the "affects version" and "target versions" fields when filing a JIRA, and only set the "fix version" field when the JIRA is resolved.
        Hide
        Henry Robinson added a comment -

        Patch against trunk

        Show
        Henry Robinson added a comment - Patch against trunk

          People

          • Assignee:
            Henry Robinson
            Reporter:
            Henry Robinson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development