JournalService.fence(..), should the setupStorage(..) call be after verifyFence(..) and verify(..)?
One of the advantages of doing this earlier is that verify() will check for results automatically.
JournalService.conf is only used in setupStorage(..). Instead of adding it as a field, it is better to replace it with NNStorage since the conf values are fixed. We don't have to create the objects in setupStorage(..).
Let us leave this as is for now. This will require rework once edits dir format for journals is decided.
Need to add Assert.fail() after fence(..) in the new tests. Otherwise, the test will pass even if fence(..) does not throw exceptions. I think it is better to print out the exception in the catch-blocks instead of leaving them empty.
Done for both, assert.fail() and printfs.
In addition, we need to think about how to synchronize the methods in JournalService. Do you want to do it here or in a separated issue?
Again, I would like to defer this for later. I will file a jira for this.