Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. h3168_20120330.patch
      28 kB
      Tsz Wo Nicholas Sze
    2. h3168_20120402.patch
      25 kB
      Tsz Wo Nicholas Sze
    3. h3168_20120403.patch
      25 kB
      Tsz Wo Nicholas Sze

      Activity

      Hide
      Todd Lipcon added a comment -

      Let's ask the dev list. I'll start a thread.

      Show
      Todd Lipcon added a comment - Let's ask the dev list. I'll start a thread.
      Hide
      Aaron T. Myers added a comment -

      Aaron, it is nothing to do with it. Any contributor could review code. It was a merging problem.

      I definitely didn't mean to imply that this particular compilation issue would have been caught by a different reviewer. I'm confident I would not have caught this particular issue myself.

      I think this is not true. After a committer provided a patch and a non-committer reviewed it, the same committer could commit the patch.

      I think the bylaws are a little ambiguous on the subject. Per the bylaws:

      Code Change
      A change made to a codebase of the project and committed by a committer. This includes source code, documentation, website content, etc. Lazy consensus of active committers, but with a minimum of one +1. The code can be committed after the first +1, unless the code change represents a merge from a branch, in which case three +1s are required.

      This would seem to imply that a review by a non-committer contributor is non-binding. It does not, however, clear up the issue of whether or not a committer can provide a +1 of their own patch.

      FWIW, my understanding is the same as Todd's on this subject.

      Show
      Aaron T. Myers added a comment - Aaron, it is nothing to do with it. Any contributor could review code. It was a merging problem. I definitely didn't mean to imply that this particular compilation issue would have been caught by a different reviewer. I'm confident I would not have caught this particular issue myself. I think this is not true. After a committer provided a patch and a non-committer reviewed it, the same committer could commit the patch. I think the bylaws are a little ambiguous on the subject. Per the bylaws: Code Change A change made to a codebase of the project and committed by a committer. This includes source code, documentation, website content, etc. Lazy consensus of active committers, but with a minimum of one +1. The code can be committed after the first +1, unless the code change represents a merge from a branch, in which case three +1s are required. This would seem to imply that a review by a non-committer contributor is non-binding. It does not, however, clear up the issue of whether or not a committer can provide a +1 of their own patch. FWIW, my understanding is the same as Todd's on this subject.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      > By my understanding of our policies, the committer who provides the +1 has to be someone separate than the patch author. ...

      I think this is not true. After a committer provided a patch and a non-committer reviewed it, the same committer could commit the patch.

      Show
      Tsz Wo Nicholas Sze added a comment - > By my understanding of our policies, the committer who provides the +1 has to be someone separate than the patch author. ... I think this is not true. After a committer provided a patch and a non-committer reviewed it, the same committer could commit the patch.
      Hide
      Todd Lipcon added a comment -

      By my understanding of our policies, the committer who provides the +1 has to be someone separate than the patch author. On branches I'm fine being lax here, since we need three +1s to merge a branch, but on trunk, I think it merits a discussion if there is disagreement on what our policies are.

      Show
      Todd Lipcon added a comment - By my understanding of our policies, the committer who provides the +1 has to be someone separate than the patch author. On branches I'm fine being lax here, since we need three +1s to merge a branch, but on trunk, I think it merits a discussion if there is disagreement on what our policies are.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      Could the committer be the same as the contributor?

      Show
      Tsz Wo Nicholas Sze added a comment - Could the committer be the same as the contributor?
      Hide
      Todd Lipcon added a comment -

      Aaron, it is nothing to do with it. Any contributor could review code. It was a merging problem.

      Is that the case? I have no opinion on this particular patch and whether a different reviewer might have seen the issue. But I thought you had to get a committer +1 to commit things...

      Show
      Todd Lipcon added a comment - Aaron, it is nothing to do with it. Any contributor could review code. It was a merging problem. Is that the case? I have no opinion on this particular patch and whether a different reviewer might have seen the issue. But I thought you had to get a committer +1 to commit things...
      Hide
      Tsz Wo Nicholas Sze added a comment -

      > Also, not a big deal, but in the future please get a +1 from a committer before committing a patch.

      Aaron, it is nothing to do with it. Any contributor could review code. It was a merging problem.

      Show
      Tsz Wo Nicholas Sze added a comment - > Also, not a big deal, but in the future please get a +1 from a committer before committing a patch. Aaron, it is nothing to do with it. Any contributor could review code. It was a merging problem.
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #1040 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1040/)
      HDFS-3168. Remove unnecessary "throw IOException" and change fields to final in FSNamesystem and BlockManager. (Revision 1309218)

      Result = FAILURE
      szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309218
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerTestUtil.java
      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1040 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1040/ ) HDFS-3168 . Remove unnecessary "throw IOException" and change fields to final in FSNamesystem and BlockManager. (Revision 1309218) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309218 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerTestUtil.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk #1005 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1005/)
      HDFS-3168. Remove unnecessary "throw IOException" and change fields to final in FSNamesystem and BlockManager. (Revision 1309218)

      Result = FAILURE
      szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309218
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerTestUtil.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1005 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1005/ ) HDFS-3168 . Remove unnecessary "throw IOException" and change fields to final in FSNamesystem and BlockManager. (Revision 1309218) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309218 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerTestUtil.java
      Hide
      Aaron T. Myers added a comment -

      Looks like this patch may have broken compilation of branch-2, since branch-2 doesn't include HDFS-2564 which removed "throws IOException" from FSNamesystem#reassignLeaseInternal, and is therefore a pre-requisite for this patch.

      Also, not a big deal, but in the future please get a +1 from a committer before committing a patch.

      Show
      Aaron T. Myers added a comment - Looks like this patch may have broken compilation of branch-2, since branch-2 doesn't include HDFS-2564 which removed "throws IOException" from FSNamesystem#reassignLeaseInternal, and is therefore a pre-requisite for this patch. Also, not a big deal, but in the future please get a +1 from a committer before committing a patch.
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk-Commit #1999 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1999/)
      HDFS-3168. Remove unnecessary "throw IOException" and change fields to final in FSNamesystem and BlockManager. (Revision 1309218)

      Result = SUCCESS
      szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309218
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerTestUtil.java
      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1999 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1999/ ) HDFS-3168 . Remove unnecessary "throw IOException" and change fields to final in FSNamesystem and BlockManager. (Revision 1309218) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309218 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerTestUtil.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Common-trunk-Commit #1986 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1986/)
      HDFS-3168. Remove unnecessary "throw IOException" and change fields to final in FSNamesystem and BlockManager. (Revision 1309218)

      Result = SUCCESS
      szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309218
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerTestUtil.java
      Show
      Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1986 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1986/ ) HDFS-3168 . Remove unnecessary "throw IOException" and change fields to final in FSNamesystem and BlockManager. (Revision 1309218) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309218 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerTestUtil.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk-Commit #2061 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2061/)
      HDFS-3168. Remove unnecessary "throw IOException" and change fields to final in FSNamesystem and BlockManager. (Revision 1309218)

      Result = SUCCESS
      szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309218
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerTestUtil.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2061 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2061/ ) HDFS-3168 . Remove unnecessary "throw IOException" and change fields to final in FSNamesystem and BlockManager. (Revision 1309218) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309218 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManagerTestUtil.java
      Hide
      Tsz Wo Nicholas Sze added a comment -

      I have committed this.

      Show
      Tsz Wo Nicholas Sze added a comment - I have committed this.
      Hide
      Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12521240/h3168_20120403.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in .

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2175//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2175//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521240/h3168_20120403.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2175//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2175//console This message is automatically generated.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      Brandon, thanks for the review.

      h3168_20120403.patch: updated with trunk.

      Show
      Tsz Wo Nicholas Sze added a comment - Brandon, thanks for the review. h3168_20120403.patch: updated with trunk.
      Hide
      Brandon Li added a comment -

      +1

      The patch looks good to me. Please rebase your patch with the head of trunk. I noticed some minor conflict needed to be manually fixed when applying this patch because of other submissions today.

      Show
      Brandon Li added a comment - +1 The patch looks good to me. Please rebase your patch with the head of trunk. I noticed some minor conflict needed to be manually fixed when applying this patch because of other submissions today.
      Hide
      Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12521030/h3168_20120402.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in .

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2158//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2158//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521030/h3168_20120402.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2158//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2158//console This message is automatically generated.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      h3168_20120402.patch: updated with trunk (HDFS-3172)

      Show
      Tsz Wo Nicholas Sze added a comment - h3168_20120402.patch: updated with trunk ( HDFS-3172 )
      Hide
      Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12520701/h3168_20120330.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in .

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2137//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2137//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520701/h3168_20120330.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2137//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2137//console This message is automatically generated.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12520701/h3168_20120330.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hdfs.TestFileAppend4

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2134//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2134//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520701/h3168_20120330.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestFileAppend4 +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2134//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2134//console This message is automatically generated.
      Hide
      Tsz Wo Nicholas Sze added a comment -

      h3168_20120330.patch:

      • remove unnecessary "throw IOException";
      • change fields to final;
      • remove DFSConfigKeys.DFS_NAMENODE_UPGRADE_PERMISSION_KEY.
      Show
      Tsz Wo Nicholas Sze added a comment - h3168_20120330.patch: remove unnecessary "throw IOException"; change fields to final; remove DFSConfigKeys.DFS_NAMENODE_UPGRADE_PERMISSION_KEY.

        People

        • Assignee:
          Tsz Wo Nicholas Sze
          Reporter:
          Tsz Wo Nicholas Sze
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development