Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3163

TestHDFSCLI.testAll fails if the user name is not all lowercase

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 1.2.0, 2.1.0-beta
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In the test resource file testHDFSConf.xml, the test comparators expect user name to be all lowercase.
      If the user issuing the test has an uppercase in the username (e.g., Brandon instead of brandon), many RegexpComarator tests will fail. The following is one example:

       
              <comparator>
                <type>RegexpComparator</type>
                <expected-output>^-rw-r--r--( )*1( )*[a-z]*( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/file1</expected-output>
              </comparator>
      
      1. HDFS-3163.patch
        371 kB
        Brandon Li
      2. HDFS-3163.branch-1.patch
        57 kB
        Brandon Li
      3. HDFS-3163.branch-1-win.patch
        55 kB
        Brandon Li

        Activity

        Hide
        Aaron T. Myers added a comment -

        Good find, Brandon. Pretty funny, too.

        If you post a patch, I'll review it promptly.

        Show
        Aaron T. Myers added a comment - Good find, Brandon. Pretty funny, too. If you post a patch, I'll review it promptly.
        Hide
        Brandon Li added a comment -

        Changed testHDFSConf.xml to support user name with uppercase and number.

        Show
        Brandon Li added a comment - Changed testHDFSConf.xml to support user name with uppercase and number.
        Hide
        Brandon Li added a comment -

        I tested the patch by running TestHDFSCLI. It passed with different users like admin, Brandon and test1.

        Show
        Brandon Li added a comment - I tested the patch by running TestHDFSCLI. It passed with different users like admin, Brandon and test1.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12526447/HDFS-3163.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.TestHFlush

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2416//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2416//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526447/HDFS-3163.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestHFlush +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2416//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2416//console This message is automatically generated.
        Hide
        Brandon Li added a comment -

        The test failure is not related with my change. Did test TestHFlush with trunk head on my desktop and it passed.

        Show
        Brandon Li added a comment - The test failure is not related with my change. Did test TestHFlush with trunk head on my desktop and it passed.
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me. I'll commit this momentarily.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me. I'll commit this momentarily.
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to trunk. Thanks a lot for the contribution, Brandon.

        Show
        Aaron T. Myers added a comment - I've just committed this to trunk. Thanks a lot for the contribution, Brandon.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2316 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2316/)
        HDFS-3163. TestHDFSCLI.testAll fails if the user name is not all lowercase. Contributed by Brandon Li. (Revision 1338486)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338486
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2316 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2316/ ) HDFS-3163 . TestHDFSCLI.testAll fails if the user name is not all lowercase. Contributed by Brandon Li. (Revision 1338486) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338486 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2242 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2242/)
        HDFS-3163. TestHDFSCLI.testAll fails if the user name is not all lowercase. Contributed by Brandon Li. (Revision 1338486)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338486
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2242 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2242/ ) HDFS-3163 . TestHDFSCLI.testAll fails if the user name is not all lowercase. Contributed by Brandon Li. (Revision 1338486) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338486 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2259 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2259/)
        HDFS-3163. TestHDFSCLI.testAll fails if the user name is not all lowercase. Contributed by Brandon Li. (Revision 1338486)

        Result = ABORTED
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338486
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2259 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2259/ ) HDFS-3163 . TestHDFSCLI.testAll fails if the user name is not all lowercase. Contributed by Brandon Li. (Revision 1338486) Result = ABORTED atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338486 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
        Hide
        Brandon Li added a comment -

        uploaded the patch for branch-1. Test TestCLI passed with user Brandon.

        Show
        Brandon Li added a comment - uploaded the patch for branch-1. Test TestCLI passed with user Brandon.
        Hide
        Brandon Li added a comment -

        uploaded the patch for branch-1-win. Test TestCLI passed with user Brandon.

        Show
        Brandon Li added a comment - uploaded the patch for branch-1-win. Test TestCLI passed with user Brandon.
        Hide
        Matt Foley added a comment -

        Closed upon release of Hadoop 1.2.0.

        Show
        Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
        Hide
        Suresh Srinivas added a comment -

        I have merged this change to 2.1.0-beta.

        Show
        Suresh Srinivas added a comment - I have merged this change to 2.1.0-beta.

          People

          • Assignee:
            Brandon Li
            Reporter:
            Brandon Li
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development