Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: build
    • Labels:
      None

      Description

      This is the HDFS portion of HADOOP-8005. HDFS no longer depends upon slf4j, so removing it from the assembly will eliminate the HDFS-portion of the multiple SLF4J warnings.

      1. HDFS-3136.patch
        0.7 kB
        Jason Lowe

        Issue Links

          Activity

          Hide
          Jason Lowe added a comment -

          Patch to remove slf4j dependency. No unit tests since this is a build change. Manually verified that the multiple SLF4J binding warning from the hdfs lib path is no longer present with this change.

          Show
          Jason Lowe added a comment - Patch to remove slf4j dependency. No unit tests since this is a build change. Manually verified that the multiple SLF4J binding warning from the hdfs lib path is no longer present with this change.
          Hide
          Scott Carey added a comment -

          It appears that in the old case, the problem is that slf4j-log4j12 was specified wrong. It should always be specified as <optional>true</optional> or baring that, <scope>provided</scope> is acceptable but can lead to some multiple binding errors during unit tests (but not deployment).

          It appears that it is not needed at all however – is this because all of Hadoop is moving away from SLF4J?

          Show
          Scott Carey added a comment - It appears that in the old case, the problem is that slf4j-log4j12 was specified wrong. It should always be specified as <optional>true</optional> or baring that, <scope>provided</scope> is acceptable but can lead to some multiple binding errors during unit tests (but not deployment). It appears that it is not needed at all however – is this because all of Hadoop is moving away from SLF4J?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12519712/HDFS-3136.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.cli.TestHDFSCLI
          org.apache.hadoop.hdfs.TestGetBlocks

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2084//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2084//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2084//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519712/HDFS-3136.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.TestGetBlocks +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2084//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2084//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2084//console This message is automatically generated.
          Hide
          Jason Lowe added a comment -

          It doesn't look like the test failures are related to this change. The findbugs warning is a known issue in trunk tracked by HDFS-3132.

          Show
          Jason Lowe added a comment - It doesn't look like the test failures are related to this change. The findbugs warning is a known issue in trunk tracked by HDFS-3132 .
          Hide
          Jason Lowe added a comment -

          @Scott, I don't know if Hadoop is moving away from SLF4J or not. I just happened to notice that it's not referenced, and removing the unnecessary dependency seemed like the most straightforward fix to the warning for the copy that's in hadoop/hdfs/lib.

          Show
          Jason Lowe added a comment - @Scott, I don't know if Hadoop is moving away from SLF4J or not. I just happened to notice that it's not referenced, and removing the unnecessary dependency seemed like the most straightforward fix to the warning for the copy that's in hadoop/hdfs/lib.
          Hide
          Suresh Srinivas added a comment -

          +1. I will commit the patch soon.

          Show
          Suresh Srinivas added a comment - +1. I will commit the patch soon.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2031 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2031/)
          HDFS-3136. Remove SLF4J dependency as HDFS does not need it to fix unnecessary warnings. Contributed by Jason Lowe. (Revision 1310476)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310476
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2031 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2031/ ) HDFS-3136 . Remove SLF4J dependency as HDFS does not need it to fix unnecessary warnings. Contributed by Jason Lowe. (Revision 1310476) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310476 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2018 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2018/)
          HDFS-3136. Remove SLF4J dependency as HDFS does not need it to fix unnecessary warnings. Contributed by Jason Lowe. (Revision 1310476)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310476
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2018 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2018/ ) HDFS-3136 . Remove SLF4J dependency as HDFS does not need it to fix unnecessary warnings. Contributed by Jason Lowe. (Revision 1310476) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310476 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2093 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2093/)
          HDFS-3136. Remove SLF4J dependency as HDFS does not need it to fix unnecessary warnings. Contributed by Jason Lowe. (Revision 1310476)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310476
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2093 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2093/ ) HDFS-3136 . Remove SLF4J dependency as HDFS does not need it to fix unnecessary warnings. Contributed by Jason Lowe. (Revision 1310476) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310476 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1007 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1007/)
          HDFS-3136. Remove SLF4J dependency as HDFS does not need it to fix unnecessary warnings. Contributed by Jason Lowe. (Revision 1310476)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310476
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1007 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1007/ ) HDFS-3136 . Remove SLF4J dependency as HDFS does not need it to fix unnecessary warnings. Contributed by Jason Lowe. (Revision 1310476) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310476 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1042 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1042/)
          HDFS-3136. Remove SLF4J dependency as HDFS does not need it to fix unnecessary warnings. Contributed by Jason Lowe. (Revision 1310476)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310476
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1042 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1042/ ) HDFS-3136 . Remove SLF4J dependency as HDFS does not need it to fix unnecessary warnings. Contributed by Jason Lowe. (Revision 1310476) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310476 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Merged to 0.23.

          Show
          Tsz Wo Nicholas Sze added a comment - Merged to 0.23.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #227 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/227/)
          svn merge -c 1310476 from trunk for HDFS-3136. Remove SLF4J dependency as HDFS does not need it to fix unnecessary warnings. (Revision 1325938)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325938
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #227 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/227/ ) svn merge -c 1310476 from trunk for HDFS-3136 . Remove SLF4J dependency as HDFS does not need it to fix unnecessary warnings. (Revision 1325938) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1325938 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/pom.xml

            People

            • Assignee:
              Jason Lowe
              Reporter:
              Jason Lowe
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development