[HDFS-3134] Harden edit log loader against malformed or malicious input

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.23.0
• Fix Version/s: 2.0.2-alpha
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Colin McCabe
• Reporter: Colin McCabe
• Created: 23/Mar/12 20:32
• Updated: 02/May/13 02:29
• Resolved: 11/May/12 20:45

Description

Currently, the edit log loader does not handle bad or malicious input sensibly.

We can often cause OutOfMemory exceptions, null pointer exceptions, or other unchecked exceptions to be thrown by feeding the edit log loader bad input. In some environments, an out of memory error can cause the JVM process to be terminated.

It's clear that we want these exceptions to be thrown as IOException instead of as unchecked exceptions. We also want to avoid out of memory situations.

The main task here is to put a sensible upper limit on the lengths of arrays and strings we allocate on command. The other task is to try to avoid creating unchecked exceptions (by dereferencing potentially-NULL pointers, for example). Instead, we should verify ahead of time and give a more sensible error message that reflects the problem with the input.

Issue Links

• depends upon: HADOOP-8275 Range check DelegationKey length
• is blocked by: HADOOP-8361 Avoid out-of-memory problems when deserializing strings
• relates to: HDFS-3004 Implement Recovery Mode
• relates to: HDFS-3346 add fuzz tester for FSImage serialization / deserializtion