Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: ha, namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In this subtask, I plan to add JournalService. It will provide the following functionality:

      1. Starts RPC server with JournalProtocolService or uses the RPC server provided and add JournalProtocol service.
      2. Registers with the namenode.
      3. Receives JournalProtocol related requests and hands it to over to a listener.
      1. HDFS-3125.patch
        16 kB
        Suresh Srinivas
      2. HDFS-3125.patch
        16 kB
        Suresh Srinivas
      3. HDFS-3125.patch
        16 kB
        Suresh Srinivas
      4. HDFS-3125.patch
        15 kB
        Suresh Srinivas

        Activity

        Hide
        Suresh Srinivas added a comment -

        I will create a separate jira to add tests, as this work is still under development

        Show
        Suresh Srinivas added a comment - I will create a separate jira to add tests, as this work is still under development
        Hide
        Todd Lipcon added a comment -

        It seems like, if this is meant to be generic, you might be able to refactor the BackupNode code to make use of it. Is that in scope?

        Show
        Todd Lipcon added a comment - It seems like, if this is meant to be generic, you might be able to refactor the BackupNode code to make use of it. Is that in scope?
        Hide
        Suresh Srinivas added a comment -

        Yes. I plan to use this for BackupNode as well.

        Show
        Suresh Srinivas added a comment - Yes. I plan to use this for BackupNode as well.
        Hide
        Suresh Srinivas added a comment -

        More cleanup. Supports two modes:

        1. Start daemon with an existing rpc server - for daemons embedded into Namenode process.
        2. Mode which creates RPC server for stand alone daemon.
        Show
        Suresh Srinivas added a comment - More cleanup. Supports two modes: Start daemon with an existing rpc server - for daemons embedded into Namenode process. Mode which creates RPC server for stand alone daemon.
        Hide
        Suresh Srinivas added a comment -

        Patch with tests

        Show
        Suresh Srinivas added a comment - Patch with tests
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12519583/HDFS-3125.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2081//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2081//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519583/HDFS-3125.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2081//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2081//console This message is automatically generated.
        Hide
        Suresh Srinivas added a comment -

        Updated patch - ready for review.

        Show
        Suresh Srinivas added a comment - Updated patch - ready for review.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12519636/HDFS-3125.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2082//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2082//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2082//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519636/HDFS-3125.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2082//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2082//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2082//console This message is automatically generated.
        Hide
        Suresh Srinivas added a comment -

        Findbugs warning is unrelated to this change and tracked in HDFS-3132.

        Show
        Suresh Srinivas added a comment - Findbugs warning is unrelated to this change and tracked in HDFS-3132 .
        Hide
        Tsz Wo Nicholas Sze added a comment -
        • Question: why service is need in the methods of JournalListener?
        • Should we throw exceptions in journal(..) and startLogSegment(..) during starting up? More generally, do we need some states or some kind of life cycle such as INIT, STARTING, RUNNING, STOPPED?
        • JournalService is not thread safe. Some methods such as stop() need to be synchronized. JournalService.stopped has to be volatile.
        • Verify registration in startLogSegment(..)
        • Some typos:
          • 58: listner
          • 79: inforamtion
        Show
        Tsz Wo Nicholas Sze added a comment - Question: why service is need in the methods of JournalListener? Should we throw exceptions in journal(..) and startLogSegment(..) during starting up? More generally, do we need some states or some kind of life cycle such as INIT, STARTING, RUNNING, STOPPED? JournalService is not thread safe. Some methods such as stop() need to be synchronized. JournalService.stopped has to be volatile. Verify registration in startLogSegment(..) Some typos: 58: listner 79: inforamtion
        Hide
        Tsz Wo Nicholas Sze added a comment -

        One more comment:

        • Does is make sense to support multiple listeners? If yes, we should implement the observer pattern.
        Show
        Tsz Wo Nicholas Sze added a comment - One more comment: Does is make sense to support multiple listeners? If yes, we should implement the observer pattern.
        Hide
        Suresh Srinivas added a comment -

        Question: why service is need in the methods of JournalListener?

        Makes it convenient to know which listener is sending the call back. Then the listener can stop the service using the reference it gets.

        Does is make sense to support multiple listeners? If yes, we should implement the observer pattern.

        I do not have a use case for multiple lister. If needed, we can add support for it later. What do you think?

        Other comments addressed. I also changed exception handling - the exception from callbacks are thrown all the way to the client.

        Show
        Suresh Srinivas added a comment - Question: why service is need in the methods of JournalListener? Makes it convenient to know which listener is sending the call back. Then the listener can stop the service using the reference it gets. Does is make sense to support multiple listeners? If yes, we should implement the observer pattern. I do not have a use case for multiple lister. If needed, we can add support for it later. What do you think? Other comments addressed. I also changed exception handling - the exception from callbacks are thrown all the way to the client.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12519764/HDFS-3125.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hdfs.TestGetBlocks
        org.apache.hadoop.cli.TestHDFSCLI

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2088//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2088//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519764/HDFS-3125.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestGetBlocks org.apache.hadoop.cli.TestHDFSCLI +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2088//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2088//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        The new patch needs to check state in journal(..) and startLogSegment(..), and verify(registration) in startLogSegment(..). Otherwise, it looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - The new patch needs to check state in journal(..) and startLogSegment(..), and verify(registration) in startLogSegment(..). Otherwise, it looks good.
        Hide
        Suresh Srinivas added a comment -

        The new patch needs to check state in journal(..) and startLogSegment(..), and verify(registration) in startLogSegment(..). Otherwise, it looks good.

        Currently theses states are for listener side only. The method calls above are received over RPC call. Given that RPC server could be controlled from outside, the expectation is that either Service stop has stopped RPC server or external application has stopped the server.

        The missing functionality currently is - Service should unregister during stop. Currently an errorReport of fatal is used as unregister. I was planning to add unregister method to the protocol. If that is not needed, I can call errorReport in service#stop() method.

        Show
        Suresh Srinivas added a comment - The new patch needs to check state in journal(..) and startLogSegment(..), and verify(registration) in startLogSegment(..). Otherwise, it looks good. Currently theses states are for listener side only. The method calls above are received over RPC call. Given that RPC server could be controlled from outside, the expectation is that either Service stop has stopped RPC server or external application has stopped the server. The missing functionality currently is - Service should unregister during stop. Currently an errorReport of fatal is used as unregister. I was planning to add unregister method to the protocol. If that is not needed, I can call errorReport in service#stop() method.
        Hide
        Suresh Srinivas added a comment -

        Updated patch with verifyRequest added to startLogSegment method

        Show
        Suresh Srinivas added a comment - Updated patch with verifyRequest added to startLogSegment method
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12520014/HDFS-3125.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hdfs.TestGetBlocks
        org.apache.hadoop.cli.TestHDFSCLI

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2102//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2102//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520014/HDFS-3125.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestGetBlocks org.apache.hadoop.cli.TestHDFSCLI +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2102//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2102//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 the latest patch look goods.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 the latest patch look goods.
        Hide
        Suresh Srinivas added a comment -

        I committed the patch.

        Show
        Suresh Srinivas added a comment - I committed the patch.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1935 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1935/)
        HDFS-3125. Add JournalService to enable Journal Daemon. Contributed by Suresh Srinivas. (Revision 1305726)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305726
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalService.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestJournalService.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1935 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1935/ ) HDFS-3125 . Add JournalService to enable Journal Daemon. Contributed by Suresh Srinivas. (Revision 1305726) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305726 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalService.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestJournalService.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2010 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2010/)
        HDFS-3125. Add JournalService to enable Journal Daemon. Contributed by Suresh Srinivas. (Revision 1305726)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305726
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalService.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestJournalService.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2010 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2010/ ) HDFS-3125 . Add JournalService to enable Journal Daemon. Contributed by Suresh Srinivas. (Revision 1305726) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305726 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalService.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestJournalService.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1948 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1948/)
        HDFS-3125. Add JournalService to enable Journal Daemon. Contributed by Suresh Srinivas. (Revision 1305726)

        Result = ABORTED
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305726
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalService.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestJournalService.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1948 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1948/ ) HDFS-3125 . Add JournalService to enable Journal Daemon. Contributed by Suresh Srinivas. (Revision 1305726) Result = ABORTED suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305726 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalService.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestJournalService.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #997 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/997/)
        HDFS-3125. Add JournalService to enable Journal Daemon. Contributed by Suresh Srinivas. (Revision 1305726)

        Result = FAILURE
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305726
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalService.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestJournalService.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #997 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/997/ ) HDFS-3125 . Add JournalService to enable Journal Daemon. Contributed by Suresh Srinivas. (Revision 1305726) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305726 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalService.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestJournalService.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1032 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1032/)
        HDFS-3125. Add JournalService to enable Journal Daemon. Contributed by Suresh Srinivas. (Revision 1305726)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305726
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalService.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestJournalService.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1032 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1032/ ) HDFS-3125 . Add JournalService to enable Journal Daemon. Contributed by Suresh Srinivas. (Revision 1305726) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1305726 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalService.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestJournalService.java
        Hide
        Fengdong Yu added a comment -

        Hi man,
        Are you sure you checked in correctly?

        There is no hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalService.java
        in the trunk now.

        can you check it again? Thanks.

        Show
        Fengdong Yu added a comment - Hi man, Are you sure you checked in correctly? There is no hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalService.java in the trunk now. can you check it again? Thanks.
        Hide
        Suresh Srinivas added a comment -

        Not sure what the confusion is. On trunk, I can see the file:
        hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/journalservice/JournalService.java

        Show
        Suresh Srinivas added a comment - Not sure what the confusion is. On trunk, I can see the file: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/journalservice/JournalService.java
        Hide
        Fengdong Yu added a comment -

        Not sure what the confusion is. On trunk, I can see the file:

        yes, it is there now. maybe I missed something, hm..

        Show
        Fengdong Yu added a comment - Not sure what the confusion is. On trunk, I can see the file: yes, it is there now. maybe I missed something, hm..
        Hide
        Suresh Srinivas added a comment - - edited

        BTW I have filed HDFS-4904 to remove this code, which is no longer being used. So comment if you have any issues with the removal on that jira.

        Show
        Suresh Srinivas added a comment - - edited BTW I have filed HDFS-4904 to remove this code, which is no longer being used. So comment if you have any issues with the removal on that jira.

          People

          • Assignee:
            Suresh Srinivas
            Reporter:
            Suresh Srinivas
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development