Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.2, 0.23.3
    • Fix Version/s: 2.0.0-alpha, 3.0.0
    • Component/s: None
    • Labels:
      None

      Description

      This JIRA is to write tests for viewing quota using viewfs.

      1. hdfs-3121.patch
        8 kB
        John George
      2. hdfs-3121.patch
        8 kB
        John George
      3. hdfs-3121.patch
        8 kB
        John George
      4. hdfs-3121.patch
        7 kB
        John George
      5. hdfs-3121.patch
        7 kB
        John George
      6. hdfs-3121.patch
        2 kB
        John George

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1042 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1042/)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1042 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1042/ ) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1007 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1007/)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1007 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1007/ ) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2035 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2035/)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)

          Result = ABORTED
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2035 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2035/ ) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630) Result = ABORTED suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2024 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2024/)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2024 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2024/ ) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2099 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2099/)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
          HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2099 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2099/ ) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631) HDFS-3121 . Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Suresh Srinivas added a comment -

          I committed the change to trunk and 2.0. Thanks you John.

          Show
          Suresh Srinivas added a comment - I committed the change to trunk and 2.0. Thanks you John.
          Hide
          John George added a comment -

          Attaching another patch to take the change (move NotInMountPoint exception to another file) in hadoop-8014 into consideration.

          Show
          John George added a comment - Attaching another patch to take the change (move NotInMountPoint exception to another file) in hadoop-8014 into consideration.
          Hide
          Suresh Srinivas added a comment -

          I should wait for HADOOP-8014 to be committed before committing this, right?

          Show
          Suresh Srinivas added a comment - I should wait for HADOOP-8014 to be committed before committing this, right?
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch. I will commit it soon.

          Show
          Suresh Srinivas added a comment - +1 for the patch. I will commit it soon.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521512/hdfs-3121.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2195//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2195//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521512/hdfs-3121.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2195//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2195//console This message is automatically generated.
          Hide
          John George added a comment -

          wrong patch. will upload another one.

          Show
          John George added a comment - wrong patch. will upload another one.
          Hide
          John George added a comment -

          Thanks a lot for reviewing this Suresh. Uploading a patch that with all your current comments addressed.

          Show
          John George added a comment - Thanks a lot for reviewing this Suresh. Uploading a patch that with all your current comments addressed.
          Hide
          Suresh Srinivas added a comment -

          Comments:

          1. Not very clear "THis test is test the fix.". Instead of describing running into serialization problem etc. can you just describe what the test is. Also please move the description as class level javadoc.
          2. minor: defaultBLockSize -> defaultBlockSize
          3. Please ensure line lengths are with in 80 chars limit
          4. testGetDefaultBlockSize() indententation at "try" is not correct. I am also not clear about the comment createFile... What has createFile got to do with the test?
          5. Please add a brief description of what the test is testing.
          6. Please consider: When expecting an exception in tests, you can move fail() within try clause, after the method that you expect exception from. This avoids also return from catch blocks.
          Show
          Suresh Srinivas added a comment - Comments: Not very clear "THis test is test the fix.". Instead of describing running into serialization problem etc. can you just describe what the test is. Also please move the description as class level javadoc. minor: defaultBLockSize -> defaultBlockSize Please ensure line lengths are with in 80 chars limit testGetDefaultBlockSize() indententation at "try" is not correct. I am also not clear about the comment createFile... What has createFile got to do with the test? Please add a brief description of what the test is testing. Please consider: When expecting an exception in tests, you can move fail() within try clause, after the method that you expect exception from. This avoids also return from catch blocks.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12520178/hdfs-3121.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.cli.TestHDFSCLI
          org.apache.hadoop.hdfs.tools.TestDFSHAAdmin
          org.apache.hadoop.hdfs.TestGetBlocks

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2105//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2105//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520178/hdfs-3121.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.tools.TestDFSHAAdmin org.apache.hadoop.hdfs.TestGetBlocks +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2105//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2105//console This message is automatically generated.
          Hide
          John George added a comment -

          The failure is expected since HADOOP-8194 is not checked-in yet.

          Show
          John George added a comment - The failure is expected since HADOOP-8194 is not checked-in yet.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12519154/hdfs-3121.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.fs.viewfs.TestViewFsFileStatusHdfs

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2055//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2055//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519154/hdfs-3121.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsFileStatusHdfs +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2055//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2055//console This message is automatically generated.
          Hide
          John George added a comment -

          Attaching test for HADOOP-8194

          Show
          John George added a comment - Attaching test for HADOOP-8194

            People

            • Assignee:
              John George
              Reporter:
              John George
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development