Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3094

add -nonInteractive and -force option to namenode -format command

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0, 1.0.2
    • Fix Version/s: 1.1.0, 2.0.0-alpha
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      The 'namenode -format' command now supports the flags '-nonInteractive' and '-force' to improve usefulness without user input.

      Description

      Currently the bin/hadoop namenode -format prompts the user for a Y/N to setup the directories in the local file system.

      -force : namenode formats the directories without prompting
      -nonInterActive : namenode format will return with an exit code of 1 if the dir exists.

      1. HDFS-3094.patch
        15 kB
        Arpit Gupta
      2. HDFS-3094.patch
        18 kB
        Arpit Gupta
      3. HDFS-3094.patch
        18 kB
        Arpit Gupta
      4. HDFS-3094.patch
        19 kB
        Arpit Gupta
      5. HDFS-3094.patch
        20 kB
        Arpit Gupta
      6. HDFS-3094.patch
        20 kB
        Arpit Gupta
      7. HDFS-3094.patch
        20 kB
        Arpit Gupta
      8. HDFS-3094.branch-1.patch
        16 kB
        Arpit Gupta
      9. HDFS-3094.branch-1.0.patch
        13 kB
        Arpit Gupta
      10. HDFS-3094.branch-1.0.patch
        14 kB
        Arpit Gupta
      11. HDFS-3094.branch-1.0.patch
        14 kB
        Arpit Gupta
      12. HDFS-3094.branch-1.0.patch
        14 kB
        Arpit Gupta
      13. HDFS-3094.branch-1.0.patch
        14 kB
        Arpit Gupta
      14. HDFS-3094.branch-1.0.patch
        15 kB
        Arpit Gupta
      15. HDFS-3094.branch-1.0.patch
        15 kB
        Arpit Gupta
      16. HDFS-3094.branch-1.0.patch
        16 kB
        Arpit Gupta
      17. HDFS-3094.branch-1.0.patch
        16 kB
        Arpit Gupta

        Issue Links

          Activity

          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop-1.1.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.
          Hide
          Todd Lipcon added a comment -

          +1 for the branch-1 patch. I tested it manually from the command line as well. Will commit momentarily. Thanks Arpit and sorry for my delinquency on committing!

          Show
          Todd Lipcon added a comment - +1 for the branch-1 patch. I tested it manually from the command line as well. Will commit momentarily. Thanks Arpit and sorry for my delinquency on committing!
          Hide
          Arpit Gupta added a comment -

          rebased the patch for branch-1

          Show
          Arpit Gupta added a comment - rebased the patch for branch-1
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hey Todd, are you going to commit the branch-1 patch? Or I could commit it.

          Show
          Tsz Wo Nicholas Sze added a comment - Hey Todd, are you going to commit the branch-1 patch? Or I could commit it.
          Hide
          Arpit Gupta added a comment -

          Hey Todd the patch with the all the feedback addressed is attached, when you get a change if you can take a look and see if it is good to go and also commit HADOOP-8185 (doc changes for trunk for this patch)

          Show
          Arpit Gupta added a comment - Hey Todd the patch with the all the feedback addressed is attached, when you get a change if you can take a look and see if it is good to go and also commit HADOOP-8185 (doc changes for trunk for this patch)
          Hide
          Arpit Gupta added a comment -

          attached patch incorporating review changes.

          Show
          Arpit Gupta added a comment - attached patch incorporating review changes.
          Hide
          Todd Lipcon added a comment -

          A few nits on the branch-1 patch:

          +          System.err.println("Format aborted as dir "+ curDir +" exits.");
          

          typo: "exists". I would also reformat as: "Format aborted: " + curDir + " exists."

          the same typo ("exits" for "exists") is in one of the test cases


          +      boolean isConfirmationNeeded, boolean isInterActive) throws IOException {
          

          Should be isInteractive – not capital 'A'


          +      StartupOption.FORMAT.getName()  + "[" + StartupOption.FORCE.getName() +  
          +      " ] ["+StartupOption.NONINTERACTIVE.getName()+"] | [" +
          

          Formatting is off here. When I run it I see:

          Usage: java NameNode [-format[-force ] [-nonInteractive] | [-upgrade] | [-rollback] | [-finalize] | [-importCheckpoint]
          

          should read:

          Usage: java NameNode [-format [-force] [-nonInteractive]] | [-upgrade] | [-rollback] | [-finalize] | [-importCheckpoint]
          
          Show
          Todd Lipcon added a comment - A few nits on the branch-1 patch: + System .err.println( "Format aborted as dir " + curDir + " exits." ); typo: "exists". I would also reformat as: "Format aborted: " + curDir + " exists." the same typo ("exits" for "exists") is in one of the test cases + boolean isConfirmationNeeded, boolean isInterActive) throws IOException { Should be isInteractive – not capital 'A' + StartupOption.FORMAT.getName() + "[" + StartupOption.FORCE.getName() + + " ] [" +StartupOption.NONINTERACTIVE.getName()+ "] | [" + Formatting is off here. When I run it I see: Usage: java NameNode [-format[-force ] [-nonInteractive] | [-upgrade] | [-rollback] | [-finalize] | [-importCheckpoint] should read: Usage: java NameNode [-format [-force] [-nonInteractive]] | [-upgrade] | [-rollback] | [-finalize] | [-importCheckpoint]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1046 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1046/)
          HDFS-3094. add -nonInteractive and -force option to namenode -format command. Contributed by Arpit Gupta. (Revision 1312025)

          Result = SUCCESS
          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1312025
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestClusterId.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1046 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1046/ ) HDFS-3094 . add -nonInteractive and -force option to namenode -format command. Contributed by Arpit Gupta. (Revision 1312025) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1312025 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestClusterId.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1011 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1011/)
          HDFS-3094. add -nonInteractive and -force option to namenode -format command. Contributed by Arpit Gupta. (Revision 1312025)

          Result = FAILURE
          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1312025
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestClusterId.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1011 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1011/ ) HDFS-3094 . add -nonInteractive and -force option to namenode -format command. Contributed by Arpit Gupta. (Revision 1312025) Result = FAILURE todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1312025 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestClusterId.java
          Hide
          Todd Lipcon added a comment -

          Ah, sorry, forgot about branch-1. I'll look at that later tonight or tomorrow, as well as the docs. Reopening so it doesn't get lost

          Show
          Todd Lipcon added a comment - Ah, sorry, forgot about branch-1. I'll look at that later tonight or tomorrow, as well as the docs. Reopening so it doesn't get lost
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2059 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2059/)
          HDFS-3094. add -nonInteractive and -force option to namenode -format command. Contributed by Arpit Gupta. (Revision 1312025)

          Result = ABORTED
          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1312025
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestClusterId.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2059 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2059/ ) HDFS-3094 . add -nonInteractive and -force option to namenode -format command. Contributed by Arpit Gupta. (Revision 1312025) Result = ABORTED todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1312025 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestClusterId.java
          Hide
          Arpit Gupta added a comment -

          Todd thanks for committing the patch. I had created HADOOP-8185 for the doc changes for this patch. If you can take a look at that and see if it looks good to go.

          Also have the branch 1.0 patch attached and i kept it in sync when i made changes based on reviews. If you can take a look that will be great.

          Show
          Arpit Gupta added a comment - Todd thanks for committing the patch. I had created HADOOP-8185 for the doc changes for this patch. If you can take a look at that and see if it looks good to go. Also have the branch 1.0 patch attached and i kept it in sync when i made changes based on reviews. If you can take a look that will be great.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2046 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2046/)
          HDFS-3094. add -nonInteractive and -force option to namenode -format command. Contributed by Arpit Gupta. (Revision 1312025)

          Result = SUCCESS
          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1312025
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestClusterId.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2046 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2046/ ) HDFS-3094 . add -nonInteractive and -force option to namenode -format command. Contributed by Arpit Gupta. (Revision 1312025) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1312025 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestClusterId.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2120/)
          HDFS-3094. add -nonInteractive and -force option to namenode -format command. Contributed by Arpit Gupta. (Revision 1312025)

          Result = SUCCESS
          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1312025
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestClusterId.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2120/ ) HDFS-3094 . add -nonInteractive and -force option to namenode -format command. Contributed by Arpit Gupta. (Revision 1312025) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1312025 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestClusterId.java
          Hide
          Todd Lipcon added a comment -

          Committed to branch-2 and trunk. Thanks, Arpit.

          Show
          Todd Lipcon added a comment - Committed to branch-2 and trunk. Thanks, Arpit.
          Hide
          Todd Lipcon added a comment -

          +1, I'll commit this momentarily

          Show
          Todd Lipcon added a comment - +1, I'll commit this momentarily
          Hide
          Arpit Gupta added a comment -

          i believe test failure is unrelated.

          Show
          Arpit Gupta added a comment - i believe test failure is unrelated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12522032/HDFS-3094.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hdfs.TestFileAppend4

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2235//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2235//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522032/HDFS-3094.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestFileAppend4 +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2235//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2235//console This message is automatically generated.
          Hide
          Arpit Gupta added a comment -

          updated patch for trunk.

          Todd since force option is being used for recovery, i changed the vars for this patch to isForceFormat and isInteractiveFormat and the appropriate methods.

          Show
          Arpit Gupta added a comment - updated patch for trunk. Todd since force option is being used for recovery, i changed the vars for this patch to isForceFormat and isInteractiveFormat and the appropriate methods.
          Hide
          Todd Lipcon added a comment -

          Sorry again Arpit - looks like the commit of HDFS-3004 caused another conflict here just a couple hours ago...

          Show
          Todd Lipcon added a comment - Sorry again Arpit - looks like the commit of HDFS-3004 caused another conflict here just a couple hours ago...
          Hide
          Arpit Gupta added a comment -

          test failure does not seem to be related to the patch.

          Show
          Arpit Gupta added a comment - test failure does not seem to be related to the patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521996/HDFS-3094.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hdfs.TestDatanodeBlockScanner

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2233//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2233//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521996/HDFS-3094.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDatanodeBlockScanner +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2233//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2233//console This message is automatically generated.
          Hide
          Arpit Gupta added a comment -

          rebased patch for trunk

          Show
          Arpit Gupta added a comment - rebased patch for trunk
          Hide
          Arpit Gupta added a comment -

          thanks for the reviews Todd, let me see if i can generate the trunk patch again.

          Show
          Arpit Gupta added a comment - thanks for the reviews Todd, let me see if i can generate the trunk patch again.
          Hide
          Todd Lipcon added a comment -

          oops, please excuse my typo of your name, Arpit!

          Show
          Todd Lipcon added a comment - oops, please excuse my typo of your name, Arpit !
          Hide
          Todd Lipcon added a comment -

          Hi Aprit. The patch looks good now, but it seems to have developed some conflicts against trunk

          Show
          Todd Lipcon added a comment - Hi Aprit. The patch looks good now, but it seems to have developed some conflicts against trunk
          Hide
          Arpit Gupta added a comment -

          Todd i have addressed all your feedback, when you get a chance if you can review the patches that would be great.

          Show
          Arpit Gupta added a comment - Todd i have addressed all your feedback, when you get a chance if you can review the patches that would be great.
          Hide
          Arpit Gupta added a comment -

          Todd i have addressed all your feedback, when you get a chance if you can review the patches that would be great.

          Show
          Arpit Gupta added a comment - Todd i have addressed all your feedback, when you get a chance if you can review the patches that would be great.
          Hide
          Arpit Gupta added a comment -

          added license to the new test file.

          Show
          Arpit Gupta added a comment - added license to the new test file.
          Hide
          Eli Collins added a comment -

          Test failure is HDFS-3174, posted a patch for it.

          Show
          Eli Collins added a comment - Test failure is HDFS-3174 , posted a patch for it.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12520852/HDFS-3094.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hdfs.server.blockmanagement.TestPendingDataNodeMessages

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2149//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2149//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520852/HDFS-3094.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.server.blockmanagement.TestPendingDataNodeMessages +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2149//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2149//console This message is automatically generated.
          Hide
          Arpit Gupta added a comment -

          Attached patch for trunk with all feedback addressed.

          Show
          Arpit Gupta added a comment - Attached patch for trunk with all feedback addressed.
          Hide
          Arpit Gupta added a comment -

          Attached patch for branch 1.0.

          -1 overall.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 12 new Findbugs (version 1.3.9) warnings.

          finbugs warnings do not seem to be related.

          Show
          Arpit Gupta added a comment - Attached patch for branch 1.0. -1 overall. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 12 new Findbugs (version 1.3.9) warnings. finbugs warnings do not seem to be related.
          Hide
          Arpit Gupta added a comment -

          Canceling the patch while i address the feedback.

          Show
          Arpit Gupta added a comment - Canceling the patch while i address the feedback.
          Hide
          Todd Lipcon added a comment -

          Style nits:

          +        for(i=i+1 ; i < argsLen ; i++) {
          

          space after "for", no space before ";"s, spaces in "i = i + 1"


          +              // as no cluster id specified, return null
          

          should read "if no cluster id specified"


          +            // make sure the user did not send -force or -noninteractive as an
          +            // option after -clusterid or send no id after -clusterid
          

          replace "send" with "specify" (nothing's being sent here): "make sure the user did not specify -force or -nonInteractive as an option after -clusterId, or forget to specify an ID after -clusterId". Or maybe just "Make sure an id is specified, and not another flag."

          This comment inside the block seems redundant with the one above:

          +              // return null if the user sent something like
          +              // clusterid -force or clusterid -nonInteractive
          

          I think you can remove it.

          However, it seems like you should log a warning here with their mistake, something like:

          LOG.fatal("Must specify a valid cluster ID after the -clusterId flag")
          

          +            if (clusterId.isEmpty()
          +                || clusterId.equalsIgnoreCase(StartupOption.FORCE.getName())
          +                || clusterId.equalsIgnoreCase(StartupOption.NONINTERACTIVE
          +                    .getName())) {
          

          formatting: ||s should go on the line before. ie:

                      if (clusterId.isEmpty() ||
                          clusterId.equalsIgnoreCase(StartupOption.FORCE.getName()) ||
                          clusterId.equalsIgnoreCase(
                              StartupOption.NONINTERACTIVE.getName())) {
          

          -        boolean aborted = format(conf, false);
          +      boolean aborted = format(conf, startOpt.getForce(),
          

          bad indentation on this line


          +  protected static class ExitException extends SecurityException {
          

          Why is this protected instead of private?

          Please move the inner classes to the bottom of the file


          In the tests, please change the '//' style comments before each test case to be javadoc style

          • in all the test cases, I think you need to add the line:
            fail("createNameNode() did not call System.exit()")
            

            inside the try clause. Otherwise if the code just returned without exiting, we wouldn't catch the bug.


          +    final Configuration config = new Configuration();
          +    config.set(DFS_NAMENODE_NAME_DIR_KEY, hdfsDir.getPath());
          

          This code shows up in almost all the cases. Can it be done in the setup method?

          Show
          Todd Lipcon added a comment - Style nits: + for (i=i+1 ; i < argsLen ; i++) { space after "for", no space before ";"s, spaces in "i = i + 1" + // as no cluster id specified, return null should read " if no cluster id specified" + // make sure the user did not send -force or -noninteractive as an + // option after -clusterid or send no id after -clusterid replace "send" with "specify" (nothing's being sent here): "make sure the user did not specify -force or -nonInteractive as an option after -clusterId, or forget to specify an ID after -clusterId". Or maybe just "Make sure an id is specified, and not another flag." This comment inside the block seems redundant with the one above: + // return null if the user sent something like + // clusterid -force or clusterid -nonInteractive I think you can remove it. However, it seems like you should log a warning here with their mistake, something like: LOG.fatal( "Must specify a valid cluster ID after the -clusterId flag" ) + if (clusterId.isEmpty() + || clusterId.equalsIgnoreCase(StartupOption.FORCE.getName()) + || clusterId.equalsIgnoreCase(StartupOption.NONINTERACTIVE + .getName())) { formatting: ||s should go on the line before. ie: if (clusterId.isEmpty() || clusterId.equalsIgnoreCase(StartupOption.FORCE.getName()) || clusterId.equalsIgnoreCase( StartupOption.NONINTERACTIVE.getName())) { - boolean aborted = format(conf, false ); + boolean aborted = format(conf, startOpt.getForce(), bad indentation on this line + protected static class ExitException extends SecurityException { Why is this protected instead of private? Please move the inner classes to the bottom of the file In the tests, please change the '//' style comments before each test case to be javadoc style in all the test cases, I think you need to add the line: fail( "createNameNode() did not call System .exit()" ) inside the try clause. Otherwise if the code just returned without exiting, we wouldn't catch the bug. + final Configuration config = new Configuration(); + config.set(DFS_NAMENODE_NAME_DIR_KEY, hdfsDir.getPath()); This code shows up in almost all the cases. Can it be done in the setup method?
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Todd, I will commit this if we don't hear your response.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good. Todd, I will commit this if we don't hear your response.
          Hide
          Arpit Gupta added a comment -

          Hey Todd the latest patch address all your earlier comments, could you please review it.

          Thanks

          Show
          Arpit Gupta added a comment - Hey Todd the latest patch address all your earlier comments, could you please review it. Thanks
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12519125/HDFS-3094.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2053//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2053//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519125/HDFS-3094.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2053//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2053//console This message is automatically generated.
          Hide
          Arpit Gupta added a comment -

          should be -nonInteractive (not a capital 'A')

          done

          Rename getisForce to just isForce or isForceEnabled().

          done

          Updated tests to not use a different thread and sleep

          It looks like if you specify invalid options, it won't give any kind of useful error message. You should probably be throwing HadoopIllegalArgumentException instead of returning null in several of these cases.

          Left as is, as returning null causes usage to be printed which will show the correct format.

          Show
          Arpit Gupta added a comment - should be -nonInteractive (not a capital 'A') done Rename getisForce to just isForce or isForceEnabled(). done Updated tests to not use a different thread and sleep It looks like if you specify invalid options, it won't give any kind of useful error message. You should probably be throwing HadoopIllegalArgumentException instead of returning null in several of these cases. Left as is, as returning null causes usage to be printed which will show the correct format.
          Hide
          Arpit Gupta added a comment -

          Attached patch for trunk with the comments addressed.

          Show
          Arpit Gupta added a comment - Attached patch for trunk with the comments addressed.
          Hide
          Arpit Gupta added a comment -

          Attached an updated patch for branch 1.0 with comments addressed

          Here are the test patch results

          BUILD SUCCESSFUL
          Total time: 7 minutes 22 seconds
          
          
          
          
          -1 overall.
          
              +1 @author.  The patch does not contain any @author tags.
          
              +1 tests included.  The patch appears to include 3 new or modified tests.
          
              +1 javadoc.  The javadoc tool did not generate any warning messages.
          
              +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
          
              -1 findbugs.  The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.
          

          Findbugs warnings are unrelated to this patch

          Show
          Arpit Gupta added a comment - Attached an updated patch for branch 1.0 with comments addressed Here are the test patch results BUILD SUCCESSFUL Total time: 7 minutes 22 seconds -1 overall. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings. Findbugs warnings are unrelated to this patch
          Hide
          Arpit Gupta added a comment -

          Thanks for the review Todd. I will make appropriate changes to the branch 1 and trunk.

          I don't follow the following comment:

          + //make sure the user did not sent force or noninteractive as the clusterid or an empty clusterid
          Can you clarify it?

          What i mean there is that if the user entered a wrong command where they did not specify a clusterid.

          ./bin/hadoop namenode -format -clusterid -force
          
          Show
          Arpit Gupta added a comment - Thanks for the review Todd. I will make appropriate changes to the branch 1 and trunk. I don't follow the following comment: + //make sure the user did not sent force or noninteractive as the clusterid or an empty clusterid Can you clarify it? What i mean there is that if the user entered a wrong command where they did not specify a clusterid. ./bin/hadoop namenode -format -clusterid -force
          Hide
          Todd Lipcon added a comment -
          +    NONINTERACTIVE("-nonInterActive");
          

          should be -nonInteractive (not a capital 'A')


          +    //default force to false
          +    private boolean isForce=false;
          +    //default interactive to true
          +    private boolean isInteractive=true;
          

          These comments are superfluous, since they just say the same thing as the code. Also, please add spaces before and after the '=' in the variable definitions.


          +    public boolean getisForce() {
          +      return isForce;
          +    }
          +    
          +    public void setisForce(boolean force) {
          +      isForce = force;
          +    }
          

          Rename getisForce to just isForce or isForceEnabled(). Rename setisForce to setForceEnabled() or setForce(). Same goes for isInteractive/setisInteractive below it.


          +        //by default force is off and interactive is on
          +        startOpt.setisForce(false);
          +        startOpt.setisInteractive(true);
          

          you already have these defaults in the variable declarations, no need to duplicate them


          • It looks like if you specify invalid options, it won't give any kind of useful error message. You should probably be throwing HadoopIllegalArgumentException instead of returning null in several of these cases.
          • I don't follow the following comment:
            + //make sure the user did not sent force or noninteractive as the clusterid or an empty clusterid

          Can you clarify it?


          In one of your test cases, you make a new thread and then sleep. This is not a reliable way of testing, especially since it wants to get user input. This won't work well in many test environments. I'd suggest we just use manual tests for this, or else set up a way to override System.in for the purpose of the test, so you can test without spawning a new thread.


          Style nits: please make the code look like the surrounding style in the rest of the codebase. Spaces around '=' signs. No spaces after '(' in if statements. Maximum 80 characters in a line, etc. No tabs (two space indentation). Space after '//'. Please read over your comments for typos as well.

          Show
          Todd Lipcon added a comment - + NONINTERACTIVE( "-nonInterActive" ); should be -nonInteractive (not a capital 'A') + // default force to false + private boolean isForce= false ; + // default interactive to true + private boolean isInteractive= true ; These comments are superfluous, since they just say the same thing as the code. Also, please add spaces before and after the '=' in the variable definitions. + public boolean getisForce() { + return isForce; + } + + public void setisForce( boolean force) { + isForce = force; + } Rename getisForce to just isForce or isForceEnabled() . Rename setisForce to setForceEnabled() or setForce() . Same goes for isInteractive / setisInteractive below it. + //by default force is off and interactive is on + startOpt.setisForce( false ); + startOpt.setisInteractive( true ); you already have these defaults in the variable declarations, no need to duplicate them It looks like if you specify invalid options, it won't give any kind of useful error message. You should probably be throwing HadoopIllegalArgumentException instead of returning null in several of these cases. I don't follow the following comment: + //make sure the user did not sent force or noninteractive as the clusterid or an empty clusterid Can you clarify it? In one of your test cases, you make a new thread and then sleep. This is not a reliable way of testing, especially since it wants to get user input. This won't work well in many test environments. I'd suggest we just use manual tests for this, or else set up a way to override System.in for the purpose of the test, so you can test without spawning a new thread. Style nits: please make the code look like the surrounding style in the rest of the codebase. Spaces around '=' signs. No spaces after '(' in if statements. Maximum 80 characters in a line, etc. No tabs (two space indentation). Space after '//'. Please read over your comments for typos as well.
          Hide
          Arpit Gupta added a comment -
          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hdfs.TestLeaseRecovery2
          
          +1 contrib tests. The patch passed contrib unit tests.
          

          I reran the test class multiple times and it went through. I have also created HADOOP-8185 for documentation changes to trunk.

          Show
          Arpit Gupta added a comment - -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestLeaseRecovery2 +1 contrib tests. The patch passed contrib unit tests. I reran the test class multiple times and it went through. I have also created HADOOP-8185 for documentation changes to trunk.
          Hide
          Arpit Gupta added a comment -

          Updated patch for branch 1.0 and here are the patch results.

          BUILD SUCCESSFUL
          Total time: 7 minutes 11 seconds

          -1 overall.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.

          The findbugs warnings are unrelated to this patch.

          Show
          Arpit Gupta added a comment - Updated patch for branch 1.0 and here are the patch results. BUILD SUCCESSFUL Total time: 7 minutes 11 seconds -1 overall. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings. The findbugs warnings are unrelated to this patch.
          Hide
          Arpit Gupta added a comment -

          canceling patch while investigating the test failure.

          Show
          Arpit Gupta added a comment - canceling patch while investigating the test failure.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12518849/HDFS-3094.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hdfs.TestLeaseRecovery2

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2033//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2033//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518849/HDFS-3094.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestLeaseRecovery2 +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2033//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2033//console This message is automatically generated.
          Hide
          Arpit Gupta added a comment -

          uploading the trunk patch as HDFS-3106 fixed the testHDFSCLI test failure and the test testGenericKeysForNameNodeFormat paseed locally on my machine.

          Show
          Arpit Gupta added a comment - uploading the trunk patch as HDFS-3106 fixed the testHDFSCLI test failure and the test testGenericKeysForNameNodeFormat paseed locally on my machine.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12518568/HDFS-3094.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.cli.TestHDFSCLI
          org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2023//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2023//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12518568/HDFS-3094.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2023//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2023//console This message is automatically generated.
          Hide
          Arpit Gupta added a comment -

          added more error checking for invalid clusterid options and added tests for them

          Show
          Arpit Gupta added a comment - added more error checking for invalid clusterid options and added tests for them
          Hide
          Arpit Gupta added a comment -

          patch for trunk, the docs patch is in a separate file HDFS-3094.docs.patch as that is in common.

          Show
          Arpit Gupta added a comment - patch for trunk, the docs patch is in a separate file HDFS-3094 .docs.patch as that is in common.
          Hide
          Arpit Gupta added a comment -

          updated documentation for branch 1.0,
          attached a patch for trunk doc as its in common.

          Show
          Arpit Gupta added a comment - updated documentation for branch 1.0, attached a patch for trunk doc as its in common.
          Hide
          Arpit Gupta added a comment -

          updated tests to check for non existence for version file when format command did not succeed.

          Show
          Arpit Gupta added a comment - updated tests to check for non existence for version file when format command did not succeed.
          Hide
          Arpit Gupta added a comment -

          added another test and cleaned up comments.

          Show
          Arpit Gupta added a comment - added another test and cleaned up comments.
          Hide
          Arpit Gupta added a comment -

          attached is a patch for branch 1.0.

          Show
          Arpit Gupta added a comment - attached is a patch for branch 1.0.
          Hide
          Arpit Gupta added a comment -

          ah i see what you mean now and i see that the confirmFormat method already supports these 2 options. I will read both these options.

          Show
          Arpit Gupta added a comment - ah i see what you mean now and i see that the confirmFormat method already supports these 2 options. I will read both these options.
          Hide
          Todd Lipcon added a comment -

          The difference is this:

          • format -force should overwrite existing dirs without prompting
          • format -nonInteractive should format if they don't exist, exit with a status code if they do
          • format should format if they don't exist, and prompt if they do

          Does the distinction make sense?

          Show
          Todd Lipcon added a comment - The difference is this: format -force should overwrite existing dirs without prompting format -nonInteractive should format if they don't exist, exit with a status code if they do format should format if they don't exist, and prompt if they do Does the distinction make sense?
          Hide
          Arpit Gupta added a comment -

          ah ok i was planning on calling that flag -force but i can call it -nonInteractive.

          Show
          Arpit Gupta added a comment - ah ok i was planning on calling that flag -force but i can call it -nonInteractive.
          Hide
          Todd Lipcon added a comment -

          Moved this to the HDFS project.

          If you don't mind, please also add a "-nonInteractive" flag – we have the hooks already in trunk to implement it. The use case is that scripts may want to run non-interactively, where pre-existence of the dirs is an error.

          Show
          Todd Lipcon added a comment - Moved this to the HDFS project. If you don't mind, please also add a "-nonInteractive" flag – we have the hooks already in trunk to implement it. The use case is that scripts may want to run non-interactively, where pre-existence of the dirs is an error.
          Hide
          Arpit Gupta added a comment -

          I will post patches for 1.0 and 0.24 shortly.

          Show
          Arpit Gupta added a comment - I will post patches for 1.0 and 0.24 shortly.

            People

            • Assignee:
              Arpit Gupta
              Reporter:
              Arpit Gupta
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development