Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: HA branch (HDFS-1623)
    • Fix Version/s: HA branch (HDFS-1623)
    • Component/s: build, ha
    • Labels:
      None

      Description

      There are a number of findbugs warnings on the branch that should be addressed before merge. This JIRA is to address them.

      1. hdfs-3039.txt
        17 kB
        Todd Lipcon
      2. hdfs-3039.txt
        14 kB
        Todd Lipcon
      3. HDFS-3039-HDFS-1623-javadoc.patch
        2 kB
        Aaron T. Myers

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-HAbranch-build #97 (See https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/97/)
        HDFS-3039. Address findbugs and javadoc warnings on branch. Contributed by Todd Lipcon. (Revision 1296017)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296017
        Files :

        • /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
        • /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        • /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAAdmin.java
        • /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java
        • /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ThreadUtil.java
        • /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt
        • /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        • /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
        • /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
        • /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
        • /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        • /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileJournalManager.java
        • /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-HAbranch-build #97 (See https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/97/ ) HDFS-3039 . Address findbugs and javadoc warnings on branch. Contributed by Todd Lipcon. (Revision 1296017) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296017 Files : /hadoop/common/branches/ HDFS-1623 /hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml /hadoop/common/branches/ HDFS-1623 /hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java /hadoop/common/branches/ HDFS-1623 /hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAAdmin.java /hadoop/common/branches/ HDFS-1623 /hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java /hadoop/common/branches/ HDFS-1623 /hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ThreadUtil.java /hadoop/common/branches/ HDFS-1623 /hadoop-hdfs-project/hadoop-hdfs/CHANGES. HDFS-1623 .txt /hadoop/common/branches/ HDFS-1623 /hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml /hadoop/common/branches/ HDFS-1623 /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java /hadoop/common/branches/ HDFS-1623 /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java /hadoop/common/branches/ HDFS-1623 /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java /hadoop/common/branches/ HDFS-1623 /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java /hadoop/common/branches/ HDFS-1623 /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java /hadoop/common/branches/ HDFS-1623 /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/branches/ HDFS-1623 /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileJournalManager.java /hadoop/common/branches/ HDFS-1623 /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
        Aaron T. Myers made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s HA branch (HDFS-1623) [ 12317568 ]
        Resolution Fixed [ 1 ]
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to the HA branch. Thanks a lot for the contribution, Todd.

        Show
        Aaron T. Myers added a comment - I've just committed this to the HA branch. Thanks a lot for the contribution, Todd.
        Hide
        Aaron T. Myers added a comment -

        +1, I applied the patch to the branch and the only findbugs warning I saw is the one being addressed by HDFS-3038.

        Show
        Aaron T. Myers added a comment - +1, I applied the patch to the branch and the only findbugs warning I saw is the one being addressed by HDFS-3038 .
        Todd Lipcon made changes -
        Attachment hdfs-3039.txt [ 12516766 ]
        Hide
        Todd Lipcon added a comment -

        New patch also addresses findbugs warnings in Common

        Show
        Todd Lipcon added a comment - New patch also addresses findbugs warnings in Common
        Todd Lipcon made changes -
        Attachment hdfs-3039.txt [ 12516763 ]
        Hide
        Todd Lipcon added a comment -

        attached patch incorporates Aaron's and addresses the findbugs warnings as well.
        There are a few more that show up when I run findbugs on the branch but they seem to be present in trunk as well using my version of findbugs.

        Show
        Todd Lipcon added a comment - attached patch incorporates Aaron's and addresses the findbugs warnings as well. There are a few more that show up when I run findbugs on the branch but they seem to be present in trunk as well using my version of findbugs.
        Hide
        Aaron T. Myers added a comment -

        I just checked for javac warnings on both trunk and the HA branch, and they're the same (1738.)

        Show
        Aaron T. Myers added a comment - I just checked for javac warnings on both trunk and the HA branch, and they're the same (1738.)
        Aaron T. Myers made changes -
        Attachment HDFS-3039-HDFS-1623-javadoc.patch [ 12516754 ]
        Hide
        Aaron T. Myers added a comment -

        Here's a patch which addresses the javadoc warnings. After this patch, the only remaining javadoc warnings are the following, all of which I believe to be unrelated to the HA branch:

        [WARNING] hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:30: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
        [WARNING] hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:31: warning: sun.security.krb5.KrbException is Sun proprietary API and may be removed in a future release
        [WARNING] hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:80: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
        [WARNING] hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java:21: warning: sun.security.jgss.GSSUtil is Sun proprietary API and may be removed in a future release
        [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:50: warning: sun.net.dns.ResolverConfiguration is Sun proprietary API and may be removed in a future release
        [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:51: warning: sun.net.util.IPAddressUtil is Sun proprietary API and may be removed in a future release
        [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:52: warning: sun.security.jgss.krb5.Krb5Util is Sun proprietary API and may be removed in a future release
        [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:53: warning: sun.security.krb5.Credentials is Sun proprietary API and may be removed in a future release
        [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:54: warning: sun.security.krb5.PrincipalName is Sun proprietary API and may be removed in a future release
        [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java:28: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release
        [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java:29: warning: sun.security.krb5.KrbException is Sun proprietary API and may be removed in a future release
        [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:25: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
        [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:117: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release
        [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java:33: warning - Tag @link: reference not found: org.apache.hadoop.mapreduce.jobhistory.JobHistory
        [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java:179: warning - @returns is an unknown tag.
        [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java:74: warning - Tag @link: can't find parseJobProperty() in org.apache.hadoop.tools.rumen.datatypes.util.MapReduceJobPropertiesParser
        [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java:74: warning - Tag @link: can't find parseJobProperty() in org.apache.hadoop.tools.rumen.datatypes.util.MapReduceJobPropertiesParser
        [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java:74: warning - Tag @link: can't find parseJobProperty() in org.apache.hadoop.tools.rumen.datatypes.util.MapReduceJobPropertiesParser
        [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/package-info.java:377: warning - Tag @link: can't find extractJobID(String) in org.apache.hadoop.tools.rumen.TraceBuilder
        [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java:33: warning - Tag @link: reference not found: org.apache.hadoop.mapreduce.jobhistory.JobHistory
        [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java:33: warning - Tag @link: reference not found: org.apache.hadoop.mapreduce.jobhistory.JobHistory
        [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java:33: warning - Tag @link: reference not found: org.apache.hadoop.mapreduce.jobhistory.JobHistory
        [WARNING] hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java:23: warning - Tag @link: reference not found: org.apache.hadoop.mapred 
        [WARNING] hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java:23: warning - Tag @link: reference not found: org.apache.hadoop.mapred 
        [WARNING] hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java:23: warning - Tag @link: reference not found: org.apache.hadoop.mapred 
        [WARNING] hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java:23: warning - Tag @link: reference not found: org.apache.hadoop.mapred
        
        Show
        Aaron T. Myers added a comment - Here's a patch which addresses the javadoc warnings. After this patch, the only remaining javadoc warnings are the following, all of which I believe to be unrelated to the HA branch: [WARNING] hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:30: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release [WARNING] hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:31: warning: sun.security.krb5.KrbException is Sun proprietary API and may be removed in a future release [WARNING] hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java:80: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release [WARNING] hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java:21: warning: sun.security.jgss.GSSUtil is Sun proprietary API and may be removed in a future release [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:50: warning: sun.net.dns.ResolverConfiguration is Sun proprietary API and may be removed in a future release [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:51: warning: sun.net.util.IPAddressUtil is Sun proprietary API and may be removed in a future release [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:52: warning: sun.security.jgss.krb5.Krb5Util is Sun proprietary API and may be removed in a future release [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:53: warning: sun.security.krb5.Credentials is Sun proprietary API and may be removed in a future release [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:54: warning: sun.security.krb5.PrincipalName is Sun proprietary API and may be removed in a future release [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java:28: warning: sun.security.krb5.Config is Sun proprietary API and may be removed in a future release [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/HadoopKerberosName.java:29: warning: sun.security.krb5.KrbException is Sun proprietary API and may be removed in a future release [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:25: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release [WARNING] hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/FastByteComparisons.java:117: warning: sun.misc.Unsafe is Sun proprietary API and may be removed in a future release [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java:33: warning - Tag @link: reference not found: org.apache.hadoop.mapreduce.jobhistory.JobHistory [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedTaskAttempt.java:179: warning - @returns is an unknown tag. [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java:74: warning - Tag @link: can't find parseJobProperty() in org.apache.hadoop.tools.rumen.datatypes.util.MapReduceJobPropertiesParser [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java:74: warning - Tag @link: can't find parseJobProperty() in org.apache.hadoop.tools.rumen.datatypes.util.MapReduceJobPropertiesParser [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/util/MapReduceJobPropertiesParser.java:74: warning - Tag @link: can't find parseJobProperty() in org.apache.hadoop.tools.rumen.datatypes.util.MapReduceJobPropertiesParser [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/package-info.java:377: warning - Tag @link: can't find extractJobID(String) in org.apache.hadoop.tools.rumen.TraceBuilder [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java:33: warning - Tag @link: reference not found: org.apache.hadoop.mapreduce.jobhistory.JobHistory [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java:33: warning - Tag @link: reference not found: org.apache.hadoop.mapreduce.jobhistory.JobHistory [WARNING] hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/CurrentJHParser.java:33: warning - Tag @link: reference not found: org.apache.hadoop.mapreduce.jobhistory.JobHistory [WARNING] hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java:23: warning - Tag @link: reference not found: org.apache.hadoop.mapred [WARNING] hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java:23: warning - Tag @link: reference not found: org.apache.hadoop.mapred [WARNING] hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java:23: warning - Tag @link: reference not found: org.apache.hadoop.mapred [WARNING] hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/mapred/tools/package-info.java:23: warning - Tag @link: reference not found: org.apache.hadoop.mapred
        Aaron T. Myers made changes -
        Parent HDFS-1623 [ 12498318 ]
        Issue Type Bug [ 1 ] Sub-task [ 7 ]
        Aaron T. Myers made changes -
        Field Original Value New Value
        Summary Address findbugs and javadoc warnings on branch HA: Address findbugs and javadoc warnings on branch
        Todd Lipcon created issue -

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development