Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3038

Add FSEditLog.metrics to findbugs exclude list

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.24.0, 0.23.3
    • Fix Version/s: 2.0.0-alpha
    • Component/s: None
    • Labels:
      None

      Description

      to fix a findbugs error on trunk – this field is only re-set by tests, no need to be worried about its synchronization.

      1. hdfs-3038.txt
        0.9 kB
        Todd Lipcon

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12516741/hdfs-3038.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
        org.apache.hadoop.hdfs.TestParallelRead
        org.apache.hadoop.hdfs.TestBlockMissingException
        org.apache.hadoop.hdfs.TestLargeBlock
        org.apache.hadoop.hdfs.TestCrcCorruption
        org.apache.hadoop.hdfs.TestReplication
        org.apache.hadoop.hdfs.TestDFSClientExcludedNodes
        org.apache.hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
        org.apache.hadoop.hdfs.TestRenameWhileOpen
        org.apache.hadoop.hdfs.TestLeaseRecovery
        org.apache.hadoop.hdfs.TestHDFSTrash
        org.apache.hadoop.hdfs.TestFileAppend4
        org.apache.hadoop.hdfs.TestQuota
        org.apache.hadoop.hdfs.security.token.block.TestBlockToken
        org.apache.hadoop.hdfs.TestFileAppend2
        org.apache.hadoop.hdfs.TestFileAppend3
        org.apache.hadoop.hdfs.TestReplaceDatanodeOnFailure
        org.apache.hadoop.hdfs.TestBalancerBandwidth
        org.apache.hadoop.hdfs.TestDFSShell
        org.apache.hadoop.hdfs.web.TestFSMainOperationsWebHdfs
        org.apache.hadoop.hdfs.security.TestDelegationToken
        org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
        org.apache.hadoop.hdfs.tools.TestGetGroups
        org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser
        org.apache.hadoop.hdfs.TestHDFSFileSystemContract
        org.apache.hadoop.hdfs.TestReadWhileWriting

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1935//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1935//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516741/hdfs-3038.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer org.apache.hadoop.hdfs.TestParallelRead org.apache.hadoop.hdfs.TestBlockMissingException org.apache.hadoop.hdfs.TestLargeBlock org.apache.hadoop.hdfs.TestCrcCorruption org.apache.hadoop.hdfs.TestReplication org.apache.hadoop.hdfs.TestDFSClientExcludedNodes org.apache.hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes org.apache.hadoop.hdfs.TestRenameWhileOpen org.apache.hadoop.hdfs.TestLeaseRecovery org.apache.hadoop.hdfs.TestHDFSTrash org.apache.hadoop.hdfs.TestFileAppend4 org.apache.hadoop.hdfs.TestQuota org.apache.hadoop.hdfs.security.token.block.TestBlockToken org.apache.hadoop.hdfs.TestFileAppend2 org.apache.hadoop.hdfs.TestFileAppend3 org.apache.hadoop.hdfs.TestReplaceDatanodeOnFailure org.apache.hadoop.hdfs.TestBalancerBandwidth org.apache.hadoop.hdfs.TestDFSShell org.apache.hadoop.hdfs.web.TestFSMainOperationsWebHdfs org.apache.hadoop.hdfs.security.TestDelegationToken org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract org.apache.hadoop.hdfs.tools.TestGetGroups org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser org.apache.hadoop.hdfs.TestHDFSFileSystemContract org.apache.hadoop.hdfs.TestReadWhileWriting +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1935//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1935//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Failed tests are obviously unrelated, since this just updates the findbugs exclude file.

        Show
        Todd Lipcon added a comment - Failed tests are obviously unrelated, since this just updates the findbugs exclude file.
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me.
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to trunk and branch-0.23. Thanks a lot for the contribution, Todd.

        Show
        Aaron T. Myers added a comment - I've just committed this to trunk and branch-0.23. Thanks a lot for the contribution, Todd.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #617 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/617/)
        HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296021)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296021
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #617 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/617/ ) HDFS-3038 . Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296021) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296021 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1820 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1820/)
        HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296019)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296019
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1820 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1820/ ) HDFS-3038 . Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296019) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296019 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1894 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1894/)
        HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296019)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296019
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1894 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1894/ ) HDFS-3038 . Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296019) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296019 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #628 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/628/)
        HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296021)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296021
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #628 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/628/ ) HDFS-3038 . Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296021) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296021 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #627 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/627/)
        HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296021)

        Result = ABORTED
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296021
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #627 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/627/ ) HDFS-3038 . Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296021) Result = ABORTED atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296021 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1827 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1827/)
        HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296019)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296019
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1827 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1827/ ) HDFS-3038 . Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296019) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296019 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #972 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/972/)
        HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296019)

        Result = UNSTABLE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296019
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #972 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/972/ ) HDFS-3038 . Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296019) Result = UNSTABLE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296019 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #185 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/185/)
        HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296021)

        Result = UNSTABLE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296021
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #185 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/185/ ) HDFS-3038 . Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296021) Result = UNSTABLE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296021 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #213 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/213/)
        HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296021)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296021
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #213 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/213/ ) HDFS-3038 . Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296021) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296021 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1007 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1007/)
        HDFS-3038. Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296019)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296019
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1007 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1007/ ) HDFS-3038 . Add FSEditLog.metrics to findbugs exclude list. Contributed by Todd Lipcon. (Revision 1296019) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1296019 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development