Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3036

Remove unused method DFSUtil#isDefaultNamenodeAddress

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: namenode
    • Labels:
      None

      Description

      DFSUtil#isDefaultNamenodeAddress is a private interface but is only referenced in a test for the behavior of this method.

      1. HDFS-3036.patch
        5 kB
        Aaron T. Myers

        Activity

        Hide
        Aaron T. Myers added a comment -

        Here's a patch which addresses the issue.

        Show
        Aaron T. Myers added a comment - Here's a patch which addresses the issue.
        Hide
        Todd Lipcon added a comment -

        +1

        Show
        Todd Lipcon added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12516715/HDFS-3036.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1933//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1933//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1933//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516715/HDFS-3036.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1933//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1933//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1933//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        The lone findbugs warning is unrelated and is tracked by HDFS-3038. I'm going to commit this momentarily.

        Show
        Aaron T. Myers added a comment - The lone findbugs warning is unrelated and is tracked by HDFS-3038 . I'm going to commit this momentarily.
        Hide
        Aaron T. Myers added a comment -

        Thanks a lot for the review, Todd. I've just committed this to the HA branch.

        Show
        Aaron T. Myers added a comment - Thanks a lot for the review, Todd. I've just committed this to the HA branch.
        Hide
        Aaron T. Myers added a comment -

        Whoops! I meant, committed to trunk.

        Show
        Aaron T. Myers added a comment - Whoops! I meant, committed to trunk.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1824 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1824/)
        HDFS-3036. Remove unused method DFSUtil#isDefaultNamenodeAddress. Contributed by Aaron T. Myers. (Revision 1295961)

        Result = ABORTED
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295961
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1824 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1824/ ) HDFS-3036 . Remove unused method DFSUtil#isDefaultNamenodeAddress. Contributed by Aaron T. Myers. (Revision 1295961) Result = ABORTED atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295961 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1892 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1892/)
        HDFS-3036. Remove unused method DFSUtil#isDefaultNamenodeAddress. Contributed by Aaron T. Myers. (Revision 1295961)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295961
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1892 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1892/ ) HDFS-3036 . Remove unused method DFSUtil#isDefaultNamenodeAddress. Contributed by Aaron T. Myers. (Revision 1295961) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295961 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1818 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1818/)
        HDFS-3036. Remove unused method DFSUtil#isDefaultNamenodeAddress. Contributed by Aaron T. Myers. (Revision 1295961)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295961
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1818 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1818/ ) HDFS-3036 . Remove unused method DFSUtil#isDefaultNamenodeAddress. Contributed by Aaron T. Myers. (Revision 1295961) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295961 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #972 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/972/)
        HDFS-3036. Remove unused method DFSUtil#isDefaultNamenodeAddress. Contributed by Aaron T. Myers. (Revision 1295961)

        Result = UNSTABLE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295961
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #972 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/972/ ) HDFS-3036 . Remove unused method DFSUtil#isDefaultNamenodeAddress. Contributed by Aaron T. Myers. (Revision 1295961) Result = UNSTABLE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295961 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1007 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1007/)
        HDFS-3036. Remove unused method DFSUtil#isDefaultNamenodeAddress. Contributed by Aaron T. Myers. (Revision 1295961)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295961
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1007 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1007/ ) HDFS-3036 . Remove unused method DFSUtil#isDefaultNamenodeAddress. Contributed by Aaron T. Myers. (Revision 1295961) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295961 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #670 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/670/)
        HDFS-3036. Merge r1295961 from trunk to 0.23 (Revision 1298251)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298251
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #670 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/670/ ) HDFS-3036 . Merge r1295961 from trunk to 0.23 (Revision 1298251) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298251 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #653 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/653/)
        HDFS-3036. Merge r1295961 from trunk to 0.23 (Revision 1298251)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298251
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #653 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/653/ ) HDFS-3036 . Merge r1295961 from trunk to 0.23 (Revision 1298251) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298251 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #662 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/662/)
        HDFS-3036. Merge r1295961 from trunk to 0.23 (Revision 1298251)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298251
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #662 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/662/ ) HDFS-3036 . Merge r1295961 from trunk to 0.23 (Revision 1298251) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298251 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUtil.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1926 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1926/)
        Moving HDFS-3036, HDFS-3014, HDFS-3003, HDFS-2878, HDFS-208, HDFS-2764, HDFS-2410, HDFS-2285, HDFS-2507 to 0.23.3 section (Revision 1298274)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298274
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1926 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1926/ ) Moving HDFS-3036 , HDFS-3014 , HDFS-3003 , HDFS-2878 , HDFS-208 , HDFS-2764 , HDFS-2410 , HDFS-2285 , HDFS-2507 to 0.23.3 section (Revision 1298274) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298274 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1860 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1860/)
        Moving HDFS-3036, HDFS-3014, HDFS-3003, HDFS-2878, HDFS-208, HDFS-2764, HDFS-2410, HDFS-2285, HDFS-2507 to 0.23.3 section (Revision 1298274)

        Result = ABORTED
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298274
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1860 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1860/ ) Moving HDFS-3036 , HDFS-3014 , HDFS-3003 , HDFS-2878 , HDFS-208 , HDFS-2764 , HDFS-2410 , HDFS-2285 , HDFS-2507 to 0.23.3 section (Revision 1298274) Result = ABORTED suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298274 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development