Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3024

Improve performance of stringification in addStoredBlock

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: namenode
    • Labels:
      None

      Description

      In looking at stack traces of a NN under a heavy block allocation load (around a thousand per second) I see that a lot of time is being taken up in stringification of log messages for addStoredBlock. This code can be optimized to use a single StringBuilder instead of a lot of nested toString() calls.

      1. hdfs-3024.txt
        5 kB
        Todd Lipcon

        Activity

        Todd Lipcon created issue -
        Todd Lipcon made changes -
        Field Original Value New Value
        Attachment hdfs-3024.txt [ 12516283 ]
        Todd Lipcon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 0.23.3, 0.24.0 [ 12320052, 12317653 ] 0.24.0, 0.23.3 [ 12317653, 12320052 ]
        Todd Lipcon made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Target Version/s 0.23.3, 0.24.0 [ 12320052, 12317653 ] 0.24.0, 0.23.3 [ 12317653, 12320052 ]
        Fix Version/s 0.24.0 [ 12317653 ]
        Fix Version/s 0.23.3 [ 12320052 ]
        Resolution Fixed [ 1 ]
        Arun C Murthy made changes -
        Fix Version/s 2.0.0 [ 12320353 ]
        Fix Version/s 0.24.0 [ 12317653 ]
        Fix Version/s 0.23.3 [ 12320052 ]

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development