Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-301

Provide better error messages when fs.default.name is invalid

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      this the followon to HADOOP-5687 - its not enough to detect bad uris, we need good error messages and a set of tests to make sure everything works as intended.

        Issue Links

          Activity

          Hide
          steve_l added a comment -

          I've submitted a patch that is simply a rename of the tests/changes attached to HADOOP-5867; the filename may be different, but not the code

          Show
          steve_l added a comment - I've submitted a patch that is simply a rename of the tests/changes attached to HADOOP-5867 ; the filename may be different, but not the code
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12408889/HADOOP-5095-1.patch
          against trunk revision 778994.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/407/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12408889/HADOOP-5095-1.patch against trunk revision 778994. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/407/console This message is automatically generated.
          Hide
          dhruba borthakur added a comment -

          @Steve: this patch does not merge with hdfs trunk anymore.

          Show
          dhruba borthakur added a comment - @Steve: this patch does not merge with hdfs trunk anymore.
          Hide
          steve_l added a comment -

          I'll work on this again. Move the tests to JUnit4 too

          Show
          steve_l added a comment - I'll work on this again. Move the tests to JUnit4 too
          Hide
          steve_l added a comment -

          This is going to be a fun patch to nurture through

          • Some of the error handling is in src/core/org/apache/hadoop/fs/FileSystem.java, in -common
          • More error handling is in the Namenode, patches and testing go into -hdfs

          I propose splitting the two

          1. -common code can have its own test, go into common
          2. Namenode patches can go in, test code moved to Junit4

          The the second patch depends on the first, or at least its tests do; there's no compile-time dependencies

          Show
          steve_l added a comment - This is going to be a fun patch to nurture through Some of the error handling is in src/core/org/apache/hadoop/fs/FileSystem.java, in -common More error handling is in the Namenode, patches and testing go into -hdfs I propose splitting the two -common code can have its own test, go into common Namenode patches can go in, test code moved to Junit4 The the second patch depends on the first, or at least its tests do; there's no compile-time dependencies

            People

            • Assignee:
              Steve Loughran
              Reporter:
              Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:

                Development