Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2976

Remove unnecessary method (tokenRefetchNeeded) in DFSClient

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 3.0.0
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Target Version/s:
    1. HDFS-2976.patch
      2 kB
      Uma Maheswara Rao G

      Activity

      Hide
      Uma Maheswara Rao G added a comment -

      Here is a trivial patch with removing the unused private method from DFSCLient

      Show
      Uma Maheswara Rao G added a comment - Here is a trivial patch with removing the unused private method from DFSCLient
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12515313/HDFS-2976.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in .

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1886//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1886//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12515313/HDFS-2976.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1886//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1886//console This message is automatically generated.
      Hide
      Aaron T. Myers added a comment -

      Thanks a lot for finding/filing this issue, Uma. I agree that this method appears to be totally unused, and the patch looks good to me.

      It looks like tokenRefetchNeeded was added in HDFS-2246. Before we commit this patch, I'm going to ping the authors of HDFS-2246 to see if perhaps the fact that this method isn't called is indicative of another issue.

      Show
      Aaron T. Myers added a comment - Thanks a lot for finding/filing this issue, Uma. I agree that this method appears to be totally unused, and the patch looks good to me. It looks like tokenRefetchNeeded was added in HDFS-2246 . Before we commit this patch, I'm going to ping the authors of HDFS-2246 to see if perhaps the fact that this method isn't called is indicative of another issue.
      Hide
      Aaron T. Myers added a comment -

      I tried to get in touch with the authors of HDFS-2246 offline, but got no response. In light of that, +1.

      Show
      Aaron T. Myers added a comment - I tried to get in touch with the authors of HDFS-2246 offline, but got no response. In light of that, +1.
      Hide
      Uma Maheswara Rao G added a comment -

      Thanks Aaron, will commit this patch.

      Show
      Uma Maheswara Rao G added a comment - Thanks Aaron, will commit this patch.
      Hide
      Uma Maheswara Rao G added a comment -

      I just committed this patch, Thanks Aaron for the review!

      Show
      Uma Maheswara Rao G added a comment - I just committed this patch, Thanks Aaron for the review!
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk-Commit #1927 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1927/)
      HDFS-2976. Remove unnecessary method (tokenRefetchNeeded) in DFSClient.
      (Contributed by Uma Maheswara Rao G) (Revision 1298495)

      Result = FAILURE
      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298495
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1927 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1927/ ) HDFS-2976 . Remove unnecessary method (tokenRefetchNeeded) in DFSClient. (Contributed by Uma Maheswara Rao G) (Revision 1298495) Result = FAILURE umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298495 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Common-trunk-Commit #1852 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1852/)
      HDFS-2976. Remove unnecessary method (tokenRefetchNeeded) in DFSClient.
      (Contributed by Uma Maheswara Rao G) (Revision 1298495)

      Result = SUCCESS
      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298495
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Show
      Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1852 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1852/ ) HDFS-2976 . Remove unnecessary method (tokenRefetchNeeded) in DFSClient. (Contributed by Uma Maheswara Rao G) (Revision 1298495) Result = SUCCESS umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298495 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Hide
      Aaron T. Myers added a comment -

      I think something may have gone wrong with this commit. Instead of removing the method from DFSClient, it's now included twice. Because of this, trunk does not compile.

      Show
      Aaron T. Myers added a comment - I think something may have gone wrong with this commit. Instead of removing the method from DFSClient, it's now included twice. Because of this, trunk does not compile.
      Hide
      Uma Maheswara Rao G added a comment -

      Yes, Aaron, I noticed it and corrected in next commit. Sorry for the wrong update.

      Show
      Uma Maheswara Rao G added a comment - Yes, Aaron, I noticed it and corrected in next commit. Sorry for the wrong update.
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk-Commit #1928 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1928/)
      HDFS-2976 removed the unused imports that were missed in previous commit. (Revision 1298508)
      HDFS-2976 corrected the previous wrong commit for this issue. (Revision 1298507)

      Result = SUCCESS
      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298508
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java

      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298507
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1928 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1928/ ) HDFS-2976 removed the unused imports that were missed in previous commit. (Revision 1298508) HDFS-2976 corrected the previous wrong commit for this issue. (Revision 1298507) Result = SUCCESS umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298508 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298507 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Common-trunk-Commit #1853 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1853/)
      HDFS-2976 removed the unused imports that were missed in previous commit. (Revision 1298508)
      HDFS-2976 corrected the previous wrong commit for this issue. (Revision 1298507)

      Result = SUCCESS
      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298508
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java

      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298507
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Show
      Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1853 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1853/ ) HDFS-2976 removed the unused imports that were missed in previous commit. (Revision 1298508) HDFS-2976 corrected the previous wrong commit for this issue. (Revision 1298507) Result = SUCCESS umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298508 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298507 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Hide
      Aaron T. Myers added a comment -

      Great, things seem to be back to working now. Thanks for catching it so quickly, Uma.

      Show
      Aaron T. Myers added a comment - Great, things seem to be back to working now. Thanks for catching it so quickly, Uma.
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk-Commit #1861 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1861/)
      HDFS-2976. Remove unnecessary method (tokenRefetchNeeded) in DFSClient.
      (Contributed by Uma Maheswara Rao G) (Revision 1298495)

      Result = ABORTED
      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298495
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1861 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1861/ ) HDFS-2976 . Remove unnecessary method (tokenRefetchNeeded) in DFSClient. (Contributed by Uma Maheswara Rao G) (Revision 1298495) Result = ABORTED umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298495 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk-Commit #1862 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1862/)
      HDFS-2976 removed the unused imports that were missed in previous commit. (Revision 1298508)
      HDFS-2976 corrected the previous wrong commit for this issue. (Revision 1298507)

      Result = ABORTED
      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298508
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java

      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298507
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1862 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1862/ ) HDFS-2976 removed the unused imports that were missed in previous commit. (Revision 1298508) HDFS-2976 corrected the previous wrong commit for this issue. (Revision 1298507) Result = ABORTED umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298508 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298507 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk #979 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/979/)
      HDFS-2976 removed the unused imports that were missed in previous commit. (Revision 1298508)
      HDFS-2976 corrected the previous wrong commit for this issue. (Revision 1298507)
      HDFS-2976. Remove unnecessary method (tokenRefetchNeeded) in DFSClient.
      (Contributed by Uma Maheswara Rao G) (Revision 1298495)

      Result = SUCCESS
      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298508
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java

      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298507
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java

      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298495
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #979 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/979/ ) HDFS-2976 removed the unused imports that were missed in previous commit. (Revision 1298508) HDFS-2976 corrected the previous wrong commit for this issue. (Revision 1298507) HDFS-2976 . Remove unnecessary method (tokenRefetchNeeded) in DFSClient. (Contributed by Uma Maheswara Rao G) (Revision 1298495) Result = SUCCESS umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298508 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298507 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298495 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #1014 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1014/)
      HDFS-2976 removed the unused imports that were missed in previous commit. (Revision 1298508)
      HDFS-2976 corrected the previous wrong commit for this issue. (Revision 1298507)
      HDFS-2976. Remove unnecessary method (tokenRefetchNeeded) in DFSClient.
      (Contributed by Uma Maheswara Rao G) (Revision 1298495)

      Result = SUCCESS
      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298508
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java

      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298507
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java

      umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298495
      Files :

      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1014 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1014/ ) HDFS-2976 removed the unused imports that were missed in previous commit. (Revision 1298508) HDFS-2976 corrected the previous wrong commit for this issue. (Revision 1298507) HDFS-2976 . Remove unnecessary method (tokenRefetchNeeded) in DFSClient. (Contributed by Uma Maheswara Rao G) (Revision 1298495) Result = SUCCESS umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298508 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298507 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298495 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java

        People

        • Assignee:
          Uma Maheswara Rao G
          Reporter:
          Uma Maheswara Rao G
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development