[HDFS-2966] TestNameNodeMetrics tests can fail under load

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0-alpha
• Fix Version/s: 2.0.2-alpha
• Component/s: test

Environment

OS/X running intellij IDEA, firefox, winxp in a virtualbox.

• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 17/Feb/12 18:07
• Updated: 11/Oct/12 17:46
• Resolved: 09/Mar/12 13:19

Description

I've managed to recreate HDFS-540 and HDFS-2434 by the simple technique of running the HDFS tests on a desktop with out enough memory for all the programs trying to run. Things got swapped out and the tests failed as the DN heartbeats didn't come in on time.

the tests both rely on waitForDeletion() to block the tests until the delete operation has completed, but all it does is sleep for the same number of seconds as there are datanodes. This is too brittle -it may work on a lightly-loaded system, but not on a system under heavy load where it is taking longer to replicate than expect.

Immediate fix: double, triple, the sleep time?
Better fix: have the thread block until all the DN heartbeats have finished.

Issue Links

• incorporates: HDFS-2434 TestNameNodeMetrics.testCorruptBlock fails intermittently
• incorporates: HDFS-540 TestNameNodeMetrics fails intermittently
• is related to: HDFS-3812 TestNameNodeMetrics.testCorruptBlock fails
• is related to: HDFS-3002 TestNameNodeMetrics need not wait for metrics update with new metrics framework