Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2944

Typo in hdfs-default.xml causes dfs.client.block.write.replace-datanode-on-failure.enable to be mistakenly disabled

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 0.23.2
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Target Version/s:

      Description

      Here, "ture" should be "true" if we really do want this feature enabled by default.

      <property>
        <name>dfs.client.block.write.replace-datanode-on-failure.enable</name>
        <value>ture</value>
        ...
      </property>
      
      1. HDFS-2944.patch
        1 kB
        Aaron T. Myers

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #999 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/999/)
          Move HDFS-2944 entry to 0.23 in CHANGES.txt. (Revision 1292624)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292624
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #999 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/999/ ) Move HDFS-2944 entry to 0.23 in CHANGES.txt. (Revision 1292624) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292624 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Build #205 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/205/)
          svn merge -c 1243690 from trunk for HDFS-2944. (Revision 1292622)

          Result = FAILURE
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292622
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #205 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/205/ ) svn merge -c 1243690 from trunk for HDFS-2944 . (Revision 1292622) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292622 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #177 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/177/)
          svn merge -c 1243690 from trunk for HDFS-2944. (Revision 1292622)

          Result = UNSTABLE
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292622
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #177 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/177/ ) svn merge -c 1243690 from trunk for HDFS-2944 . (Revision 1292622) Result = UNSTABLE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292622 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #964 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/964/)
          Move HDFS-2944 entry to 0.23 in CHANGES.txt. (Revision 1292624)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292624
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #964 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/964/ ) Move HDFS-2944 entry to 0.23 in CHANGES.txt. (Revision 1292624) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292624 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1776 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1776/)
          Move HDFS-2944 entry to 0.23 in CHANGES.txt. (Revision 1292624)

          Result = ABORTED
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292624
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1776 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1776/ ) Move HDFS-2944 entry to 0.23 in CHANGES.txt. (Revision 1292624) Result = ABORTED szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292624 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Commit #586 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/586/)
          svn merge -c 1243690 from trunk for HDFS-2944. (Revision 1292622)

          Result = ABORTED
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292622
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #586 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/586/ ) svn merge -c 1243690 from trunk for HDFS-2944 . (Revision 1292622) Result = ABORTED szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292622 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1839 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1839/)
          Move HDFS-2944 entry to 0.23 in CHANGES.txt. (Revision 1292624)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292624
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1839 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1839/ ) Move HDFS-2944 entry to 0.23 in CHANGES.txt. (Revision 1292624) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292624 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1765 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1765/)
          Move HDFS-2944 entry to 0.23 in CHANGES.txt. (Revision 1292624)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292624
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1765 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1765/ ) Move HDFS-2944 entry to 0.23 in CHANGES.txt. (Revision 1292624) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292624 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-0.23-Commit #584 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/584/)
          svn merge -c 1243690 from trunk for HDFS-2944. (Revision 1292622)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292622
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #584 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/584/ ) svn merge -c 1243690 from trunk for HDFS-2944 . (Revision 1292622) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292622 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Commit #571 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/571/)
          svn merge -c 1243690 from trunk for HDFS-2944. (Revision 1292622)

          Result = SUCCESS
          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292622
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #571 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/571/ ) svn merge -c 1243690 from trunk for HDFS-2944 . (Revision 1292622) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1292622 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Merged to 0.23. Thanks Aaron for catching the typo.

          Show
          Tsz Wo Nicholas Sze added a comment - Merged to 0.23. Thanks Aaron for catching the typo.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Reopen for committing it to 0.23.

          Show
          Tsz Wo Nicholas Sze added a comment - Reopen for committing it to 0.23.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Thanks, I created HDFS-2981.

          Show
          Tsz Wo Nicholas Sze added a comment - Thanks, I created HDFS-2981 .
          Hide
          Aaron T. Myers added a comment -

          The feature was designed to be enabled by default. Do you see any reason to disable it?

          I know of no reason this should be disabled by default, but I'm also not familiar with the development history of the feature. Thus, I figured that should be done as a separate JIRA, given that it's an actual behavior change. Feel free to file the JIRA if you think that change should be made.

          Show
          Aaron T. Myers added a comment - The feature was designed to be enabled by default. Do you see any reason to disable it? I know of no reason this should be disabled by default, but I'm also not familiar with the development history of the feature. Thus, I figured that should be done as a separate JIRA, given that it's an actual behavior change. Feel free to file the JIRA if you think that change should be made.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          > ... I decided to change the value to "false" to preserve the current behavior of having the feature disabled by default.

          The feature was designed to be enabled by default. Do you see any reason to disable it?

          Show
          Tsz Wo Nicholas Sze added a comment - > ... I decided to change the value to "false" to preserve the current behavior of having the feature disabled by default. The feature was designed to be enabled by default. Do you see any reason to disable it?
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #990 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/990/)
          HDFS-2944. Typo in hdfs-default.xml causes dfs.client.block.write.replace-datanode-on-failure.enable to be mistakenly disabled. Contributed by Aaron T. Myers. (Revision 1243690)

          Result = SUCCESS
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243690
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #990 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/990/ ) HDFS-2944 . Typo in hdfs-default.xml causes dfs.client.block.write.replace-datanode-on-failure.enable to be mistakenly disabled. Contributed by Aaron T. Myers. (Revision 1243690) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243690 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #955 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/955/)
          HDFS-2944. Typo in hdfs-default.xml causes dfs.client.block.write.replace-datanode-on-failure.enable to be mistakenly disabled. Contributed by Aaron T. Myers. (Revision 1243690)

          Result = FAILURE
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243690
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #955 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/955/ ) HDFS-2944 . Typo in hdfs-default.xml causes dfs.client.block.write.replace-datanode-on-failure.enable to be mistakenly disabled. Contributed by Aaron T. Myers. (Revision 1243690) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243690 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1733 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1733/)
          HDFS-2944. Typo in hdfs-default.xml causes dfs.client.block.write.replace-datanode-on-failure.enable to be mistakenly disabled. Contributed by Aaron T. Myers. (Revision 1243690)

          Result = FAILURE
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243690
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1733 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1733/ ) HDFS-2944 . Typo in hdfs-default.xml causes dfs.client.block.write.replace-datanode-on-failure.enable to be mistakenly disabled. Contributed by Aaron T. Myers. (Revision 1243690) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243690 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1722 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1722/)
          HDFS-2944. Typo in hdfs-default.xml causes dfs.client.block.write.replace-datanode-on-failure.enable to be mistakenly disabled. Contributed by Aaron T. Myers. (Revision 1243690)

          Result = SUCCESS
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243690
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1722 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1722/ ) HDFS-2944 . Typo in hdfs-default.xml causes dfs.client.block.write.replace-datanode-on-failure.enable to be mistakenly disabled. Contributed by Aaron T. Myers. (Revision 1243690) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243690 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1796 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1796/)
          HDFS-2944. Typo in hdfs-default.xml causes dfs.client.block.write.replace-datanode-on-failure.enable to be mistakenly disabled. Contributed by Aaron T. Myers. (Revision 1243690)

          Result = SUCCESS
          atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243690
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1796 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1796/ ) HDFS-2944 . Typo in hdfs-default.xml causes dfs.client.block.write.replace-datanode-on-failure.enable to be mistakenly disabled. Contributed by Aaron T. Myers. (Revision 1243690) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243690 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
          Hide
          Aaron T. Myers added a comment -

          Thanks for the review, Eli. I've just committed this to trunk.

          Show
          Aaron T. Myers added a comment - Thanks for the review, Eli. I've just committed this to trunk.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12514389/HDFS-2944.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1866//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1866//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12514389/HDFS-2944.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1866//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1866//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          +1

          Show
          Eli Collins added a comment - +1
          Hide
          Aaron T. Myers added a comment -

          Here's a trivial patch. I decided to change the value to "false" to preserve the current behavior of having the feature disabled by default.

          I also took the liberty of fixing another nearby typo.

          Show
          Aaron T. Myers added a comment - Here's a trivial patch. I decided to change the value to "false" to preserve the current behavior of having the feature disabled by default. I also took the liberty of fixing another nearby typo.

            People

            • Assignee:
              Aaron T. Myers
              Reporter:
              Aaron T. Myers
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development