Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2923

Namenode IPC handler count uses the wrong configuration key

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 0.23.1
    • Fix Version/s: 0.24.0, 0.23.1
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Target Version/s:

      Description

      In HDFS-1763, there was a typo introduced which causes the namenode to use dfs.datanode.handler.count to set the number of IPC threads instead of the correct dfs.namenode.handler.count. This results in bad performance under high load, since there are not nearly enough handlers.

      1. hdfs-2923.txt
        0.9 kB
        Todd Lipcon

        Activity

        Hide
        Todd Lipcon added a comment -

        Attached patch fixes the issue.
        I didn't write a unit test here since it's not likely to regress, and it was caught by existing scale test procedures.

        Show
        Todd Lipcon added a comment - Attached patch fixes the issue. I didn't write a unit test here since it's not likely to regress, and it was caught by existing scale test procedures.
        Hide
        Eli Collins added a comment -

        +1 I looked for other similar mistakes in HDFS-1763 and didn't see any.

        Show
        Eli Collins added a comment - +1 I looked for other similar mistakes in HDFS-1763 and didn't see any.
        Hide
        Todd Lipcon added a comment -

        Committed to branch, thanks for reviewing Eli.

        Show
        Todd Lipcon added a comment - Committed to branch, thanks for reviewing Eli.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #517 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/517/)
        HDFS-2923. Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242219
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #517 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/517/ ) HDFS-2923 . Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242219 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1776 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1776/)
        HDFS-2923. Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242220
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1776 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1776/ ) HDFS-2923 . Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242220 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1701 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1701/)
        HDFS-2923. Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242220
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1701 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1701/ ) HDFS-2923 . Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242220 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #528 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/528/)
        HDFS-2923. Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242219
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #528 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/528/ ) HDFS-2923 . Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242219 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1712 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1712/)
        HDFS-2923. Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242220
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1712 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1712/ ) HDFS-2923 . Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242220 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #532 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/532/)
        HDFS-2923. Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242219
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #532 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/532/ ) HDFS-2923 . Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242219 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #951 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/951/)
        HDFS-2923. Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242220
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #951 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/951/ ) HDFS-2923 . Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242220 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #164 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/164/)
        HDFS-2923. Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242219
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #164 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/164/ ) HDFS-2923 . Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242219 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #186 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/186/)
        HDFS-2923. Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242219
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #186 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/186/ ) HDFS-2923 . Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242219 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #984 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/984/)
        HDFS-2923. Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242220
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #984 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/984/ ) HDFS-2923 . Namenode IPC handler count uses the wrong configuration key. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242220 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Mahadev konar added a comment -

        Just merged to 0.23.1 branch.

        Show
        Mahadev konar added a comment - Just merged to 0.23.1 branch.

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development