Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: HA branch (HDFS-1623)
    • Fix Version/s: HA branch (HDFS-1623)
    • Component/s: ha
    • Labels:
      None

      Description

      TestDFSRollback#testRollback is failing post HDFS-2824. Looks like a test asserting now incorrect behavior.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-HAbranch-build #67 (See https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/67/)
        HDFS-2860. TestDFSRollback#testRollback is failing. Contributed by Aaron T. Myers.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239968
        Files :

        • /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt
        • /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSRollback.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-HAbranch-build #67 (See https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/67/ ) HDFS-2860 . TestDFSRollback#testRollback is failing. Contributed by Aaron T. Myers. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1239968 Files : /hadoop/common/branches/ HDFS-1623 /hadoop-hdfs-project/hadoop-hdfs/CHANGES. HDFS-1623 .txt /hadoop/common/branches/ HDFS-1623 /hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSRollback.java
        Hide
        Aaron T. Myers added a comment -

        Thanks a lot for the review, Eli. I've just committed this.

        Show
        Aaron T. Myers added a comment - Thanks a lot for the review, Eli. I've just committed this.
        Hide
        Eli Collins added a comment -

        +1 sorry should have caught this when filing!

        Show
        Eli Collins added a comment - +1 sorry should have caught this when filing!
        Hide
        Aaron T. Myers added a comment -

        Trivial patch attached that just changes the expected exception text.

        Show
        Aaron T. Myers added a comment - Trivial patch attached that just changes the expected exception text.
        Hide
        Eli Collins added a comment -

        Here's the failing assert:

        junit.framework.AssertionFailedError: Expected substring 'Gap in transactions. Expected to be able to read up until at least txid ' in exception but got: java.io.IOException: No non-corrupt logs for txid 26
                at org.apache.hadoop.hdfs.server.namenode.JournalSet.getInputStream(JournalSet.java:234)
                at org.apache.hadoop.hdfs.server.namenode.FSEditLog.selectInputStreams(FSEditLog.java:1074)
                at org.apache.hadoop.hdfs.server.namenode.FSImage.loadFSImage(FSImage.java:592)
                at org.apache.hadoop.hdfs.server.namenode.FSImage.recoverTransitionRead(FSImage.java:245)
                at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFSImage(FSNamesystem.java:441)
                at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFromDisk(FSNamesystem.java:380)
                at org.apache.hadoop.hdfs.server.namenode.NameNode.loadNamesystem(NameNode.java:351)
                at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:385)
                at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:540)
                at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:526)
                at org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:836)
                at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNode(MiniDFSCluster.java:752)
                at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:658)
                at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:559)
        
        Show
        Eli Collins added a comment - Here's the failing assert: junit.framework.AssertionFailedError: Expected substring 'Gap in transactions. Expected to be able to read up until at least txid ' in exception but got: java.io.IOException: No non-corrupt logs for txid 26 at org.apache.hadoop.hdfs.server.namenode.JournalSet.getInputStream(JournalSet.java:234) at org.apache.hadoop.hdfs.server.namenode.FSEditLog.selectInputStreams(FSEditLog.java:1074) at org.apache.hadoop.hdfs.server.namenode.FSImage.loadFSImage(FSImage.java:592) at org.apache.hadoop.hdfs.server.namenode.FSImage.recoverTransitionRead(FSImage.java:245) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFSImage(FSNamesystem.java:441) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFromDisk(FSNamesystem.java:380) at org.apache.hadoop.hdfs.server.namenode.NameNode.loadNamesystem(NameNode.java:351) at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:385) at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:540) at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:526) at org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:836) at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNode(MiniDFSCluster.java:752) at org.apache.hadoop.hdfs.MiniDFSCluster.createNameNodesAndSetConf(MiniDFSCluster.java:658) at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:559)

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development