Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.0-alpha
    • Component/s: datanode, namenode
    • Labels:
      None

      Description

      It would be useful for tools to be able to retrieve the total number of blocks on each datanode.

      1. HDFS-2708.patch
        2 kB
        Aaron T. Myers

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1049 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1049/)
        HDFS-2708. Stats for the # of blocks per DN. Contributed by Aaron T. Myers. (Revision 1326039)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326039
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1049 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1049/ ) HDFS-2708 . Stats for the # of blocks per DN. Contributed by Aaron T. Myers. (Revision 1326039) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326039 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1014 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1014/)
        HDFS-2708. Stats for the # of blocks per DN. Contributed by Aaron T. Myers. (Revision 1326039)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326039
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1014 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1014/ ) HDFS-2708 . Stats for the # of blocks per DN. Contributed by Aaron T. Myers. (Revision 1326039) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326039 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2088 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2088/)
        HDFS-2708. Stats for the # of blocks per DN. Contributed by Aaron T. Myers. (Revision 1326039)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326039
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2088 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2088/ ) HDFS-2708 . Stats for the # of blocks per DN. Contributed by Aaron T. Myers. (Revision 1326039) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326039 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2074 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2074/)
        HDFS-2708. Stats for the # of blocks per DN. Contributed by Aaron T. Myers. (Revision 1326039)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326039
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2074 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2074/ ) HDFS-2708 . Stats for the # of blocks per DN. Contributed by Aaron T. Myers. (Revision 1326039) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326039 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2147 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2147/)
        HDFS-2708. Stats for the # of blocks per DN. Contributed by Aaron T. Myers. (Revision 1326039)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326039
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2147 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2147/ ) HDFS-2708 . Stats for the # of blocks per DN. Contributed by Aaron T. Myers. (Revision 1326039) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326039 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
        Aaron T. Myers made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.0.0 [ 12320353 ]
        Resolution Fixed [ 1 ]
        Hide
        Aaron T. Myers added a comment -

        Thanks a lot for the review, Todd. I've just committed this to trunk and branch-2.

        Show
        Aaron T. Myers added a comment - Thanks a lot for the review, Todd. I've just committed this to trunk and branch-2.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522641/HDFS-2708.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2275//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2275//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522641/HDFS-2708.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2275//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2275//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        +1 pending jenkins

        Show
        Todd Lipcon added a comment - +1 pending jenkins
        Aaron T. Myers made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Aaron T. Myers made changes -
        Attachment HDFS-2708.patch [ 12522641 ]
        Hide
        Aaron T. Myers added a comment -

        Here's a patch for trunk which adds a "numBlocks" field to each DN in the "LiveNodes" field of the NameNodeInfo JMX interface.

        Show
        Aaron T. Myers added a comment - Here's a patch for trunk which adds a "numBlocks" field to each DN in the "LiveNodes" field of the NameNodeInfo JMX interface.
        Aaron T. Myers made changes -
        Field Original Value New Value
        Summary Stats for the total # blocks and blocks per DN Stats for the # of blocks per DN
        Assignee Aaron T. Myers [ atm ]
        Affects Version/s 2.0.0 [ 12320353 ]
        Target Version/s 1.1.0, 0.23.1 [ 12317959, 12318885 ] 2.0.0 [ 12320353 ]
        Description It would be useful for tools to be able to retrieve the total # blocks in the file system (and also display eg via dfsadmin report, this is currently only available via FSNamesystemMetrics, so would add to ClientProtocol#getStats?) and the total number of blocks on each datanode (via DataNodeInfo). It would be useful for tools to be able to retrieve the total number of blocks on each datanode.
        Hide
        Aaron T. Myers added a comment -

        Let's separate the original description of this JIRA into multiple distinct issues. In this JIRA, let's just add support for getting the number of blocks on each DN via the FSNamesystem metrics, since that interface already has support for retrieving the total number of blocks in the file system.

        If we really do want to add other interfaces to retrieve both of these metrics, let's do that in a separate JIRA.

        Show
        Aaron T. Myers added a comment - Let's separate the original description of this JIRA into multiple distinct issues. In this JIRA, let's just add support for getting the number of blocks on each DN via the FSNamesystem metrics, since that interface already has support for retrieving the total number of blocks in the file system. If we really do want to add other interfaces to retrieve both of these metrics, let's do that in a separate JIRA.
        Eli Collins created issue -

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development