Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2675

Reduce verbosity when double-closing edit logs

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.1
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Currently the edit logs log at WARN level when they're double-closed. But this happens in the normal flow of things, so we may as well reduce it to DEBUG to reduce log spam in unit tests, etc.

      1. hdfs-2675.txt
        1.0 kB
        Todd Lipcon

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #894 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/894/)
        HDFS-2675. Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214098
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #894 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/894/ ) HDFS-2675 . Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214098 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #927 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/927/)
        HDFS-2675. Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214098
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #927 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/927/ ) HDFS-2675 . Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214098 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #125 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/125/)
        HDFS-2675. Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214096
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #125 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/125/ ) HDFS-2675 . Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214096 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #107 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/107/)
        HDFS-2675. Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214096
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #107 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/107/ ) HDFS-2675 . Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214096 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #298 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/298/)
        HDFS-2675. Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214096
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #298 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/298/ ) HDFS-2675 . Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214096 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1450 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1450/)
        HDFS-2675. Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214098
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1450 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1450/ ) HDFS-2675 . Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214098 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #286 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/286/)
        HDFS-2675. Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214096
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #286 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/286/ ) HDFS-2675 . Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214096 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1426 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1426/)
        HDFS-2675. Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214098
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1426 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1426/ ) HDFS-2675 . Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214098 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1500 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1500/)
        HDFS-2675. Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214098
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1500 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1500/ ) HDFS-2675 . Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214098 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #276 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/276/)
        HDFS-2675. Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214096
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #276 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/276/ ) HDFS-2675 . Reduce warning verbosity when double-closing edit logs. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1214096 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
        Hide
        Todd Lipcon added a comment -

        Committed to 23 and trunk, thx

        Show
        Todd Lipcon added a comment - Committed to 23 and trunk, thx
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me.
        Hide
        Todd Lipcon added a comment -

        Trivial patch to change to DEBUG level

        Show
        Todd Lipcon added a comment - Trivial patch to change to DEBUG level

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development