[HDFS-2624] HA: ConfiguredFailoverProxyProvider doesn't correctly stop ProtocolTranslators

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: HA branch (HDFS-1623)
• Fix Version/s: HA branch (HDFS-1623)
• Component/s: ha, hdfs-client
• Target Version/s: HA branch (HDFS-1623)
• Hadoop Flags: Reviewed
• Assignee: Todd Lipcon
• Reporter: Todd Lipcon
• Created: 03/Dec/11 00:29
• Updated: 24/Jan/12 19:51
• Resolved: 05/Dec/11 06:37

Description

In the tip of branch, the direct proxies to the NN have been replaced by ProtocolTranslator implementations. But, the proxy provider still calls RPC.stopProxy, which generates a warning and doesn't actually stop the proxy. We need to check if the protocol implementation is a Closeable and call close() instead in that case.